Skip to content

Commit 56748a8

Browse files
committed
Allow Edge tests to fail
Window's `msedgedriver` seems to be unreliable, as port binding will occasionally fail. Instead of wasting time trying to debug this, just let the tests fail. We take a similar approch for Safari's webdriver, we will allow the tests to fail, but will hopefully see when they start succeeding (when Safari fixes the COOP bug). Signed-off-by: Joe Richey <[email protected]>
1 parent 74a2021 commit 56748a8

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

.github/workflows/tests.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,11 +220,14 @@ jobs:
220220
run: wasm-pack test --headless --chrome --features=js,test-in-browser
221221
- name: Test (Edge)
222222
if: runner.os == 'Windows'
223+
# Edge has flaky failures: "driver failed to bind port during startup"
224+
continue-on-error: true
223225
run: wasm-pack test --headless --chrome --chromedriver $Env:EDGEWEBDRIVER\msedgedriver.exe --features=js,test-in-browser
224-
# Safari tests are broken: https://github.com/rustwasm/wasm-bindgen/issues/3004
225-
# - name: Test (Safari)
226-
# if: runner.os == 'macOS'
227-
# run: wasm-pack test --headless --safari --features=js,test-in-browser
226+
- name: Test (Safari)
227+
if: runner.os == 'macOS'
228+
# Safari tests are broken: https://github.com/rustwasm/wasm-bindgen/issues/3004
229+
continue-on-error: true
230+
run: wasm-pack test --headless --safari --features=js,test-in-browser
228231
- name: Test (custom getrandom)
229232
run: wasm-pack test --node --features=custom
230233

0 commit comments

Comments
 (0)