Skip to content

Fix the time inconsistency on selecting date in DatePicker component #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

pradumangoyal
Copy link
Contributor

Fixes #857

Additional description

Hi @interactivellama, I have set the date to midnight(to maintain cosistency) on the same day as seen in the screenshot attached. Kindly review it, and suggest any changes if required.

date-patch


CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • npm run lint:fix has been run and linting passes.
  • Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

…e is changed to maintain consistency among the dates
@pradumangoyal
Copy link
Contributor Author

@interactivellama, Can you please review this. I have also commented some explanation on issue #857 about the solution I adopted.

@interactivellama interactivellama self-requested a review March 28, 2019 05:18
@stale stale bot added the stale label May 27, 2019
@salesforce salesforce deleted a comment from stale bot May 27, 2019
@stale stale bot removed the stale label May 27, 2019
@stale stale bot added the stale label Jul 26, 2019
@stale stale bot closed this Aug 2, 2019
@salesforce salesforce deleted a comment from stale bot Aug 2, 2019
@stale stale bot removed the stale label Aug 2, 2019
@stale stale bot added the stale label Oct 1, 2019
@salesforce salesforce deleted a comment from stale bot Oct 1, 2019
@stale stale bot removed the stale label Oct 1, 2019
@stale
Copy link

stale bot commented Dec 1, 2019

This issue has been automatically marked as stale, because it has not had recent activity. It will be closed if no further activity occurs. Maintainers are responsible for tech debt and project health. This is most likely a new components or component feature request. Please submit a pull request for or request feedback on this feature. Thank you.

@stale stale bot added the stale label Dec 1, 2019
@stale stale bot closed this Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent date output in Datepicker
2 participants