Skip to content

Commit 51a807c

Browse files
authored
Merge pull request #639 from matil019/readablestream-pipeto-promise
Change ReadableStream#pipeTo to return js.Promise[Unit]
2 parents 3ee2142 + 49c89d2 commit 51a807c

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

api-reports/2_12.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -15851,7 +15851,7 @@ ReadableStream[JT] def cancel(reason: js.UndefOr[Any]?): js.Promise[Unit]
1585115851
ReadableStream[JT] def getReader(): ReadableStreamReader[T]
1585215852
ReadableStream[JT] def locked: Boolean
1585315853
ReadableStream[JT] def pipeThrough[U](pair: Any, options: Any?): ReadableStream[U]
15854-
ReadableStream[JT] def pipeTo(dest: WriteableStream[T], options: Any?): Unit
15854+
ReadableStream[JT] def pipeTo(dest: WriteableStream[T], options: Any?): js.Promise[Unit]
1585515855
ReadableStream[JT] def tee(): js.Array[_ <: ReadableStream[T]]
1585615856
ReadableStream[SO] def apply[T](underlyingSource: js.UndefOr[ReadableStreamUnderlyingSource[T]]?, queuingStrategy: js.UndefOr[QueuingStrategy[T]]?): ReadableStream[T]
1585715857
ReadableStreamController[JC] def close(): Unit

api-reports/2_13.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -15851,7 +15851,7 @@ ReadableStream[JT] def cancel(reason: js.UndefOr[Any]?): js.Promise[Unit]
1585115851
ReadableStream[JT] def getReader(): ReadableStreamReader[T]
1585215852
ReadableStream[JT] def locked: Boolean
1585315853
ReadableStream[JT] def pipeThrough[U](pair: Any, options: Any?): ReadableStream[U]
15854-
ReadableStream[JT] def pipeTo(dest: WriteableStream[T], options: Any?): Unit
15854+
ReadableStream[JT] def pipeTo(dest: WriteableStream[T], options: Any?): js.Promise[Unit]
1585515855
ReadableStream[JT] def tee(): js.Array[_ <: ReadableStream[T]]
1585615856
ReadableStream[SO] def apply[T](underlyingSource: js.UndefOr[ReadableStreamUnderlyingSource[T]]?, queuingStrategy: js.UndefOr[QueuingStrategy[T]]?): ReadableStream[T]
1585715857
ReadableStreamController[JC] def close(): Unit

dom/src/main/scala/org/scalajs/dom/ReadableStream.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ trait ReadableStream[+T] extends js.Object {
7575
*
7676
* //todo: determine the type of options
7777
*/
78-
def pipeTo(dest: WriteableStream[T], options: Any = js.native): Unit = js.native
78+
def pipeTo(dest: WriteableStream[T], options: Any = js.native): js.Promise[Unit] = js.native
7979

8080
/** See [[https://streams.spec.whatwg.org/#rs-tee ¶3.2.4.6. tee()]] of whatwg streams spec.
8181
*

0 commit comments

Comments
 (0)