Skip to content

Commit d912d9f

Browse files
authored
Merge pull request #494 from scala-js/topic/fetch-preload-response
Fix return type of `FetchEvent.preloadResponse`
2 parents 116cc24 + e26e60d commit d912d9f

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

api-reports/2_12.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -985,7 +985,7 @@ experimental/serviceworkers/ExtendableMessageEventInit[JT] var scoped: js.UndefO
985985
experimental/serviceworkers/ExtendableMessageEventInit[JT] var source: js.UndefOr[Client | ServiceWorker | MessagePort]
986986
experimental/serviceworkers/FetchEvent[SC] def clientId: String
987987
experimental/serviceworkers/FetchEvent[SC] def isReload: Boolean
988-
experimental/serviceworkers/FetchEvent[SC] def preloadResponse: js.Promise[Response]
988+
experimental/serviceworkers/FetchEvent[SC] def preloadResponse: js.Promise[js.UndefOr[Response]]
989989
experimental/serviceworkers/FetchEvent[SC] def replacesClientId: String
990990
experimental/serviceworkers/FetchEvent[SC] def request: Request
991991
experimental/serviceworkers/FetchEvent[SC] def respondWith(promisedResponse: Response | js.Promise[Response]): Unit

api-reports/2_13.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -985,7 +985,7 @@ experimental/serviceworkers/ExtendableMessageEventInit[JT] var scoped: js.UndefO
985985
experimental/serviceworkers/ExtendableMessageEventInit[JT] var source: js.UndefOr[Client | ServiceWorker | MessagePort]
986986
experimental/serviceworkers/FetchEvent[SC] def clientId: String
987987
experimental/serviceworkers/FetchEvent[SC] def isReload: Boolean
988-
experimental/serviceworkers/FetchEvent[SC] def preloadResponse: js.Promise[Response]
988+
experimental/serviceworkers/FetchEvent[SC] def preloadResponse: js.Promise[js.UndefOr[Response]]
989989
experimental/serviceworkers/FetchEvent[SC] def replacesClientId: String
990990
experimental/serviceworkers/FetchEvent[SC] def request: Request
991991
experimental/serviceworkers/FetchEvent[SC] def respondWith(promisedResponse: Response | js.Promise[Response]): Unit

src/main/scala/org/scalajs/dom/experimental/serviceworkers/ServiceWorkers.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ class FetchEvent(typeArg: String, init: js.UndefOr[FetchEventInit])
111111
*/
112112
def request: Request = js.native
113113

114-
def preloadResponse: js.Promise[Response] = js.native
114+
def preloadResponse: js.Promise[js.UndefOr[Response]] = js.native
115115

116116
def clientId: String = js.native
117117

0 commit comments

Comments
 (0)