[WIP] RefChecks takes object as lazy #10250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
reviewed
Jan 5, 2023
som-snytt
force-pushed
the
issue/5187-object-override-lazyval
branch
from
573cc2f to
bb94c13
Compare
lrytz
reviewed
Jan 18, 2023
| @@ -39,8 +39,8 @@ class C extends A { | |||
| override object oneArg // fail | |||
| } | |||
| class C0 extends A0 { | |||
| override object value // !!! this succeeds, but should fail (lazy over strict) | |||
| override object lazyvalue // !!! this fails, but should succeed (lazy over lazy) | |||
| override object value // fail | |||
There was a problem hiding this comment.
it's a deprecation now, could add // scalac: -deprecation to the test
| other.isValue && other.hasFlag(STABLE) && !(other.isDeferred || other.isLazy)) { | ||
| overrideErrorWithMemberInfo("concrete non-lazy value cannot be overridden:") | ||
| if (member.isModule && !currentRun.isScala3) | ||
| runReporting.deprecationWarning(member.pos, member, member.owner, "overriding concrete non-lazy value with an object member will be disallowed under -Xsource:3", "2.13.11") |
There was a problem hiding this comment.
Hmm, it seems this comes too early now and prevents override checking for compatible types:
scala> class A { val value = 0 }
class A
scala> object O extends A { override object value }
^
warning: overriding concrete non-lazy value with an object member will be disallowed under -Xsource:3
object O
scala> (O: A).value
java.lang.ClassCastException: class O$value$ cannot be cast to class java.lang.Integer (O$value$ is in unnamed module of loader scala.tools.nsc.interpreter.IMain$TranslatingClassLoader @475646d4; java.lang.Integer is in module java.base of loader 'bootstrap')
There was a problem hiding this comment.
Sorry, I mean to revisit. I think I said I'd break the if-else.
som-snytt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#5187