[WIP] Enforce stable id patterns conform under Xsource:3 #10290
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stable identifier pattern has always required, per spec, that the type of the pattern conform to the scrutinee. Although matching is determined by universal equals, it is intended that the pattern case narrow the broader expected type. Extraction of values of arbitrary type is provided by extractor patterns. Relatedly, literal pattern must also conform, and literal pattern must be typed with the expected type. Co-authored-by: Jason Zaugg <[email protected]>
|
Ready for review? |
|
@dwijnand Not quite, I'll click it when I get back to it. You know what's ready for review is scala/scala3#16137 |
som-snytt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable identifier pattern has always required, per spec, that the type of the pattern conform to the scrutinee. Although matching is determined by universal equals, it is intended that the pattern case narrow the broader expected type. Extraction of values of arbitrary type is provided by extractor patterns.
Relatedly, literal pattern must also conform,
and literal pattern must be typed with the expected type.
Fixes scala/bug#7211
Fixes scala/bug#7655
Fixes scala/bug#12722
uses #2742