Skip to content
This repository was archived by the owner on Feb 23, 2018. It is now read-only.

Commit d60ca79

Browse files
committed
Clarifications to src/asm/README
1 parent a23565b commit d60ca79

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

README

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,16 @@ Git SVN repo: https://github.com/lrytz/asm
66
Upgrading ASM
77
-------------
88

9+
Check the commit history of src/asm: https://github.com/scala/scala/commits/2.11.x/src/asm.
10+
Find the previous commit that upgraded ASM and take a look at its commit message. It should
11+
be a squashed version of a pull request that shows the precise procedure how the last upgrade
12+
was made.
13+
914
Start by deleting all source files in src/asm/ and copy the ones from the latest ASM release.
1015

1116
Excluded Files (don't copy):
1217
- package.html files
13-
- org/objectweb/asm/commons
18+
- org/objectweb/asm/commons, but keep CodeSizeEvaluator.java
1419
- org/objectweb/asm/optimizer
1520
- org/objectweb/asm/xml
1621

@@ -27,4 +32,6 @@ Re-packaging and cosmetic changes:
2732
- remove trailing whitespace
2833
find src/asm/scala/tools/asm -name '*.java' | xargs sed -i '' -e 's/[ ]*$//'
2934

30-
Actual changes: check the git log for [asm-cherry-pick] after the previous upgrade.
35+
Include the actual changes that we have in our repostiory
36+
- Include the commits labelled [asm-cherry-pick] in the non-squashed PR of the previous upgrade
37+
- Include the changes that were added to src/asm since the last upgrade and label them [asm-cherry-pick]

0 commit comments

Comments
 (0)