Skip to content

Commit 50cdb1e

Browse files
committed
Address review
1 parent 09a6b77 commit 50cdb1e

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

compiler/src/dotty/tools/dotc/tastyreflect/KernelImpl.scala

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1427,10 +1427,6 @@ class KernelImpl(val rootContext: core.Contexts.Context, val rootPosition: util.
14271427
def Symbol_isAbstractType(self: Symbol)(implicit ctx: Context): Boolean = self.isAbstractType
14281428
def Symbol_isClassConstructor(self: Symbol)(implicit ctx: Context): Boolean = self.isClassConstructor
14291429

1430-
def Symbol_isType(self: Symbol)(implicit ctx: Context): Boolean = self.isType
1431-
1432-
def Symbol_isTerm(self: Symbol)(implicit ctx: Context): Boolean = self.isTerm
1433-
14341430
type PackageDefSymbol = core.Symbols.Symbol
14351431

14361432
def matchPackageDefSymbol(symbol: Symbol)(implicit ctx: Context): Option[PackageDefSymbol] =

library/src/scala/tasty/reflect/Kernel.scala

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1169,10 +1169,6 @@ trait Kernel {
11691169

11701170
def Symbol_isDefinedInCurrentRun(self: Symbol)(implicit ctx: Context): Boolean
11711171

1172-
def Symbol_isType(self: Symbol)(implicit ctx: Context): Boolean
1173-
1174-
def Symbol_isTerm(self: Symbol)(implicit ctx: Context): Boolean
1175-
11761172
/** Symbol of a package definition */
11771173
type PackageDefSymbol <: Symbol
11781174

library/src/scala/tasty/reflect/SymbolOps.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ trait SymbolOps extends Core {
8383
def isAbstractType(implicit ctx: Context): Boolean = kernel.Symbol_isAbstractType(self)
8484
def isClassConstructor(implicit ctx: Context): Boolean = kernel.Symbol_isClassConstructor(self)
8585

86-
def isType(implicit ctx: Context): Boolean = kernel.Symbol_isType(self)
87-
def isTerm(implicit ctx: Context): Boolean = kernel.Symbol_isTerm(self)
86+
def isType(implicit ctx: Context): Boolean = kernel.matchTypeSymbol(self).isDefined
87+
def isTerm(implicit ctx: Context): Boolean = kernel.matchTermSymbol(self).isDefined
8888
}
8989

9090
// PackageSymbol

0 commit comments

Comments
 (0)