Fix #3549: Workaround broken FileZipArchive#LeakyEntry jpath

Author: nicolasstucki

compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala

@@ -13,7 +13,7 @@ import scala.collection.{ mutable, immutable }
 import scala.collection.mutable.{ ListBuffer, ArrayBuffer }
 import scala.annotation.switch
 import typer.Checking.checkNonCyclic
-import io.{AbstractFile, PlainFile}
+import io.{AbstractFile, PlainFile, Path, FileZipArchive, JarArchive}
 import scala.util.control.NonFatal
 
 object ClassfileParser {
@@ -781,11 +781,32 @@ class ClassfileParser(
 
       if (scan(tpnme.TASTYATTR)) {
         val attrLen = in.nextInt
-        if (attrLen == 0) {
-          // A tasty attribute implies the existence of the .tasty file
-          val file = new PlainFile(io.File(classfile.jpath).changeExtension("tasty"))
-          if (file.exists) return unpickleTASTY(new AbstractFileReader(file).nextBytes(file.sizeOption.get))
-          else ctx.error("Could not find " + file)
+        if (attrLen == 0) { // A tasty attribute implies the existence of the .tasty file
+          def readBytes(file: io.Path): Array[Byte] = {
+            val plainFile = new PlainFile(file)
+            if (plainFile.exists) new AbstractFileReader(plainFile).nextBytes(plainFile.sizeOption.get)
+            else {
+              ctx.error("Could not find " + file)
+              Array.empty
+            }
+          }
+          val tastyBytes = classfile match {
+            case entry: FileZipArchive#LeakyEntry =>
+              // Workaround broken java paths in LeakyEntry.
+              // This is only necessary because classfile.jpath is null
+              val jarPath = entry.underlyingSource.get.jpath
+              val jarFile = JarArchive.open(Path(jarPath))
+              try {
+                val tastyPath = jarFile.jpath.resolve(entry.path.dropRight(".class".length) + ".tasty")
+                readBytes(io.File(tastyPath))
+              } finally jarFile.close()
+
+            case _ =>
+              assert(classfile.jpath ne null)
+              readBytes(io.File(classfile.jpath).changeExtension("tasty"))
+          }
+          if (tastyBytes.nonEmpty)
+            return unpickleTASTY(tastyBytes)
         }
         else return unpickleTASTY(in.nextBytes(attrLen))
       }

compiler/src/dotty/tools/io/JarArchive.scala

@@ -16,12 +16,17 @@ object JarArchive {
   /** Create a new jar file. Overwrite if file already exists */
   def create(path: Path): JarArchive = {
     require(path.extension == "jar")
-
     path.delete()
+    open(path, create = true)
+  }
+
+  /** Create a jar file. */
+  def open(path: Path, create: Boolean = false): JarArchive = {
+    require(path.extension == "jar")
 
     // creating a new zip file system by using the JAR URL syntax:
     // https://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/zipfilesystemprovider.html
-    val env = Map("create" -> "true").asJava
+    val env = Map("create" -> create.toString).asJava
     val uri = java.net.URI.create("jar:file:" + path.toAbsolute.path)
     val fs = FileSystems.newFileSystem(uri, env)
 

compiler/src/dotty/tools/io/ZipArchive.scala

@@ -139,7 +139,7 @@ final class FileZipArchive(jpath: JPath) extends ZipArchive(jpath) {
   // on Windows, and leaks memory on all OS (typically by stopping
   // classloaders from being garbage collected). But is slightly
   // faster than LazyEntry.
-  private[this] class LeakyEntry(
+  private[tools] class LeakyEntry(
     zipFile: ZipFile,
     zipEntry: ZipEntry
   ) extends Entry(zipEntry.getName) {

project/scripts/sbtTests

@@ -30,7 +30,7 @@ fi
 
 # check that `sbt dotc -decompile` runs
 echo "testing sbt dotc -decompile"
-./project/scripts/sbt ";dotc -decompile -code -color:never -classpath out/scriptedtest1 dotrtest.Test" >  sbtdotc3.out
+./project/scripts/sbt ";dotc -decompile -color:never -classpath out/scriptedtest1 dotrtest.Test" >  sbtdotc3.out
 cat sbtdotc3.out
 if grep -e "def main(args: Array\[String\]): Unit =" sbtdotc3.out; then
     echo "output ok"
@@ -39,11 +39,20 @@ else
     exit -1
 fi
 echo "testing sbt dotr with no -classpath"
-
 ./project/scripts/sbt ";dotc tests/pos/sbtDotrTest.scala; dotr dotrtest.Test" > sbtdotr3.out
 cat sbtdotr3.out
 if grep -e "dotr test ok" sbtdotr3.out; then
     echo "output ok"
 else
     exit -1
 fi
+
+echo "testing loading tasty from .tasty file in jar"
+./project/scripts/sbt ";dotc -d out/scriptedtest4.jar -YemitTasty tests/pos/sbtDotrTest.scala; dotc -decompile -classpath out/scriptedtest4.jar -color:never dotrtest.Test" > sbtdot4.out
+cat sbtdot4.out
+if grep -e "def main(args: Array\[String\]): Unit =" sbtdot4.out; then
+    echo "output ok"
+else
+    echo "failed output check"
+    exit -1
+fi