Skip to content

Commit d09e4ff

Browse files
committed
Improve MiMa failure error message
Now it tells which filer list is related to this test
1 parent 2655768 commit d09e4ff

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

project/Build.scala

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,8 @@ object Build {
531531
settings(commonMiMaSettings).
532532
settings(
533533
versionScheme := Some("semver-spec"),
534-
mimaBinaryIssueFilters ++= MiMaFilters.Interfaces
534+
mimaBinaryIssueFilters ++= MiMaFilters.Interfaces,
535+
customMimaReportBinaryIssues("MiMaFilters.Interfaces"),
535536
)
536537

537538
/** Find an artifact with the given `name` in `classpath` */
@@ -1117,6 +1118,7 @@ object Build {
11171118
mimaCheckDirection := "both",
11181119
mimaBackwardIssueFilters := MiMaFilters.StdlibBootstrappedBackwards,
11191120
mimaForwardIssueFilters := MiMaFilters.StdlibBootstrappedForward,
1121+
customMimaReportBinaryIssues("MiMaFilters.{StdlibBootstrappedForward, StdlibBootstrappedBackwards}"),
11201122
mimaPreviousArtifacts += "org.scala-lang" % "scala-library" % stdlibBootstrappedVersion,
11211123
mimaExcludeAnnotations ++= Seq(
11221124
"scala.annotation.experimental",
@@ -2102,6 +2104,15 @@ object Build {
21022104
packResourceDir += (baseDirectory.value / "bin" -> "bin"),
21032105
)
21042106

2107+
private def customMimaReportBinaryIssues(issueFilterLocation: String) = mimaReportBinaryIssues := {
2108+
mimaReportBinaryIssues.result.value match {
2109+
case Inc(inc: Incomplete) =>
2110+
streams.value.log.error(s"\n$issueFilterLocation are used as filters\n ")
2111+
throw inc
2112+
case Value(v) => v
2113+
}
2114+
}
2115+
21052116
implicit class ProjectDefinitions(val project: Project) extends AnyVal {
21062117

21072118
// FIXME: we do not aggregate `bin` because its tests delete jars, thus breaking other tests
@@ -2168,6 +2179,7 @@ object Build {
21682179
},
21692180
mimaBackwardIssueFilters := MiMaFilters.LibraryBackwards,
21702181
mimaForwardIssueFilters := MiMaFilters.LibraryForward,
2182+
customMimaReportBinaryIssues("MiMaFilters.{LibraryForward, LibraryBackwards}"),
21712183
)
21722184
} else base
21732185
}
@@ -2182,6 +2194,7 @@ object Build {
21822194
if (mode == Bootstrapped) Def.settings(
21832195
commonMiMaSettings,
21842196
mimaBinaryIssueFilters ++= MiMaFilters.TastyCore,
2197+
customMimaReportBinaryIssues("MiMaFilters.TastyCore"),
21852198
) else {
21862199
Nil
21872200
}

0 commit comments

Comments
 (0)