Warn trivial recursion with module prefix #23278
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As pointed out on the ticket, I'll wait to push the test to avoid the laborious C.I. Also pondering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23277
First, loosen the test for whether to warn for
module.recur(). Thethisassignment has a RHS that is not pure (because of module init) butisStable(and not significant with respect to the warning).Second, avoid emitting such a
thisassignment if the prefix is the enclosing module. The existing code checks for a prefix that isEnclosing.this.Other "aliasing" prefixes are not considered, such as a method with result
this.type, since they could execute arbitrary intended effects.