Skip to content

Commit b8220b9

Browse files
MaskRayMaskRay
committed
[MC] Remove unused bool arguments from createMCObjectStreamer callers
1 parent d69eb7b commit b8220b9

File tree

12 files changed

+19
-37
lines changed

12 files changed

+19
-37
lines changed

‎clang/tools/driver/cc1as_main.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -571,9 +571,7 @@ static bool ExecuteAssemblerImpl(AssemblerInvocation &Opts,
571571

572572
Triple T(Opts.Triple);
573573
Str.reset(TheTarget->createMCObjectStreamer(
574-
T, Ctx, std::move(MAB), std::move(OW), std::move(CE), *STI,
575-
Opts.RelaxAll, Opts.IncrementalLinkerCompatible,
576-
/*DWARFMustBeAtTheEnd*/ true));
574+
T, Ctx, std::move(MAB), std::move(OW), std::move(CE), *STI));
577575
Str.get()->initSections(Opts.NoExecStack, *STI);
578576
}
579577

‎llvm/lib/CodeGen/LLVMTargetMachine.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,7 @@ Expected<std::unique_ptr<MCStreamer>> LLVMTargetMachine::createMCStreamer(
208208
T, Context, std::unique_ptr<MCAsmBackend>(MAB),
209209
DwoOut ? MAB->createDwoObjectWriter(Out, *DwoOut)
210210
: MAB->createObjectWriter(Out),
211-
std::unique_ptr<MCCodeEmitter>(MCE), STI, /*ignore=*/false, false,
212-
false));
211+
std::unique_ptr<MCCodeEmitter>(MCE), STI));
213212
break;
214213
}
215214
case CodeGenFileType::Null:
@@ -275,15 +274,15 @@ bool LLVMTargetMachine::addPassesToEmitMC(PassManagerBase &PM, MCContext *&Ctx,
275274
const MCRegisterInfo &MRI = *getMCRegisterInfo();
276275
std::unique_ptr<MCCodeEmitter> MCE(
277276
getTarget().createMCCodeEmitter(*getMCInstrInfo(), *Ctx));
278-
std::unique_ptr<MCAsmBackend> MAB(
279-
getTarget().createMCAsmBackend(STI, MRI, Options.MCOptions));
277+
MCAsmBackend *MAB =
278+
getTarget().createMCAsmBackend(STI, MRI, Options.MCOptions);
280279
if (!MCE || !MAB)
281280
return true;
282281

283282
const Triple &T = getTargetTriple();
284283
std::unique_ptr<MCStreamer> AsmStreamer(getTarget().createMCObjectStreamer(
285-
T, *Ctx, std::move(MAB), MAB->createObjectWriter(Out), std::move(MCE),
286-
STI, /*ignore=*/false, false, false));
284+
T, *Ctx, std::unique_ptr<MCAsmBackend>(MAB), MAB->createObjectWriter(Out),
285+
std::move(MCE), STI));
287286

288287
// Create the AsmPrinter, which takes ownership of AsmStreamer if successful.
289288
FunctionPass *Printer =

‎llvm/lib/DWARFLinker/Classic/DWARFStreamer.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,7 @@ Error DwarfStreamer::init(Triple TheTriple,
110110
MS = TheTarget->createMCObjectStreamer(
111111
TheTriple, *MC, std::unique_ptr<MCAsmBackend>(MAB),
112112
MAB->createObjectWriter(OutFile), std::unique_ptr<MCCodeEmitter>(MCE),
113-
*MSTI, MCOptions.MCRelaxAll, MCOptions.MCIncrementalLinkerCompatible,
114-
/*DWARFMustBeAtTheEnd*/ false);
113+
*MSTI);
115114
break;
116115
}
117116
}

‎llvm/lib/DWARFLinker/Parallel/DWARFEmitterImpl.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ Error DwarfEmitterImpl::init(Triple TheTriple,
8989
MS = TheTarget->createMCObjectStreamer(
9090
TheTriple, *MC, std::unique_ptr<MCAsmBackend>(MAB),
9191
MAB->createObjectWriter(OutFile), std::unique_ptr<MCCodeEmitter>(MCE),
92-
*MSTI, MCOptions.MCRelaxAll, MCOptions.MCIncrementalLinkerCompatible,
93-
/*DWARFMustBeAtTheEnd*/ false);
92+
*MSTI);
9493
break;
9594
}
9695
}

‎llvm/tools/llvm-dwp/llvm-dwp.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,8 @@ int llvm_dwp_main(int argc, char **argv, const llvm::ToolContext &) {
266266

267267
std::unique_ptr<MCStreamer> MS(TheTarget->createMCObjectStreamer(
268268
*ErrOrTriple, MC, std::unique_ptr<MCAsmBackend>(MAB),
269-
MAB->createObjectWriter(*OS), std::unique_ptr<MCCodeEmitter>(MCE), *MSTI,
270-
MCOptions.MCRelaxAll, MCOptions.MCIncrementalLinkerCompatible,
271-
/*DWARFMustBeAtTheEnd*/ false));
269+
MAB->createObjectWriter(*OS), std::unique_ptr<MCCodeEmitter>(MCE),
270+
*MSTI));
272271
if (!MS)
273272
return error("no object streamer for target " + TripleName, Context);
274273

‎llvm/tools/llvm-mc-assemble-fuzzer/llvm-mc-assemble-fuzzer.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,9 +233,8 @@ int AssembleOneInput(const uint8_t *Data, size_t Size) {
233233
MCAsmBackend *MAB = TheTarget->createMCAsmBackend(*STI, *MRI, MCOptions);
234234
Str.reset(TheTarget->createMCObjectStreamer(
235235
TheTriple, Ctx, std::unique_ptr<MCAsmBackend>(MAB),
236-
MAB->createObjectWriter(*OS), std::unique_ptr<MCCodeEmitter>(CE), *STI,
237-
MCOptions.MCRelaxAll, MCOptions.MCIncrementalLinkerCompatible,
238-
/*DWARFMustBeAtTheEnd*/ false));
236+
MAB->createObjectWriter(*OS), std::unique_ptr<MCCodeEmitter>(CE),
237+
*STI));
239238
}
240239
const int Res = AssembleInput(ProgName, TheTarget, SrcMgr, Ctx, *Str, *MAI, *STI,
241240
*MCII, MCOptions);

‎llvm/tools/llvm-mc/llvm-mc.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -555,9 +555,7 @@ int main(int argc, char **argv) {
555555
TheTriple, Ctx, std::unique_ptr<MCAsmBackend>(MAB),
556556
DwoOut ? MAB->createDwoObjectWriter(*OS, DwoOut->os())
557557
: MAB->createObjectWriter(*OS),
558-
std::unique_ptr<MCCodeEmitter>(CE), *STI, MCOptions.MCRelaxAll,
559-
MCOptions.MCIncrementalLinkerCompatible,
560-
/*DWARFMustBeAtTheEnd*/ false));
558+
std::unique_ptr<MCCodeEmitter>(CE), *STI));
561559
if (NoExecStack)
562560
Str->initSections(true, *STI);
563561
}

‎llvm/tools/llvm-ml/llvm-ml.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -402,9 +402,8 @@ int llvm_ml_main(int Argc, char **Argv, const llvm::ToolContext &) {
402402
MCAsmBackend *MAB = TheTarget->createMCAsmBackend(*STI, *MRI, MCOptions);
403403
Str.reset(TheTarget->createMCObjectStreamer(
404404
TheTriple, Ctx, std::unique_ptr<MCAsmBackend>(MAB),
405-
MAB->createObjectWriter(*OS), std::unique_ptr<MCCodeEmitter>(CE), *STI,
406-
MCOptions.MCRelaxAll, MCOptions.MCIncrementalLinkerCompatible,
407-
/*DWARFMustBeAtTheEnd*/ false));
405+
MAB->createObjectWriter(*OS), std::unique_ptr<MCCodeEmitter>(CE),
406+
*STI));
408407
} else {
409408
llvm_unreachable("Invalid file type!");
410409
}

‎llvm/unittests/DebugInfo/DWARF/DWARFExpressionCopyBytesTest.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,10 +112,7 @@ DWARFExpressionCopyBytesTest::createStreamer(raw_pwrite_stream &OS) {
112112
std::unique_ptr<MCObjectWriter> OW = MAB->createObjectWriter(OS);
113113
Res.Streamer.reset(TheTarget->createMCObjectStreamer(
114114
Triple(TripleName), *Res.Ctx, std::unique_ptr<MCAsmBackend>(MAB),
115-
std::move(OW), std::unique_ptr<MCCodeEmitter>(MCE), *STI,
116-
/* RelaxAll */ false,
117-
/* IncrementalLinkerCompatible */ false,
118-
/* DWARFMustBeAtTheEnd */ false));
115+
std::move(OW), std::unique_ptr<MCCodeEmitter>(MCE), *STI));
119116
return Res;
120117
}
121118

‎llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -503,8 +503,7 @@ llvm::Error dwarfgen::Generator::init(Triple TheTriple, uint16_t V) {
503503
MS = TheTarget->createMCObjectStreamer(
504504
TheTriple, *MC, std::unique_ptr<MCAsmBackend>(MAB),
505505
MAB->createObjectWriter(*Stream), std::unique_ptr<MCCodeEmitter>(MCE),
506-
*MSTI, MCOptions.MCRelaxAll, MCOptions.MCIncrementalLinkerCompatible,
507-
/*DWARFMustBeAtTheEnd*/ false);
506+
*MSTI);
508507
if (!MS)
509508
return make_error<StringError>("no object streamer for target " +
510509
TripleName,

‎llvm/unittests/MC/DwarfLineTableHeaders.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,7 @@ class DwarfLineTableHeaders : public ::testing::Test {
8383
std::unique_ptr<MCObjectWriter> OW = MAB->createObjectWriter(OS);
8484
Res.Streamer.reset(TheTarget->createMCObjectStreamer(
8585
Triple(TripleName), *Res.Ctx, std::unique_ptr<MCAsmBackend>(MAB),
86-
std::move(OW), std::unique_ptr<MCCodeEmitter>(MCE), *STI,
87-
/* RelaxAll */ false,
88-
/* IncrementalLinkerCompatible */ false,
89-
/* DWARFMustBeAtTheEnd */ false));
86+
std::move(OW), std::unique_ptr<MCCodeEmitter>(MCE), *STI));
9087
return Res;
9188
}
9289

‎mlir/lib/Target/LLVM/ROCDL/Target.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -324,8 +324,7 @@ SerializeGPUModuleBase::assembleIsa(StringRef isa) {
324324
mcStreamer.reset(target->createMCObjectStreamer(
325325
triple, ctx, std::unique_ptr<llvm::MCAsmBackend>(mab),
326326
mab->createObjectWriter(os), std::unique_ptr<llvm::MCCodeEmitter>(ce),
327-
*sti, mcOptions.MCRelaxAll, mcOptions.MCIncrementalLinkerCompatible,
328-
/*DWARFMustBeAtTheEnd*/ false));
327+
*sti));
329328

330329
std::unique_ptr<llvm::MCAsmParser> parser(
331330
createMCAsmParser(srcMgr, ctx, *mcStreamer, *mai));

0 commit comments

Comments
 (0)