Skip to content

Commit e4e732d

Browse files
Closes #6087
1 parent 3449010 commit e4e732d

File tree

5 files changed

+30
-0
lines changed

5 files changed

+30
-0
lines changed

ChangeLog-10.5.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ All notable changes of the PHPUnit 10.5 release series are documented in this fi
77
### Fixed
88

99
* [#6082](https://github.com/sebastianbergmann/phpunit/issues/6082): `assertArrayHasKey()`, `assertArrayNotHasKey()`, `arrayHasKey()`, and `ArrayHasKey::__construct()` do not support all possible key types
10+
* [#6087](https://github.com/sebastianbergmann/phpunit/issues/6087): `--migrate-configuration` does not remove `beStrictAboutTodoAnnotatedTests` attribute from XML configuration file
1011

1112
## [10.5.39] - 2024-12-11
1213

src/TextUI/Configuration/Xml/Migration/MigrationBuilder.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ final class MigrationBuilder
6363
'10.0' => [
6464
MoveCoverageDirectoriesToSource::class,
6565
],
66+
67+
'10.4' => [
68+
RemoveBeStrictAboutTodoAnnotatedTestsAttribute::class,
69+
],
6670
];
6771

6872
public function build(string $fromVersion): array
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.4/phpunit.xsd"
4+
beStrictAboutTodoAnnotatedTests="true"
5+
>
6+
<testsuites>
7+
<testsuite name="default">
8+
<directory>tests</directory>
9+
</testsuite>
10+
</testsuites>
11+
</phpunit>
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd"
4+
>
5+
<testsuites>
6+
<testsuite name="default">
7+
<directory>tests</directory>
8+
</testsuite>
9+
</testsuites>
10+
</phpunit>

tests/unit/TextUI/Configuration/Xml/MigratorTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,10 @@ public static function provider(): array
2626
__DIR__ . '/../../../../_files/XmlConfigurationMigration/output-9.5.xml',
2727
__DIR__ . '/../../../../_files/XmlConfigurationMigration/input-9.5.xml',
2828
],
29+
'Issue 6087' => [
30+
__DIR__ . '/../../../../_files/XmlConfigurationMigration/output-issue-6087.xml',
31+
__DIR__ . '/../../../../_files/XmlConfigurationMigration/input-issue-6087.xml',
32+
],
2933
];
3034
}
3135

0 commit comments

Comments
 (0)