Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Commit 31b673a

Browse files
committed
adds test and override for calling page with just name
1 parent 7754d3c commit 31b673a

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

lib/index.d.ts

+7
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,13 @@ export declare namespace SegmentAnalytics {
277277
callback: PageCallback,
278278
): AnalyticsJS;
279279

280+
/**
281+
* Trigger a pageview.
282+
*/
283+
page(
284+
name: string,
285+
): AnalyticsJS;
286+
280287
/**
281288
* Trigger a pageview.
282289
*/

test/analytics.test.js

+12
Original file line numberDiff line numberDiff line change
@@ -730,6 +730,18 @@ describe('Analytics', function() {
730730
});
731731
});
732732

733+
it('should accept (name)', function() {
734+
defaults.name = 'name';
735+
Test.prototype.page = sinon.spy();
736+
var test = new Test();
737+
test.invoke = sinon.spy();
738+
analytics.use(Test);
739+
analytics.add(test);
740+
analytics.initialize();
741+
analytics.page('Test Page Event');
742+
assert(test.invoke.called);
743+
});
744+
733745
it('should accept (properties, options, callback)', function(done) {
734746
analytics.page({}, {}, function() {
735747
var page = analytics._invoke.args[0][1];

0 commit comments

Comments
 (0)