Skip to content

Commit 1fdda44

Browse files
author
kukoo
committed
edit comment: @deprecated 'name' property
1 parent cdd95b7 commit 1fdda44

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

lib/interfaces/ISequelizeDbNameConfig.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import {Options} from 'sequelize';
22

33
/**
4-
* This class is for deprecated "name" property.
4+
* This class is dedicated for deprecated "name" property.
55
* For congruence to Sequelize config, use "database" instead.
66
*/
77
export interface ISequelizeDbNameConfig extends Options {
88

99
/**
1010
* Name of database
11-
* @TODO: name is deprecated. Use database instead.
11+
* @deprecated: name is deprecated. Use database instead.
1212
*/
1313
name: string;
1414

lib/models/BaseSequelize.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,8 @@ export abstract class BaseSequelize {
5050
}
5151

5252
if (BaseSequelize.isISequelizeDbNameConfig(config)) {
53-
// @TODO: deprecate "name" property, use "database" instead
54-
const database = config.name;
55-
return {...config, database} as ISequelizeConfig;
53+
// @TODO: remove deprecated "name" property
54+
return {...config, database: config.name} as ISequelizeConfig;
5655
}
5756

5857
return {...config as SequelizeConfig};

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@
3030
"main": "index.js",
3131
"types": "index.d.ts",
3232
"dependencies": {
33+
"@types/bluebird": "3.5.4",
3334
"@types/node": "6.0.41",
3435
"@types/reflect-metadata": "0.0.4",
3536
"@types/sequelize": "4.0.69",
3637
"es6-shim": "0.35.3"
3738
},
3839
"devDependencies": {
39-
"@types/bluebird": "3.5.4",
4040
"@types/chai": "3.4.35",
4141
"@types/chai-as-promised": "0.0.29",
4242
"@types/chai-datetime": "0.0.30",

test/specs/models/sequelize.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ describe('sequelize', () => {
7373
it('should contain additional Sequelize options', () => {
7474
expect(sequelizeUri)
7575
.to.have.property('options')
76-
.to.have.property('pool')
76+
.that.have.property('pool')
7777
.that.have.property('max')
7878
.that.eqls(8);
7979
});

0 commit comments

Comments
 (0)