Skip to content

Commit 58c82f1

Browse files
committed
Command-line ignore let_underscore_drop clippy lint
For whatever reason, the #![cfg_attr(feature = "cargo-clippy", allow(let_underscore_drop))] attributes already in the code stopped working in the most recent nightly (2022-09-03). Likely in connection with rust-lang/rust#97739 ? error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:958:13 | 958 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = note: `-D clippy::let-underscore-drop` implied by `-D clippy::pedantic` = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:992:13 | 992 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:1616:9 | 1616 | let _ = deserializer; | ^^^^^^^^^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:1640:9 | 1640 | let _ = deserializer; | ^^^^^^^^^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:1651:9 | 1651 | let _ = seq; | ^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:1662:9 | 1662 | let _ = map; | ^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/de/mod.rs:1673:9 | 1673 | let _ = data; | ^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/private/de.rs:1440:13 | 1440 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop error: non-binding `let` on a type that implements `Drop` --> serde/src/private/de.rs:2163:13 | 2163 | let _ = visitor; | ^^^^^^^^^^^^^^^^ | = help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
1 parent 5386897 commit 58c82f1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,10 +167,10 @@ jobs:
167167
steps:
168168
- uses: actions/checkout@v3
169169
- uses: dtolnay/rust-toolchain@clippy
170-
- run: cd serde && cargo clippy --features rc,unstable -- -Dclippy::all -Dclippy::pedantic
170+
- run: cd serde && cargo clippy --features rc,unstable -- -Dclippy::all -Dclippy::pedantic -Aclippy::let_underscore_drop
171171
- run: cd serde_derive && cargo clippy -- -Dclippy::all -Dclippy::pedantic
172172
- run: cd serde_derive_internals && cargo clippy -- -Dclippy::all -Dclippy::pedantic
173-
- run: cd serde_test && cargo clippy -- -Dclippy::all -Dclippy::pedantic
173+
- run: cd serde_test && cargo clippy -- -Dclippy::all -Dclippy::pedantic -Aclippy::let_underscore_drop
174174
- run: cd test_suite && cargo clippy --tests --features unstable -- -Dclippy::all -Dclippy::pedantic
175175
- run: cd test_suite/no_std && cargo clippy -- -Dclippy::all -Dclippy::pedantic
176176

0 commit comments

Comments
 (0)