Optimize IsClosure()

SergeiPavlov · SergeiPavlov · commit 9e81bcfbfb19 · 2025-04-23T15:39:27.000-07:00
diff --git a/Orm/Xtensive.Orm/Reflection/TypeHelper.cs b/Orm/Xtensive.Orm/Reflection/TypeHelper.cs
@@ -1188,9 +1188,11 @@ public static bool IsAnonymous(this Type type)
     /// </returns>
     public static bool IsClosure(this Type type)
     {
+      if (type.BaseType != WellKnownTypes.Object) {
+        return false;
+      }
       var typeName = type.Name;
-      return type.BaseType == WellKnownTypes.Object
-        && (typeName.StartsWith("<>", StringComparison.Ordinal) || typeName.StartsWith("VB$", StringComparison.Ordinal))
+      return (typeName.StartsWith("<>", StringComparison.Ordinal) || typeName.StartsWith("VB$", StringComparison.Ordinal))
         && typeName.IndexOf("DisplayClass", StringComparison.Ordinal) >= 0
         && type.IsDefined(CompilerGeneratedAttributeType, false);
     }

Original file line number	Diff line number	Diff line change
`@@ -1188,9 +1188,11 @@ public static bool IsAnonymous(this Type type)`
`1188`	`1188`	`/// </returns>`
`1189`	`1189`	`public static bool IsClosure(this Type type)`
`1190`	`1190`	`{`
	`1191`	`+ if (type.BaseType != WellKnownTypes.Object) {`
	`1192`	`+ return false;`
	`1193`	`+ }`
`1191`	`1194`	`var typeName = type.Name;`
`1192`		`- return type.BaseType == WellKnownTypes.Object`
`1193`		`- && (typeName.StartsWith("<>", StringComparison.Ordinal) \|\| typeName.StartsWith("VB$", StringComparison.Ordinal))`
	`1195`	`+ return (typeName.StartsWith("<>", StringComparison.Ordinal) \|\| typeName.StartsWith("VB$", StringComparison.Ordinal))`
`1194`	`1196`	`&& typeName.IndexOf("DisplayClass", StringComparison.Ordinal) >= 0`
`1195`	`1197`	`&& type.IsDefined(CompilerGeneratedAttributeType, false);`
`1196`	`1198`	`}`