Optimization: Mark some internal classes as sealed to help optimizer (#220)

* Optimization: Mark Visitor classes as `sealed` to help optimizer

* Continue

* Continue

Author: SergeiPavlov

Orm/Xtensive.Orm/Comparison/Internals/ValueTypeComparer.cs

@@ -65,4 +65,4 @@ public override void OnDeserialization(object sender)
       Initialize();
     }
   }
-}
+}

Orm/Xtensive.Orm/Conversion/Internals/BooleanAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class BooleanAdvancedConverter :
+  internal sealed class BooleanAdvancedConverter :
     StrictAdvancedConverterBase<bool>,
     IAdvancedConverter<bool, byte>,
     IAdvancedConverter<bool, sbyte>,

Orm/Xtensive.Orm/Conversion/Internals/ByteAdvancedConverter.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class ByteAdvancedConverter :
+  internal sealed class ByteAdvancedConverter :
     StrictAdvancedConverterBase<byte>,
     IAdvancedConverter<byte, sbyte>,
     IAdvancedConverter<byte, short>,

Orm/Xtensive.Orm/Conversion/Internals/ByteRoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class ByteRoughAdvancedConverter :
+  internal sealed class ByteRoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<byte, bool>
   {

Orm/Xtensive.Orm/Conversion/Internals/CharAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class CharAdvancedConverter :
+  internal sealed class CharAdvancedConverter :
     StrictAdvancedConverterBase<char>,
     IAdvancedConverter<char, byte>,
     IAdvancedConverter<char, sbyte>,

Orm/Xtensive.Orm/Conversion/Internals/ConvertingEnumerator.cs

@@ -12,7 +12,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class ConvertingEnumerator<T1, T2> : IEnumerator<T2>
+  internal sealed class ConvertingEnumerator<T1, T2> : IEnumerator<T2>
   {
     private IEnumerator<T1> innerEnumerator;
     private readonly Converter<T1, T2> converter;

Orm/Xtensive.Orm/Conversion/Internals/DateTimeAdvancedConverter.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class DateTimeAdvancedConverter :
+  internal sealed class DateTimeAdvancedConverter :
     StrictAdvancedConverterBase<DateTime>,
     IAdvancedConverter<DateTime, byte>,
     IAdvancedConverter<DateTime, sbyte>,

Orm/Xtensive.Orm/Conversion/Internals/DateTimeRoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class DateTimeRoughAdvancedConverter :
+  internal sealed class DateTimeRoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<DateTime, float>,
     IAdvancedConverter<DateTime, double>

Orm/Xtensive.Orm/Conversion/Internals/DecimalAdvancedConverter.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class DecimalAdvancedConverter :
+  internal sealed class DecimalAdvancedConverter :
     StrictAdvancedConverterBase<decimal>,
     IAdvancedConverter<decimal, string>
   {

Orm/Xtensive.Orm/Conversion/Internals/DecimalRoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class DecimalRoughAdvancedConverter :
+  internal sealed class DecimalRoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<decimal, bool>,
     IAdvancedConverter<decimal, byte>,

Orm/Xtensive.Orm/Conversion/Internals/DoubleAdvancedConverter.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class DoubleAdvancedConverter :
+  internal sealed class DoubleAdvancedConverter :
     StrictAdvancedConverterBase<double>,
     IAdvancedConverter<double, string>
   {

Orm/Xtensive.Orm/Conversion/Internals/DoubleRoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class DoubleRoughAdvancedConverter :
+  internal sealed class DoubleRoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<double, bool>,
     IAdvancedConverter<double, byte>,

Orm/Xtensive.Orm/Conversion/Internals/EnumAdvancedConverterFactory.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class EnumAdvancedConverterFactory<TFrom> : IAdvancedConverterFactory<TFrom>
+  internal sealed class EnumAdvancedConverterFactory<TFrom> : IAdvancedConverterFactory<TFrom>
   {
     private readonly IAdvancedConverterProvider provider;
 

Orm/Xtensive.Orm/Conversion/Internals/EnumAdvancedConverter{TFrom, TTo, TUnderlyingFrom, TUnderlyingTo}.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class EnumAdvancedConverter<TFrom, TTo, TUnderlyingFrom, TUnderlyingTo> : AdvancedConverterBase, 
+  internal sealed class EnumAdvancedConverter<TFrom, TTo, TUnderlyingFrom, TUnderlyingTo> : AdvancedConverterBase,
     IAdvancedConverter<TFrom, TTo>
     where TFrom : struct
     where TTo : struct

Orm/Xtensive.Orm/Conversion/Internals/EnumAdvancedConverter{TFrom, TTo}.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class EnumAdvancedConverter<TFrom, TTo> : AdvancedConverterBase, 
+  internal class EnumAdvancedConverter<TFrom, TTo> : AdvancedConverterBase,
     IAdvancedConverter<TFrom, TTo>
     where TFrom : struct
     where TTo : struct

Orm/Xtensive.Orm/Conversion/Internals/GuidAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class GuidAdvancedConverter :
+  internal sealed class GuidAdvancedConverter :
     StrictAdvancedConverterBase<Guid>,
     IAdvancedConverter<Guid, string>
   {

Orm/Xtensive.Orm/Conversion/Internals/Int16AdvancedConverter.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class Int16AdvancedConverter :
+  internal sealed class Int16AdvancedConverter :
     StrictAdvancedConverterBase<short>,
     IAdvancedConverter<short, byte>,
     IAdvancedConverter<short, sbyte>,

Orm/Xtensive.Orm/Conversion/Internals/Int16RoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class Int16RoughAdvancedConverter :
+  internal sealed class Int16RoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<short, bool>
   {

Orm/Xtensive.Orm/Conversion/Internals/Int32AdvancedConverter.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class Int32AdvancedConverter :
+  internal sealed class Int32AdvancedConverter :
     StrictAdvancedConverterBase<int>,
     IAdvancedConverter<int, byte>,
     IAdvancedConverter<int, sbyte>,

Orm/Xtensive.Orm/Conversion/Internals/Int32RoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class Int32RoughAdvancedConverter :
+  internal sealed class Int32RoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<int, bool>,
     IAdvancedConverter<int, float>

Orm/Xtensive.Orm/Conversion/Internals/Int64AdvancedConverter.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class Int64AdvancedConverter :
+  internal sealed class Int64AdvancedConverter :
     StrictAdvancedConverterBase<long>,
     IAdvancedConverter<long, byte>,
     IAdvancedConverter<long, sbyte>,

Orm/Xtensive.Orm/Conversion/Internals/Int64RoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class Int64RoughAdvancedConverter:
+  internal sealed class Int64RoughAdvancedConverter:
     RoughAdvancedConverterBase,
     IAdvancedConverter<long, bool>,
     IAdvancedConverter<long, float>,

Orm/Xtensive.Orm/Conversion/Internals/NullableAdvancedConverterFactory.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class NullableAdvancedConverterFactory<TFrom> : IAdvancedConverterFactory<TFrom>
+  internal sealed class NullableAdvancedConverterFactory<TFrom> : IAdvancedConverterFactory<TFrom>
   {
     private IAdvancedConverterProvider provider;
 

Orm/Xtensive.Orm/Conversion/Internals/NullableForwardAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class NullableForwardAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom?, TFrom, TTo, TTo>
+  internal sealed class NullableForwardAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom?, TFrom, TTo, TTo>
     where TFrom : struct
   {
     private static readonly bool toIsValueType = typeof (TTo).IsValueType;

Orm/Xtensive.Orm/Conversion/Internals/NullableNullableAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class NullableNullableAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom?, TFrom, TTo?, TTo>
+  internal sealed class NullableNullableAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom?, TFrom, TTo?, TTo>
     where TFrom : struct
     where TTo : struct
   {

Orm/Xtensive.Orm/Conversion/Internals/NullableReverseAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class NullableReverseAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom, TFrom, TTo?, TTo>
+  internal sealed class NullableReverseAdvancedConverter<TFrom, TTo> : WrappingAdvancedConverter<TFrom, TFrom, TTo?, TTo>
     where TTo : struct
   {
     /// <inheritdoc/>

Orm/Xtensive.Orm/Conversion/Internals/ObjectAdvancedConverterFactory.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class ObjectAdvancedConverterFactory<TFrom> : 
+  internal sealed class ObjectAdvancedConverterFactory<TFrom> :
     IAdvancedConverterFactory<TFrom>
   {
     private readonly IAdvancedConverterProvider provider;

Orm/Xtensive.Orm/Conversion/Internals/ObjectToBaseAdvancedConverter{TFrom, TTo}.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class ObjectToBaseAdvancedConverter<TFrom, TTo> : AdvancedConverterBase, 
+  internal class ObjectToBaseAdvancedConverter<TFrom, TTo> : AdvancedConverterBase,
     IAdvancedConverter<TFrom, TTo>
     where TFrom : TTo
   {

Orm/Xtensive.Orm/Conversion/Internals/SByteRoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class SByteRoughAdvancedConverter :
+  internal sealed class SByteRoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<sbyte, bool>
   {

Orm/Xtensive.Orm/Conversion/Internals/SingleRoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class SingleRoughAdvancedConverter :
+  internal sealed class SingleRoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<float, bool>,
     IAdvancedConverter<float, byte>,

Orm/Xtensive.Orm/Conversion/Internals/StringAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class StringAdvancedConverter :
+  internal sealed class StringAdvancedConverter :
     StrictAdvancedConverterBase<string>
   {
     // Constructors

Orm/Xtensive.Orm/Conversion/Internals/StringRoughAdvancedConverter{T}.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class StringRoughAdvancedConverter<T> :
+  internal sealed class StringRoughAdvancedConverter<T> :
     RoughAdvancedConverterBase,
     IAdvancedConverter<T, string>
   {

Orm/Xtensive.Orm/Conversion/Internals/TimeSpanAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class TimeSpanAdvancedConverter :
+  internal sealed class TimeSpanAdvancedConverter :
     StrictAdvancedConverterBase<TimeSpan>,
     IAdvancedConverter<TimeSpan, byte>,
     IAdvancedConverter<TimeSpan, sbyte>,

Orm/Xtensive.Orm/Conversion/Internals/TimeSpanRoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class TimeSpanRoughAdvancedConverter :
+  internal sealed class TimeSpanRoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<TimeSpan, float>,
     IAdvancedConverter<TimeSpan, double>

Orm/Xtensive.Orm/Conversion/Internals/TypeAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class TypeAdvancedConverter :
+  internal sealed class TypeAdvancedConverter :
     StrictAdvancedConverterBase<Type>,
     IAdvancedConverter<Type, string>,
     IAdvancedConverter<string, Type>

Orm/Xtensive.Orm/Conversion/Internals/UInt16AdvancedConverter.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class UInt16AdvancedConverter :
+  internal sealed class UInt16AdvancedConverter :
     StrictAdvancedConverterBase<ushort>,
     IAdvancedConverter<ushort, byte>,
     IAdvancedConverter<ushort, sbyte>,

Orm/Xtensive.Orm/Conversion/Internals/UInt16RoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class UInt16RoughAdvancedConverter :
+  internal sealed class UInt16RoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<ushort, bool>
   {

Orm/Xtensive.Orm/Conversion/Internals/UInt32AdvancedConverter.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class UInt32AdvancedConverter :
+  internal sealed class UInt32AdvancedConverter :
     StrictAdvancedConverterBase<uint>,
     IAdvancedConverter<uint, byte>,
     IAdvancedConverter<uint, sbyte>,

Orm/Xtensive.Orm/Conversion/Internals/UInt32RoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class UInt32RoughAdvancedConverter :
+  internal sealed class UInt32RoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<uint, bool>,
     IAdvancedConverter<uint, float>

Orm/Xtensive.Orm/Conversion/Internals/UInt64AdvancedConverter.cs

@@ -10,7 +10,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class UInt64AdvancedConverter :
+  internal sealed class UInt64AdvancedConverter :
     StrictAdvancedConverterBase<ulong>,
     IAdvancedConverter<ulong, byte>,
     IAdvancedConverter<ulong, sbyte>,

Orm/Xtensive.Orm/Conversion/Internals/UInt64RoughAdvancedConverter.cs

@@ -9,7 +9,7 @@
 namespace Xtensive.Conversion
 {
   [Serializable]
-  internal class UInt64RoughAdvancedConverter :
+  internal sealed class UInt64RoughAdvancedConverter :
     RoughAdvancedConverterBase,
     IAdvancedConverter<ulong, bool>,
     IAdvancedConverter<ulong, float>,

Orm/Xtensive.Orm/Linq/ExpressionReplacer.cs

@@ -12,7 +12,7 @@ namespace Xtensive.Linq
   /// <summary>
   /// Replaces references to one specific instance of an expression node with another node
   /// </summary>
-  public class ExpressionReplacer : ExpressionVisitor
+  public sealed class ExpressionReplacer : ExpressionVisitor
   {
     private readonly Expression searchFor;
     private readonly Expression replaceWith;

Orm/Xtensive.Orm/Modelling/Validation/ValidationContext.cs

@@ -16,7 +16,7 @@ namespace Xtensive.Modelling.Validation
   /// Model validation context.
   /// </summary>
   [Serializable]
-  internal class ValidationContext : IContext<ValidationScope>
+  internal sealed class ValidationContext : IContext<ValidationScope>
   {
     private readonly HashSet<object> validated = new HashSet<object>();