Skip to content

Commit 65cd50a

Browse files
committed
GH Actions: update for php-coveralls 2.6.0
PHP-Coveralls 2.6.0 has just been released and includes a fix for the last known PHP 8.x issue. This means that it should now be safe to install php-coveralls on PHP 8.x and upload from there, which means we now only need the work-around for the PHP version when on PHP < 5.5 (as Coveralls v1 does not work with GH Actions). Ref: * https://github.com/php-coveralls/php-coveralls/releases/tag/v2.6.0
1 parent dc5582d commit 65cd50a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/test.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -190,18 +190,18 @@ jobs:
190190
if: ${{ steps.phpunit_version.outputs.VERSION >= '9.3' }}
191191
run: composer coverage -- --coverage-cache ./build/phpunit-cache
192192

193-
# PHP Coveralls v2 has a PHP 5.5 minimum and is not yet fully compatible with PHP 8.0+, so switch the PHP version.
194-
- name: Switch to PHP 7.4
195-
if: ${{ success() && matrix.php != '7.4' }}
193+
# PHP Coveralls v2 has a PHP 5.5 minimum, so switch the PHP version.
194+
- name: Switch to PHP latest
195+
if: ${{ success() && matrix.php == '5.4' }}
196196
uses: shivammathur/setup-php@v2
197197
with:
198-
php-version: 7.4
198+
php-version: 'latest'
199199
coverage: none
200200

201-
# Global install is used to prevent a conflict with the local composer.lock in PHP 8.0+.
201+
# Global install is used to prevent a conflict with the local composer.lock.
202202
- name: Install Coveralls
203203
if: ${{ success() }}
204-
run: composer global require php-coveralls/php-coveralls:"^2.5.3" --no-interaction --with-all-dependencies
204+
run: composer global require php-coveralls/php-coveralls:"^2.6.0" --no-interaction --with-all-dependencies
205205

206206
- name: Upload coverage results to Coveralls
207207
if: ${{ success() }}

0 commit comments

Comments
 (0)