Skip to content

Commit 266d633

Browse files
philwebbphilwebb
committed
Fix checkstyle RedundantModifier test violations
1 parent cde4f0d commit 266d633

File tree

41 files changed

+87
-74
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+87
-74
lines changed

‎pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
<propertyExpansion>main.basedir=${main.basedir}</propertyExpansion>
7676
<sourceDirectories>${basedir}</sourceDirectories>
7777
<includes>**/*</includes>
78-
<excludes>.git/**/*,target/**/,**/.flattened-pom.xml</excludes>
78+
<excludes>.git/**/*,target/**/,**/.flattened-pom.xml,**/*.class,**/spring-boot-gradle-plugin/build/**</excludes>
7979
</configuration>
8080
<goals>
8181
<goal>check</goal>

‎spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/condition/ConditionsReportEndpointTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public static class Config {
6363

6464
private final ConfigurableApplicationContext context;
6565

66-
public Config(ConfigurableApplicationContext context) {
66+
Config(ConfigurableApplicationContext context) {
6767
this.context = context;
6868
}
6969

‎spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/context/properties/ConfigurationPropertiesReportEndpointSerializationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ public static class SelfReferential extends Foo {
392392

393393
private Foo self;
394394

395-
public SelfReferential() {
395+
SelfReferential() {
396396
this.self = this;
397397
}
398398

‎spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/context/properties/ConfigurationPropertiesReportEndpointTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ public static class TestProperties {
266266

267267
private Duration duration = Duration.ofSeconds(10);
268268

269-
public TestProperties() {
269+
TestProperties() {
270270
this.secrets.put("mine", "myPrivateThing");
271271
this.secrets.put("yours", "yourPrivateThing");
272272
this.listItems.add(new ListItem());

‎spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/reactive/WebFluxEndpointIntegrationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
class WebFluxEndpointIntegrationTests
5858
extends AbstractWebEndpointIntegrationTests<AnnotationConfigReactiveWebServerApplicationContext> {
5959

60-
public WebFluxEndpointIntegrationTests() {
60+
WebFluxEndpointIntegrationTests() {
6161
super(WebFluxEndpointIntegrationTests::createApplicationContext,
6262
WebFluxEndpointIntegrationTests::applyAuthenticatedConfiguration);
6363

‎spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/endpoint/web/servlet/MvcWebEndpointIntegrationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
class MvcWebEndpointIntegrationTests
6868
extends AbstractWebEndpointIntegrationTests<AnnotationConfigServletWebServerApplicationContext> {
6969

70-
public MvcWebEndpointIntegrationTests() {
70+
MvcWebEndpointIntegrationTests() {
7171
super(MvcWebEndpointIntegrationTests::createApplicationContext,
7272
MvcWebEndpointIntegrationTests::applyAuthenticatedConfiguration);
7373
}

‎spring-boot-project/spring-boot-actuator/src/test/java/org/springframework/boot/actuate/mail/MailHealthIndicatorTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ void smtpIsDown() throws MessagingException {
8383

8484
public static class SuccessTransport extends Transport {
8585

86-
public SuccessTransport(Session session, URLName urlName) {
86+
SuccessTransport(Session session, URLName urlName) {
8787
super(session, urlName);
8888
}
8989

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnBeanTests.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ public static class ExampleBean {
477477

478478
private String value;
479479

480-
public ExampleBean(String value) {
480+
ExampleBean(String value) {
481481
this.value = value;
482482
}
483483

@@ -490,15 +490,15 @@ public String toString() {
490490

491491
public static class CustomExampleBean extends ExampleBean {
492492

493-
public CustomExampleBean() {
493+
CustomExampleBean() {
494494
super("custom subclass");
495495
}
496496

497497
}
498498

499499
public static class OtherExampleBean extends ExampleBean {
500500

501-
public OtherExampleBean() {
501+
OtherExampleBean() {
502502
super("other subclass");
503503
}
504504

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jackson/JacksonAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ private void assertParameterNamesModuleCreatorBinding(Mode expectedMode, Class<?
400400

401401
public static class MyDateFormat extends SimpleDateFormat {
402402

403-
public MyDateFormat() {
403+
MyDateFormat() {
404404
super("yyyy-MM-dd HH:mm:ss");
405405
}
406406

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jersey/JerseyAutoConfigurationCustomFilterContextPathTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public String message() {
7777
return "Hello " + this.msg;
7878
}
7979

80-
public Application() {
80+
Application() {
8181
register(Application.class);
8282
}
8383

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jersey/JerseyAutoConfigurationCustomFilterPathTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public String message() {
7676
return "Hello " + this.msg;
7777
}
7878

79-
public Application() {
79+
Application() {
8080
register(Application.class);
8181
}
8282

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jersey/JerseyAutoConfigurationCustomLoadOnStartupTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ void contextLoads() {
5757
@MinimalWebConfiguration
5858
public static class Application extends ResourceConfig {
5959

60-
public Application() {
60+
Application() {
6161
register(Application.class);
6262
}
6363

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jersey/JerseyAutoConfigurationCustomObjectMapperProviderTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public Message message() {
7575
return new Message("Jersey", null);
7676
}
7777

78-
public Application() {
78+
Application() {
7979
register(Application.class);
8080
}
8181

@@ -91,7 +91,7 @@ public static class Message {
9191

9292
private String body;
9393

94-
public Message(String subject, String body) {
94+
Message(String subject, String body) {
9595
this.subject = subject;
9696
this.body = body;
9797
}

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jersey/JerseyAutoConfigurationCustomServletContextPathTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public String message() {
7676
return "Hello " + this.msg;
7777
}
7878

79-
public Application() {
79+
Application() {
8080
register(Application.class);
8181
}
8282

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jersey/JerseyAutoConfigurationCustomServletPathTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public String message() {
7676
return "Hello " + this.msg;
7777
}
7878

79-
public Application() {
79+
Application() {
8080
register(Application.class);
8181
}
8282

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jersey/JerseyAutoConfigurationDefaultFilterPathTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public String message() {
7474
return "Hello " + this.msg;
7575
}
7676

77-
public Application() {
77+
Application() {
7878
register(Application.class);
7979
}
8080

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jersey/JerseyAutoConfigurationDefaultServletPathTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public static class Application extends ResourceConfig {
6969
@Value("${message:World}")
7070
private String msg;
7171

72-
public Application() {
72+
Application() {
7373
register(Application.class);
7474
}
7575

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jersey/JerseyAutoConfigurationObjectMapperProviderTests.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public Message message() {
7777
return new Message("Jersey", null);
7878
}
7979

80-
public Application() {
80+
Application() {
8181
register(Application.class);
8282
}
8383

@@ -93,11 +93,10 @@ public static class Message {
9393

9494
private String body;
9595

96-
public Message() {
97-
96+
Message() {
9897
}
9998

100-
public Message(String subject, String body) {
99+
Message(String subject, String body) {
101100
this.subject = subject;
102101
this.body = body;
103102
}

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jersey/JerseyAutoConfigurationWithoutApplicationPathTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public String message() {
7474
return "Hello " + this.msg;
7575
}
7676

77-
public Application() {
77+
Application() {
7878
register(Application.class);
7979
}
8080

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/orm/jpa/AbstractJpaAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ public static class TestConfigurationWithCustomPersistenceUnitManager {
373373

374374
private final DataSource dataSource;
375375

376-
public TestConfigurationWithCustomPersistenceUnitManager(DataSource dataSource) {
376+
TestConfigurationWithCustomPersistenceUnitManager(DataSource dataSource) {
377377
this.dataSource = dataSource;
378378
}
379379

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/orm/jpa/HibernateJpaAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
*/
8888
class HibernateJpaAutoConfigurationTests extends AbstractJpaAutoConfigurationTests {
8989

90-
public HibernateJpaAutoConfigurationTests() {
90+
HibernateJpaAutoConfigurationTests() {
9191
super(HibernateJpaAutoConfiguration.class);
9292
}
9393

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/quartz/QuartzAutoConfigurationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ private DataSource createTestDataSource() throws Exception {
388388

389389
public static class ComponentThatUsesScheduler {
390390

391-
public ComponentThatUsesScheduler(Scheduler scheduler) {
391+
ComponentThatUsesScheduler(Scheduler scheduler) {
392392
Assert.notNull(scheduler, "Scheduler must not be null");
393393
}
394394

‎spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/security/servlet/SecurityFilterAutoConfigurationEarlyInitializationTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public static class JacksonModuleBean extends SimpleModule {
103103

104104
private static final long serialVersionUID = 1L;
105105

106-
public JacksonModuleBean(DeserializerBean myDeser) {
106+
JacksonModuleBean(DeserializerBean myDeser) {
107107
addDeserializer(SourceType.class, myDeser);
108108
}
109109

@@ -115,7 +115,7 @@ public static class DeserializerBean extends StdDeserializer<SourceType> {
115115
@Autowired
116116
ConversionService conversionService;
117117

118-
public DeserializerBean() {
118+
DeserializerBean() {
119119
super(SourceType.class);
120120
}
121121

‎spring-boot-project/spring-boot-cli/src/main/java/org/springframework/boot/cli/app/SpringApplicationLauncher.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ public Object launch(Class<?>[] sources, String[] args) throws Exception {
6060
Map<String, Object> defaultProperties = new HashMap<>();
6161
defaultProperties.put("spring.groovy.template.check-template-location", "false");
6262
Class<?> applicationClass = this.classLoader.loadClass(getSpringApplicationClassName());
63-
Constructor<?> constructor = applicationClass.getConstructor(Class[].class);
63+
Constructor<?> constructor = applicationClass.getDeclaredConstructor(Class[].class);
64+
constructor.setAccessible(true);
6465
Object application = constructor.newInstance((Object) sources);
6566
applicationClass.getMethod("setDefaultProperties", Map.class).invoke(application, defaultProperties);
6667
Method method = applicationClass.getMethod("run", String[].class);

‎spring-boot-project/spring-boot-cli/src/test/java/org/springframework/boot/cli/app/SpringApplicationLauncherTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public static class TestSpringApplication {
122122

123123
private static String[] args;
124124

125-
public TestSpringApplication(Class<?>[] sources) {
125+
TestSpringApplication(Class<?>[] sources) {
126126
TestSpringApplication.sources = sources;
127127
}
128128

‎spring-boot-project/spring-boot-cli/src/test/java/org/springframework/boot/cli/command/init/InitCommandTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public void setupMocks() {
5959
MockitoAnnotations.initMocks(this);
6060
}
6161

62-
public InitCommandTests() {
62+
InitCommandTests() {
6363
InitializrService initializrService = new InitializrService(this.http);
6464
this.handler = new TestableInitCommandOptionHandler(initializrService);
6565
this.command = new InitCommand(this.handler);

‎spring-boot-project/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/classpath/ClassPathFileSystemWatcherTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public static class Config {
9090

9191
public final Environment environment;
9292

93-
public Config(Environment environment) {
93+
Config(Environment environment) {
9494
this.environment = environment;
9595
}
9696

‎spring-boot-project/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/restart/RestartScopeInitializerTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public ScopeTestBean scopeTestBean() {
7272

7373
public static class ScopeTestBean implements ApplicationListener<ContextRefreshedEvent> {
7474

75-
public ScopeTestBean() {
75+
ScopeTestBean() {
7676
createCount.incrementAndGet();
7777
}
7878

‎spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/web/htmlunit/LocalHostWebClientTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class LocalHostWebClientTests {
4949
@Captor
5050
private ArgumentCaptor<WebRequest> requestCaptor;
5151

52-
public LocalHostWebClientTests() {
52+
LocalHostWebClientTests() {
5353
MockitoAnnotations.initMocks(this);
5454
}
5555

‎spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/web/htmlunit/webdriver/LocalHostWebConnectionHtmlUnitDriverTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class LocalHostWebConnectionHtmlUnitDriverTests {
5050
@Mock
5151
private WebClient webClient;
5252

53-
public LocalHostWebConnectionHtmlUnitDriverTests() {
53+
LocalHostWebConnectionHtmlUnitDriverTests() {
5454
MockitoAnnotations.initMocks(this);
5555
given(this.webClient.getOptions()).willReturn(new WebClientOptions());
5656
given(this.webClient.getWebConsole()).willReturn(new WebConsole());
@@ -108,7 +108,7 @@ private WebRequest requestToUrl(URL url) {
108108

109109
public class TestLocalHostWebConnectionHtmlUnitDriver extends LocalHostWebConnectionHtmlUnitDriver {
110110

111-
public TestLocalHostWebConnectionHtmlUnitDriver(Environment environment) {
111+
TestLocalHostWebConnectionHtmlUnitDriver(Environment environment) {
112112
super(environment);
113113
}
114114

0 commit comments

Comments
 (0)