Skip to content

Commit d8e5169

Browse files
izeyesnicoll
authored andcommitted
Polish
Closes gh-16948
1 parent 54b1230 commit d8e5169

File tree

3 files changed

+8
-32
lines changed

3 files changed

+8
-32
lines changed

spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/extension/OutputCapture.java

+2-23
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,7 @@
1919
import java.io.IOException;
2020
import java.io.OutputStream;
2121
import java.io.PrintStream;
22-
import java.util.ArrayList;
23-
import java.util.List;
2422

25-
import org.hamcrest.Matcher;
26-
import org.junit.Assert;
2723
import org.junit.jupiter.api.extension.AfterEachCallback;
2824
import org.junit.jupiter.api.extension.BeforeAllCallback;
2925
import org.junit.jupiter.api.extension.BeforeEachCallback;
@@ -34,12 +30,11 @@
3430

3531
import org.springframework.boot.ansi.AnsiOutput;
3632

37-
import static org.hamcrest.Matchers.allOf;
38-
3933
/**
4034
* JUnit5 {@code @Extension} to capture output from System.out and System.err.
4135
*
4236
* @author Madhura Bhave
37+
* @since 2.2.0
4338
*/
4439
public class OutputCapture implements BeforeEachCallback, AfterEachCallback,
4540
BeforeAllCallback, ParameterResolver, CharSequence {
@@ -52,20 +47,9 @@ public class OutputCapture implements BeforeEachCallback, AfterEachCallback,
5247

5348
private ByteArrayOutputStream classLevelCopy;
5449

55-
private List<Matcher<? super String>> matchers = new ArrayList<>();
56-
5750
@Override
5851
public void afterEach(ExtensionContext context) {
59-
try {
60-
if (!this.matchers.isEmpty()) {
61-
String output = this.toString();
62-
Assert.assertThat(output, allOf(this.matchers));
63-
}
64-
}
65-
finally {
66-
releaseOutput();
67-
}
68-
52+
releaseOutput();
6953
}
7054

7155
@Override
@@ -168,11 +152,6 @@ public void write(int b) throws IOException {
168152
this.original.flush();
169153
}
170154

171-
@Override
172-
public void write(byte[] b) throws IOException {
173-
write(b, 0, b.length);
174-
}
175-
176155
@Override
177156
public void write(byte[] b, int off, int len) throws IOException {
178157
this.copy.write(b, off, len);

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/extension/OutputCaptureExtendWithTests.java

+4-6
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,19 @@
2929
*/
3030
@ExtendWith(OutputCapture.class)
3131
@ExtendWith(OutputCaptureExtendWithTests.BeforeAllExtension.class)
32-
public class OutputCaptureExtendWithTests {
32+
class OutputCaptureExtendWithTests {
3333

3434
@Test
3535
void captureShouldReturnOutputCapturedBeforeTestMethod(OutputCapture output) {
36-
assertThat(output).contains("Before all");
37-
assertThat(output).doesNotContain("Hello");
36+
assertThat(output).contains("Before all").doesNotContain("Hello");
3837
}
3938

4039
@Test
4140
void captureShouldReturnAllCapturedOutput(OutputCapture output) {
4241
System.out.println("Hello World");
4342
System.err.println("Error!!!");
44-
assertThat(output).contains("Before all");
45-
assertThat(output).contains("Hello World");
46-
assertThat(output).contains("Error!!!");
43+
assertThat(output).contains("Before all").contains("Hello World")
44+
.contains("Error!!!");
4745
}
4846

4947
static class BeforeAllExtension implements BeforeAllCallback {

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/extension/OutputCaptureRegisterExtensionTests.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*
2626
* @author Madhura Bhave
2727
*/
28-
public class OutputCaptureRegisterExtensionTests {
28+
class OutputCaptureRegisterExtensionTests {
2929

3030
@RegisterExtension
3131
OutputCapture output = new OutputCapture();
@@ -34,8 +34,7 @@ public class OutputCaptureRegisterExtensionTests {
3434
void captureShouldReturnAllCapturedOutput() {
3535
System.out.println("Hello World");
3636
System.err.println("Error!!!");
37-
assertThat(this.output).contains("Hello World");
38-
assertThat(this.output).contains("Error!!!");
37+
assertThat(this.output).contains("Hello World").contains("Error!!!");
3938
}
4039

4140
}

0 commit comments

Comments
 (0)