Skip to content

Provide MvcRequestMatcher.Builder that correctly configures the servlet path #39313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Provide MvcRequestMatcher.Builder that correctly configures the servlet path #39313

wants to merge 1 commit into from

Conversation

Wzy19930507
Copy link
Contributor

When only one DispatcherServlet servlet mapping, publish MvcRequestMatcher.Builder bean

Closes #37917

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 26, 2024
@Wzy19930507
Provide MvcRequestMatcher.Builder that correctly configures the servl…
eccc9d9 
…et path

When only one `DispatcherServlet` servlet mapping, publish `MvcRequestMatcher.Builder` bean

Closes spring-projects#37917
@wilkinsona
Copy link
Member

Unfortunately, I don't think we can accept a contribution for this one as dealing with DispatcherServlet is rather complicated and we need to be certain that we get it right when it relates to security. For example, one thing that we need to do is to use the DispatcherServletPath. I think we'll also need to spend some time thinking about how we can be certain that there's only a single DispatcherServlet and if there's any chance that one could be "hiding" behind a ServletRegistrationBean. Thanks anyway for the PR but I think it's better if the core team handle this one in collaboration with the Spring Security team. Sorry for the wasted effort here, I've added pending-design-work to #37917 to more accurately reflect its current status.

@wilkinsona wilkinsona closed this Jan 26, 2024
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 26, 2024
@Wzy19930507 Wzy19930507 deleted the GH-37917 branch January 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide PathPatternRequestMatcher.Builder that correctly configures the servlet path
3 participants
@Wzy19930507 @wilkinsona @spring-projects-issues