Skip to content

Commit 1504c76

Browse files
kezhuwmp911de
authored andcommitted
DATAREDIS-728 - Fix unnecessary initial caches map creation in RedisCacheManagerBuilder.
We now reuse the initially created map and add or replace initial configurations in place instead of creating each time a new map. Original pull request: #293.
1 parent d129e65 commit 1504c76

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/main/java/org/springframework/data/redis/cache/RedisCacheManager.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ public static class RedisCacheManagerBuilder {
221221

222222
private final RedisCacheWriter cacheWriter;
223223
private RedisCacheConfiguration defaultCacheConfiguration = RedisCacheConfiguration.defaultCacheConfig();
224-
private Map<String, RedisCacheConfiguration> intialCaches = new LinkedHashMap<>();
224+
private final Map<String, RedisCacheConfiguration> intialCaches = new LinkedHashMap<>();
225225
private boolean enableTransactions;
226226

227227
private RedisCacheManagerBuilder(RedisCacheWriter cacheWriter) {
@@ -312,10 +312,7 @@ public RedisCacheManagerBuilder withInitialCacheConfigurations(
312312
cacheConfigurations.forEach((cacheName, configuration) -> Assert.notNull(configuration,
313313
String.format("RedisCacheConfiguration for cache %s must not be null!", cacheName)));
314314

315-
Map<String, RedisCacheConfiguration> cacheConfigMap = new LinkedHashMap<>(intialCaches);
316-
cacheConfigMap.putAll(cacheConfigurations);
317-
318-
this.intialCaches = cacheConfigMap;
315+
this.intialCaches.putAll(cacheConfigurations);
319316

320317
return this;
321318
}

0 commit comments

Comments
 (0)