Skip to content

Commit 2442302

Browse files
committed
DATAREDIS-576 - Polishing.
Fix typos, javadoc.
1 parent 9f39498 commit 2442302

File tree

4 files changed

+25
-16
lines changed

4 files changed

+25
-16
lines changed

src/main/java/org/springframework/data/redis/connection/jedis/JedisClientConfiguration.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
* <li>Optional {@link HostnameVerifier}</li>
4343
* <li>Whether to use connection-pooling</li>
4444
* <li>Optional {@link GenericObjectPoolConfig}</li>
45+
* <li>Optional client name</li>
4546
* <li>Connect {@link Duration timeout}</li>
4647
* <li>Read {@link Duration timeout}</li>
4748
* </ul>

src/main/java/org/springframework/data/redis/connection/lettuce/DefaultLettuceClientConfiguration.java

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,63 +55,71 @@ class DefaultLettuceClientConfiguration implements LettuceClientConfiguration {
5555
this.shutdownTimeout = shutdownTimeout;
5656
}
5757

58-
/* (non-Javadoc)
58+
/*
59+
* (non-Javadoc)
5960
* @see org.springframework.data.redis.connection.lettuce.LettuceClientConfiguration#useSsl()
6061
*/
6162
@Override
6263
public boolean isUseSsl() {
6364
return useSsl;
6465
}
6566

66-
/* (non-Javadoc)
67+
/*
68+
* (non-Javadoc)
6769
* @see org.springframework.data.redis.connection.lettuce.LettuceClientConfiguration#isVerifyPeer()
6870
*/
6971
@Override
7072
public boolean isVerifyPeer() {
7173
return verifyPeer;
7274
}
7375

74-
/* (non-Javadoc)
76+
/*
77+
* (non-Javadoc)
7578
* @see org.springframework.data.redis.connection.lettuce.LettuceClientConfiguration#isStartTls()
7679
*/
7780
@Override
7881
public boolean isStartTls() {
7982
return startTls;
8083
}
8184

82-
/* (non-Javadoc)
85+
/*
86+
* (non-Javadoc)
8387
* @see org.springframework.data.redis.connection.lettuce.LettuceClientConfiguration#getClientResources()
8488
*/
8589
@Override
8690
public Optional<ClientResources> getClientResources() {
8791
return clientResources;
8892
}
8993

90-
/* (non-Javadoc)
94+
/*
95+
* (non-Javadoc)
9196
* @see org.springframework.data.redis.connection.lettuce.LettuceClientConfiguration#getClientOptions()
9297
*/
9398
@Override
9499
public Optional<ClientOptions> getClientOptions() {
95100
return clientOptions;
96101
}
97102

98-
/* (non-Javadoc)
103+
/*
104+
* (non-Javadoc)
99105
* @see org.springframework.data.redis.connection.lettuce.LettuceClientConfiguration#getClientName()
100106
*/
101107
@Override
102108
public Optional<String> getClientName() {
103109
return clientName;
104110
}
105111

106-
/* (non-Javadoc)
112+
/*
113+
* (non-Javadoc)
107114
* @see org.springframework.data.redis.connection.lettuce.LettuceClientConfiguration#getTimeout()
108115
*/
109116
@Override
110117
public Duration getCommandTimeout() {
111118
return timeout;
112119
}
113120

114-
/* (non-Javadoc)
121+
/*
122+
* (non-Javadoc)
115123
* @see org.springframework.data.redis.connection.lettuce.LettuceClientConfiguration#getShutdownTimeout()
116124
*/
117125
@Override

src/main/java/org/springframework/data/redis/connection/lettuce/LettuceConnectionFactory.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -935,7 +935,7 @@ public boolean isUseSsl() {
935935
return useSsl;
936936
}
937937

938-
public void setUseSsl(boolean useSsl) {
938+
void setUseSsl(boolean useSsl) {
939939
this.useSsl = useSsl;
940940
}
941941

@@ -947,7 +947,7 @@ public boolean isVerifyPeer() {
947947
return verifyPeer;
948948
}
949949

950-
public void setVerifyPeer(boolean verifyPeer) {
950+
void setVerifyPeer(boolean verifyPeer) {
951951
this.verifyPeer = verifyPeer;
952952
}
953953

@@ -959,7 +959,7 @@ public boolean isStartTls() {
959959
return startTls;
960960
}
961961

962-
public void setStartTls(boolean startTls) {
962+
void setStartTls(boolean startTls) {
963963
this.startTls = startTls;
964964
}
965965

@@ -971,7 +971,7 @@ public Optional<ClientResources> getClientResources() {
971971
return Optional.ofNullable(clientResources);
972972
}
973973

974-
public void setClientResources(ClientResources clientResources) {
974+
void setClientResources(ClientResources clientResources) {
975975
this.clientResources = clientResources;
976976
}
977977

@@ -992,7 +992,7 @@ public Optional<String> getClientName() {
992992
return Optional.ofNullable(clientName);
993993
}
994994

995-
public void setClientName(String clientName) {
995+
void setClientName(String clientName) {
996996
this.clientName = clientName;
997997
}
998998

@@ -1004,7 +1004,7 @@ public Duration getCommandTimeout() {
10041004
return timeout;
10051005
}
10061006

1007-
public void setTimeout(Duration timeout) {
1007+
void setTimeout(Duration timeout) {
10081008
this.timeout = timeout;
10091009
}
10101010

@@ -1016,7 +1016,7 @@ public Duration getShutdownTimeout() {
10161016
return shutdownTimeout;
10171017
}
10181018

1019-
public void setShutdownTimeout(Duration shutdownTimeout) {
1019+
void setShutdownTimeout(Duration shutdownTimeout) {
10201020
this.shutdownTimeout = shutdownTimeout;
10211021
}
10221022
}

src/test/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactorySentinelIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public void tearDown() {
4848
}
4949

5050
@Test // DATAREDIS-574
51-
public void shouldInitiaizeWithSentinelConfiguration() {
51+
public void shouldInitializeWithSentinelConfiguration() {
5252

5353
JedisClientConfiguration clientConfiguration = JedisClientConfiguration.builder() //
5454
.clientName("clientName") //

0 commit comments

Comments
 (0)