Skip to content

Commit f4f0e52

Browse files
committed
Stop declaring parameters as final in JdbcTemplate
The affected parameters are "effectively final" and are therefore no longer required to be declared as "final" on modern JDKs.
1 parent d0bf8fa commit f4f0e52

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ protected Connection createConnectionProxy(Connection con) {
420420
}
421421

422422
@Override
423-
public void execute(final String sql) throws DataAccessException {
423+
public void execute(String sql) throws DataAccessException {
424424
if (logger.isDebugEnabled()) {
425425
logger.debug("Executing SQL statement [" + sql + "]");
426426
}
@@ -442,7 +442,7 @@ public String getSql() {
442442
}
443443

444444
@Override
445-
public <T> @Nullable T query(final String sql, final ResultSetExtractor<T> rse) throws DataAccessException {
445+
public <T> @Nullable T query(String sql, ResultSetExtractor<T> rse) throws DataAccessException {
446446
Assert.notNull(sql, "SQL must not be null");
447447
Assert.notNull(rse, "ResultSetExtractor must not be null");
448448
if (logger.isDebugEnabled()) {
@@ -535,7 +535,7 @@ public SqlRowSet queryForRowSet(String sql) throws DataAccessException {
535535
}
536536

537537
@Override
538-
public int update(final String sql) throws DataAccessException {
538+
public int update(String sql) throws DataAccessException {
539539
Assert.notNull(sql, "SQL must not be null");
540540
if (logger.isDebugEnabled()) {
541541
logger.debug("Executing SQL update [" + sql + "]");
@@ -561,7 +561,7 @@ public String getSql() {
561561
}
562562

563563
@Override
564-
public int[] batchUpdate(final String... sql) throws DataAccessException {
564+
public int[] batchUpdate(String... sql) throws DataAccessException {
565565
Assert.notEmpty(sql, "SQL array must not be empty");
566566
if (logger.isDebugEnabled()) {
567567
logger.debug("Executing SQL batch update of " + sql.length + " statements");
@@ -701,7 +701,7 @@ private String appendSql(@Nullable String sql, String statement) {
701701
* @throws DataAccessException if there is any problem
702702
*/
703703
public <T> @Nullable T query(
704-
PreparedStatementCreator psc, final @Nullable PreparedStatementSetter pss, final ResultSetExtractor<T> rse)
704+
PreparedStatementCreator psc, @Nullable PreparedStatementSetter pss, ResultSetExtractor<T> rse)
705705
throws DataAccessException {
706706

707707
Assert.notNull(rse, "ResultSetExtractor must not be null");
@@ -936,7 +936,7 @@ public SqlRowSet queryForRowSet(String sql, @Nullable Object @Nullable ... args)
936936
return result(query(sql, newArgPreparedStatementSetter(args), new SqlRowSetResultSetExtractor()));
937937
}
938938

939-
protected int update(final PreparedStatementCreator psc, final @Nullable PreparedStatementSetter pss)
939+
protected int update(PreparedStatementCreator psc, @Nullable PreparedStatementSetter pss)
940940
throws DataAccessException {
941941

942942
logger.debug("Executing prepared SQL update");
@@ -966,7 +966,7 @@ public int update(PreparedStatementCreator psc) throws DataAccessException {
966966
}
967967

968968
@Override
969-
public int update(final PreparedStatementCreator psc, final KeyHolder generatedKeyHolder)
969+
public int update(PreparedStatementCreator psc, KeyHolder generatedKeyHolder)
970970
throws DataAccessException {
971971

972972
Assert.notNull(generatedKeyHolder, "KeyHolder must not be null");
@@ -999,8 +999,8 @@ public int update(String sql, @Nullable Object @Nullable ... args) throws DataAc
999999
}
10001000

10011001
@Override
1002-
public int[] batchUpdate(final PreparedStatementCreator psc, final BatchPreparedStatementSetter pss,
1003-
final KeyHolder generatedKeyHolder) throws DataAccessException {
1002+
public int[] batchUpdate(PreparedStatementCreator psc, BatchPreparedStatementSetter pss,
1003+
KeyHolder generatedKeyHolder) throws DataAccessException {
10041004

10051005
int[] result = execute(psc, getPreparedStatementCallback(pss, generatedKeyHolder));
10061006

@@ -1009,7 +1009,7 @@ public int[] batchUpdate(final PreparedStatementCreator psc, final BatchPrepared
10091009
}
10101010

10111011
@Override
1012-
public int[] batchUpdate(String sql, final BatchPreparedStatementSetter pss) throws DataAccessException {
1012+
public int[] batchUpdate(String sql, BatchPreparedStatementSetter pss) throws DataAccessException {
10131013
if (logger.isDebugEnabled()) {
10141014
logger.debug("Executing SQL batch update [" + sql + "]");
10151015
}
@@ -1029,7 +1029,7 @@ public int[] batchUpdate(String sql, List<Object[]> batchArgs) throws DataAccess
10291029
}
10301030

10311031
@Override
1032-
public int[] batchUpdate(String sql, List<Object[]> batchArgs, final int[] argTypes) throws DataAccessException {
1032+
public int[] batchUpdate(String sql, List<Object[]> batchArgs, int[] argTypes) throws DataAccessException {
10331033
if (batchArgs.isEmpty()) {
10341034
return new int[0];
10351035
}
@@ -1066,8 +1066,8 @@ public int getBatchSize() {
10661066
}
10671067

10681068
@Override
1069-
public <T> int[][] batchUpdate(String sql, final Collection<T> batchArgs, final int batchSize,
1070-
final ParameterizedPreparedStatementSetter<T> pss) throws DataAccessException {
1069+
public <T> int[][] batchUpdate(String sql, Collection<T> batchArgs, int batchSize,
1070+
ParameterizedPreparedStatementSetter<T> pss) throws DataAccessException {
10711071

10721072
if (logger.isDebugEnabled()) {
10731073
logger.debug("Executing SQL batch update [" + sql + "] with a batch size of " + batchSize);

0 commit comments

Comments
 (0)