Skip to content

Commit bf0a3eb

Browse files
committed
Eliminate unnecessary sessionRepository::findById
1 parent 79fbca2 commit bf0a3eb

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

spring-session-core/src/main/java/org/springframework/session/web/http/SessionRepositoryFilter.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
* @author Rob Winch
7777
* @author Vedran Pavic
7878
* @author Josh Cummings
79+
* @author Yanming Zhou
7980
*/
8081
@Order(SessionRepositoryFilter.DEFAULT_ORDER)
8182
public class SessionRepositoryFilter<S extends Session> extends OncePerRequestFilter {
@@ -222,10 +223,11 @@ private void commitSession() {
222223
}
223224
else {
224225
S session = wrappedSession.getSession();
226+
String requestedSessionId = getRequestedSessionId(); // assign before clearRequestedSessionCache() for later use
225227
clearRequestedSessionCache();
226228
SessionRepositoryFilter.this.sessionRepository.save(session);
227229
String sessionId = session.getId();
228-
if (!isRequestedSessionIdValid() || !sessionId.equals(getRequestedSessionId())) {
230+
if (!isRequestedSessionIdValid() || !sessionId.equals(requestedSessionId)) {
229231
SessionRepositoryFilter.this.httpSessionIdResolver.setSessionId(this, this.response, sessionId);
230232
}
231233
}

0 commit comments

Comments
 (0)