Skip to content

Commit 7cc40e5

Browse files
committed
fixed a bug where the mobile menu would display even when no menu items were provided
1 parent e073352 commit 7cc40e5

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
- **divider component**: Add new properties to the divider component: `link`, `bold`, `italics`, `underline`, `size`.
1919
- **form component**: fix slight misalignment and sizing issues of checkboxes and radio buttons.
2020
- **table component**: fixed a bug where markdown contents of table cells would not be rendered as markdown if the column name contained uppercase letters on Postgres. Column name matching is now case-insensitive, so `'title' as markdown` will work the same as `'Title' as markdown`. In postgres, non-double-quoted identifiers are always folded to lowercase.
21+
- **shell component**: fixed a bug where the mobile menu would display even when no menu items were provided.
2122

2223
## 0.28.0 (2024-08-31)
2324
- Chart component: fix the labels of pie charts displaying too many decimal places.

sqlpage/templates/shell.handlebars

+2
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,14 @@
195195
<h1 class="mb-0 fs-2 text-truncate flex-grow-1" style="flex-basis:0">
196196
<a class="text-decoration-none" href="{{#if link}}{{link}}{{else}}/{{/if}}">{{default navbar_title title}}</a>
197197
</h1>
198+
{{#if menu_item}}
198199
<button class="navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#navbar-menu" aria-controls="navbar-menu" aria-expanded="false" aria-label="Toggle navigation">
199200
<span class="navbar-toggler-icon"></span>
200201
</button>
201202
<div class="collapse navbar-collapse flex-grow-0" id="navbar-menu">
202203
{{> menu-items menu_item=menu_item}}
203204
</div>
205+
{{/if}}
204206
</div>
205207
</nav>
206208
</header>

0 commit comments

Comments
 (0)