Skip to content

Commit 85e305b

Browse files
committed
Create a ZipFile in a context so it will be automatically closed
1 parent 0dfb118 commit 85e305b

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

src/edu/stanford/nlp/ui/JarFileChooser.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public String showListSelectionDialog(List<String> files, Point location) {
6363
//frame.setLocation(location);
6464
final JDialog dialog = new JDialog(frame, "Jar File Chooser", true);
6565
dialog.setLocation(location);
66-
final JList fileList = new JList(new Vector<>(files));
66+
final JList<String> fileList = new JList<>(new Vector<>(files));
6767
fileList.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
6868
MouseListener mouseListener = new MouseAdapter() {
6969
public void mouseClicked(MouseEvent e) {
@@ -126,16 +126,17 @@ public List<String> getFiles(File jarFile)
126126
//System.out.println("Looking at " + jarFile);
127127
List<String> files = new ArrayList<>();
128128

129-
ZipFile zin = new ZipFile(jarFile);
130-
Enumeration<? extends ZipEntry> entries = zin.entries();
131-
while (entries.hasMoreElements()) {
132-
ZipEntry entry = entries.nextElement();
133-
String name = entry.getName();
134-
if (name.matches(pattern)) {
135-
files.add(name);
129+
try (ZipFile zin = new ZipFile(jarFile)) {
130+
Enumeration<? extends ZipEntry> entries = zin.entries();
131+
while (entries.hasMoreElements()) {
132+
ZipEntry entry = entries.nextElement();
133+
String name = entry.getName();
134+
if (name.matches(pattern)) {
135+
files.add(name);
136+
}
136137
}
138+
Collections.sort(files);
137139
}
138-
Collections.sort(files);
139140
return files;
140141
}
141142
}

0 commit comments

Comments
 (0)