Skip to content

Commit 47731bb

Browse files
anandkaranubcanandkaranubc
committed
chore: apply suggestions from review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 850edec commit 47731bb

File tree

7 files changed

+53
-61
lines changed

7 files changed

+53
-61
lines changed

‎lib/node_modules/@stdlib/math/base/special/minmax/include/stdlib/math/base/special/minmax.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ extern "C" {
2727
#endif
2828

2929
/**
30-
* Returns the minimum and maximum values.
30+
* Evaluates the minimum and maximum values.
3131
*/
3232
void stdlib_base_minmax( const double x, const double y, double *min, double *max );
3333

‎lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,20 +36,20 @@ var addon = require( './../src/addon.node' );
3636
*
3737
* @example
3838
* var v = minmax( 3.14, 4.2 );
39-
* // returns [ 3.14, 4.2 ]
39+
* // returns <Float64Array>[ 3.14, 4.2 ]
4040
*
4141
* @example
4242
* var v = minmax( 3.14, NaN );
43-
* // returns [ NaN, NaN ]
43+
* // returns <Float64Array>[ NaN, NaN ]
4444
*
4545
* @example
4646
* var v = minmax( +0.0, -0.0 );
47-
* // returns [ -0.0, 0.0 ]
47+
* // returns <Float64Array>[ -0.0, 0.0 ]
4848
*/
4949
function minmax( x, y ) {
5050
var out = new Float64Array( 2 );
5151
addon( x, y, out );
52-
return [ out[ 0 ], out[ 1 ] ];
52+
return out;
5353
}
5454

5555

‎lib/node_modules/@stdlib/math/base/special/minmax/manifest.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,6 @@
5555
"libraries": [],
5656
"libpath": [],
5757
"dependencies": [
58-
"@stdlib/napi/argv",
59-
"@stdlib/napi/argv-double",
60-
"@stdlib/napi/argv-float64array",
61-
"@stdlib/napi/export",
6258
"@stdlib/math/base/assert/is-nan",
6359
"@stdlib/math/base/assert/is-negative-zero"
6460
]
@@ -74,10 +70,6 @@
7470
"libraries": [],
7571
"libpath": [],
7672
"dependencies": [
77-
"@stdlib/napi/argv",
78-
"@stdlib/napi/argv-double",
79-
"@stdlib/napi/argv-float64array",
80-
"@stdlib/napi/export",
8173
"@stdlib/math/base/assert/is-nan",
8274
"@stdlib/math/base/assert/is-negative-zero"
8375
]

‎lib/node_modules/@stdlib/math/base/special/minmax/src/main.c

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,25 +19,23 @@
1919
#include "stdlib/math/base/special/minmax.h"
2020
#include "stdlib/math/base/assert/is_nan.h"
2121
#include "stdlib/math/base/assert/is_negative_zero.h"
22-
#include <stdlib.h>
2322

2423
/**
25-
* Evaluates the min and max of two values.
24+
* Evaluates the minimum and maximum values.
2625
*
27-
* @param x First value
28-
* @param y Second value
29-
* @param min destination to store minimum value
30-
* @param max destination to store maximum value
26+
* @param x first number
27+
* @param y second number
28+
* @param min destination to store the minimum value
29+
* @param max destination to store the maximum value
3130
*
3231
* @example
33-
* #include <stdint.h>
32+
* double x = 3.14;
33+
* double y = 2.71;
3434
*
3535
* double min;
3636
* double max;
37-
* stdlib_base_minmax( 3.14, NaN );
38-
* // returns [ NaN, NaN ]
37+
* stdlib_base_minmax( x, y, &min, &max );
3938
*/
40-
4139
void stdlib_base_minmax( const double x, const double y, double* min, double* max ) {
4240
if ( stdlib_base_is_nan( x ) || stdlib_base_is_nan( y ) ) {
4341
*min = 0.0 / 0.0; // NaN

‎lib/node_modules/@stdlib/math/base/special/minmax/test/test.assign.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -139,14 +139,14 @@ tape( 'the function returns the minimum and maximum values', function test( t )
139139
out = new Float64Array( 2 );
140140
v = minmax( 4.2, 3.14, out, 1, 0 );
141141
t.strictEqual( v, out, 'returns output array' );
142-
t.strictEqual( v[ 0 ], 3.14, 'returns min value' );
143-
t.strictEqual( v[ 1 ], 4.2, 'returns max value' );
142+
t.strictEqual( v[ 0 ], 3.14, 'returns expected value' );
143+
t.strictEqual( v[ 1 ], 4.2, 'returns expected value' );
144144

145145
out = new Float64Array( 2 );
146146
v = minmax( -4.2, 3.14, out, 1, 0 );
147147
t.strictEqual( v, out, 'returns output array' );
148-
t.strictEqual( v[ 0 ], -4.2, 'returns min value' );
149-
t.strictEqual( v[ 1 ], 3.14, 'returns max value' );
148+
t.strictEqual( v[ 0 ], -4.2, 'returns expected value' );
149+
t.strictEqual( v[ 1 ], 3.14, 'returns expected value' );
150150

151151
t.end();
152152
});
@@ -158,14 +158,14 @@ tape( 'the function supports providing an output object (array)', function test(
158158
out = [ 0.0, 0.0 ];
159159
v = minmax( 4.2, 3.14, out, 1, 0 );
160160
t.strictEqual( v, out, 'returns output array' );
161-
t.strictEqual( v[ 0 ], 3.14, 'returns min value' );
162-
t.strictEqual( v[ 1 ], 4.2, 'returns max value' );
161+
t.strictEqual( v[ 0 ], 3.14, 'returns expected value' );
162+
t.strictEqual( v[ 1 ], 4.2, 'returns expected value' );
163163

164164
out = [ 0.0, 0.0 ];
165165
v = minmax( -4.2, 3.14, out, 1, 0 );
166166
t.strictEqual( v, out, 'returns output array' );
167-
t.strictEqual( v[ 0 ], -4.2, 'returns min value' );
168-
t.strictEqual( v[ 1 ], 3.14, 'returns max value' );
167+
t.strictEqual( v[ 0 ], -4.2, 'returns expected value' );
168+
t.strictEqual( v[ 1 ], 3.14, 'returns expected value' );
169169

170170
t.end();
171171
});
@@ -177,14 +177,14 @@ tape( 'the function supports providing an output object (typed array)', function
177177
out = new Float64Array( 2 );
178178
v = minmax( 4.2, 3.14, out, 1, 0 );
179179
t.strictEqual( v, out, 'returns output array' );
180-
t.strictEqual( v[ 0 ], 3.14, 'returns min value' );
181-
t.strictEqual( v[ 1 ], 4.2, 'returns max value' );
180+
t.strictEqual( v[ 0 ], 3.14, 'returns expected value' );
181+
t.strictEqual( v[ 1 ], 4.2, 'returns expected value' );
182182

183183
out = new Float64Array( 2 );
184184
v = minmax( -4.2, 3.14, out, 1, 0 );
185185
t.strictEqual( v, out, 'returns output array' );
186-
t.strictEqual( v[ 0 ], -4.2, 'returns min value' );
187-
t.strictEqual( v[ 1 ], 3.14, 'returns max value' );
186+
t.strictEqual( v[ 0 ], -4.2, 'returns expected value' );
187+
t.strictEqual( v[ 1 ], 3.14, 'returns expected value' );
188188

189189
t.end();
190190
});

‎lib/node_modules/@stdlib/math/base/special/minmax/test/test.main.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,12 +109,12 @@ tape( 'the function returns the minimum and maximum values', function test( t )
109109
var v;
110110

111111
v = minmax( 4.2, 3.14 );
112-
t.strictEqual( v[ 0 ], 3.14, 'returns min value' );
113-
t.strictEqual( v[ 1 ], 4.2, 'returns max value' );
112+
t.strictEqual( v[ 0 ], 3.14, 'returns expected value' );
113+
t.strictEqual( v[ 1 ], 4.2, 'returns expected value' );
114114

115115
v = minmax( -4.2, 3.14 );
116-
t.strictEqual( v[ 0 ], -4.2, 'returns min value' );
117-
t.strictEqual( v[ 1 ], 3.14, 'returns max value' );
116+
t.strictEqual( v[ 0 ], -4.2, 'returns expected value' );
117+
t.strictEqual( v[ 1 ], 3.14, 'returns expected value' );
118118

119119
t.end();
120120
});

‎lib/node_modules/@stdlib/math/base/special/minmax/test/test.native.js

Lines changed: 24 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ var opts = {
3838
};
3939

4040

41+
// TESTS //
42+
4143
// TESTS //
4244

4345
tape( 'main export is a function', opts, function test( t ) {
@@ -50,16 +52,16 @@ tape( 'the function returns `NaN` for both the minimum and maximum value if prov
5052
var v;
5153

5254
v = minmax( NaN, 3.14 );
53-
t.strictEqual( isnan( v[ 0 ] ), true, 'returns NaN' );
54-
t.strictEqual( isnan( v[ 1 ] ), true, 'returns NaN' );
55+
t.strictEqual( isnan( v[ 0 ] ), true, 'returns expected value' );
56+
t.strictEqual( isnan( v[ 1 ] ), true, 'returns expected value' );
5557

5658
v = minmax( 3.14, NaN );
57-
t.strictEqual( isnan( v[ 0 ] ), true, 'returns NaN' );
58-
t.strictEqual( isnan( v[ 1 ] ), true, 'returns NaN' );
59+
t.strictEqual( isnan( v[ 0 ] ), true, 'returns expected value' );
60+
t.strictEqual( isnan( v[ 1 ] ), true, 'returns expected value' );
5961

6062
v = minmax( NaN, NaN );
61-
t.strictEqual( isnan( v[ 0 ] ), true, 'returns NaN' );
62-
t.strictEqual( isnan( v[ 1 ] ), true, 'returns NaN' );
63+
t.strictEqual( isnan( v[ 0 ] ), true, 'returns expected value' );
64+
t.strictEqual( isnan( v[ 1 ] ), true, 'returns expected value' );
6365

6466
t.end();
6567
});
@@ -68,11 +70,11 @@ tape( 'the function returns `-Infinity` as the minimum value if provided `-Infin
6870
var v;
6971

7072
v = minmax( NINF, 3.14 );
71-
t.strictEqual( v[ 0 ], NINF, 'returns -infinity' );
73+
t.strictEqual( v[ 0 ], NINF, 'returns expected value' );
7274
t.strictEqual( v[ 1 ], 3.14, 'returns expected value' );
7375

7476
v = minmax( 3.14, NINF );
75-
t.strictEqual( v[ 0 ], NINF, 'returns -infinity' );
77+
t.strictEqual( v[ 0 ], NINF, 'returns expected value' );
7678
t.strictEqual( v[ 1 ], 3.14, 'returns expected value' );
7779

7880
t.end();
@@ -83,11 +85,11 @@ tape( 'the function returns `+Infinity` as the maximum value if provided `+Infin
8385

8486
v = minmax( PINF, 3.14 );
8587
t.strictEqual( v[ 0 ], 3.14, 'returns expected value' );
86-
t.strictEqual( v[ 1 ], PINF, 'returns +infinity' );
88+
t.strictEqual( v[ 1 ], PINF, 'returns expected value' );
8789

8890
v = minmax( 3.14, PINF );
8991
t.strictEqual( v[ 0 ], 3.14, 'returns expected value' );
90-
t.strictEqual( v[ 1 ], PINF, 'returns +infinity' );
92+
t.strictEqual( v[ 1 ], PINF, 'returns expected value' );
9193

9294
t.end();
9395
});
@@ -96,20 +98,20 @@ tape( 'the function returns correctly signed zeros', opts, function test( t ) {
9698
var v;
9799

98100
v = minmax( +0.0, -0.0 );
99-
t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns -0' );
100-
t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns +0' );
101+
t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns expected value' );
102+
t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns expected value' );
101103

102104
v = minmax( -0.0, +0.0 );
103-
t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns -0' );
104-
t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns +0' );
105+
t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns expected value' );
106+
t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns expected value' );
105107

106108
v = minmax( -0.0, -0.0 );
107-
t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns -0' );
108-
t.strictEqual( isNegativeZero( v[ 1 ] ), true, 'returns -0' );
109+
t.strictEqual( isNegativeZero( v[ 0 ] ), true, 'returns expected value' );
110+
t.strictEqual( isNegativeZero( v[ 1 ] ), true, 'returns expected value' );
109111

110112
v = minmax( +0.0, +0.0 );
111-
t.strictEqual( isPositiveZero( v[ 0 ] ), true, 'returns +0' );
112-
t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns +0' );
113+
t.strictEqual( isPositiveZero( v[ 0 ] ), true, 'returns expected value' );
114+
t.strictEqual( isPositiveZero( v[ 1 ] ), true, 'returns expected value' );
113115

114116
t.end();
115117
});
@@ -118,12 +120,12 @@ tape( 'the function returns the minimum and maximum values', opts, function test
118120
var v;
119121

120122
v = minmax( 4.2, 3.14 );
121-
t.strictEqual( v[ 0 ], 3.14, 'returns min value' );
122-
t.strictEqual( v[ 1 ], 4.2, 'returns max value' );
123+
t.strictEqual( v[ 0 ], 3.14, 'returns expected value' );
124+
t.strictEqual( v[ 1 ], 4.2, 'returns expected value' );
123125

124126
v = minmax( -4.2, 3.14 );
125-
t.strictEqual( v[ 0 ], -4.2, 'returns min value' );
126-
t.strictEqual( v[ 1 ], 3.14, 'returns max value' );
127+
t.strictEqual( v[ 0 ], -4.2, 'returns expected value' );
128+
t.strictEqual( v[ 1 ], 3.14, 'returns expected value' );
127129

128130
t.end();
129131
});

0 commit comments

Comments
 (0)