bench: refactor random number generation in stats/base/dists/normal #5112

pranav-1720 · 2025-02-08T06:48:29Z

Resolves #4981.

Description

What is the purpose of this pull request?

This pull request:

Refactors random number generation in JS benchmarks for stats/base/dists/normal.
Replaces randu() with uniform() for cleaner and more consistent code.
Moves the random number generation outside the benchmarking loops.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves #4981.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

…or stats/base/dists/normal --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-02-08T06:50:55Z

Coverage Report

The above coverage report was generated for the changes in this PR.

anandkaranubc · 2025-02-10T07:16:44Z

lib/node_modules/@stdlib/stats/base/dists/normal/ctor/benchmark/benchmark.js

 	}
+
 	b.toc();


Suggested change

}

b.toc();

}

b.toc();

This change is still needed.

anandkaranubc · 2025-02-10T07:17:16Z

lib/node_modules/@stdlib/stats/base/dists/normal/ctor/benchmark/benchmark.js

 	}
+
 	b.toc();


Suggested change

}

b.toc();

}

b.toc();

Same comment as above, and applies throughout the PR

This still needs to be addressed.

anandkaranubc · 2025-02-10T07:20:04Z

lib/node_modules/@stdlib/stats/base/dists/normal/ctor/benchmark/benchmark.js

+	}
 	b.tic();


Suggested change

}

b.tic();

}

b.tic();

anandkaranubc · 2025-02-10T07:22:08Z

lib/node_modules/@stdlib/stats/base/dists/normal/mode/benchmark/benchmark.js

-		mu = ( randu()*100.0 ) - 50.0;
-		sigma = ( randu()*20.0 ) + EPS;
-		y = mode( mu, sigma );
+		y = mode( mu[ i % 100 ], sigma[ i % 100 ] );


Suggested change

y = mode( mu[ i % 100 ], sigma[ i % 100 ] );

y = mode( mu[ i % len ], sigma[ i % len ] );

anandkaranubc · 2025-02-10T07:22:31Z

lib/node_modules/@stdlib/stats/base/dists/normal/pdf/benchmark/benchmark.js

-		mu = ( randu()*100.0 ) - 50.0;
-		sigma = ( randu()*20.0 ) + EPS;
-		y = pdf( x, mu, sigma );
+		y = pdf( x[ i % 100 ], mu[ i % 100 ], sigma[ i % 100 ] );


Same comment.

anandkaranubc · 2025-02-10T07:23:07Z

lib/node_modules/@stdlib/stats/base/dists/normal/pdf/benchmark/benchmark.js


 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = ( randu()*6.0 ) - 3.0;
-		y = mypdf( x );
+		y = mypdf( x[ i % 100 ] );


Suggested change

y = mypdf( x[ i % 100 ] );

y = mypdf( x[ i % len ] );

Applies throughout the PR.

anandkaranubc · 2025-02-10T07:25:02Z

Great work, @pranav-1720! Just a few minor changes needed; otherwise, everything looks good!

And also change in title:

bench: refactor random number generation in stats/base/dists/normal

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

pranav-1720 · 2025-02-10T08:39:47Z

@anandkaranubc hey have made the changes you suggested

anandkaranubc · 2025-02-10T18:29:55Z

lib/node_modules/@stdlib/stats/base/dists/normal/ctor/benchmark/benchmark.js

+	}
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {


Suggested change

}

b.tic();

for ( i = 0; i < b.iterations; i++ ) {

}

b.tic();

for ( i = 0; i < b.iterations; i++ ) {

This change is still pending

anandkaranubc · 2025-02-10T18:30:50Z

lib/node_modules/@stdlib/stats/base/dists/normal/ctor/benchmark/benchmark.js

 	}
+
 	b.toc();


This change is still needed.

anandkaranubc · 2025-02-10T18:31:19Z

lib/node_modules/@stdlib/stats/base/dists/normal/ctor/benchmark/benchmark.js

 	}
+
 	b.toc();


This still needs to be addressed.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

pranav-1720 · 2025-02-10T22:46:06Z

@anandkaranubc added the whitespace changes as well. Also is there an automated way to check these whitespace linting isues, the current linting config does not seem to catch them or perhaps i am missing something in my local setup. I get errors for trailing whitespace and some other issues but not the ones you highlighted for this PR

anandkaranubc · 2025-02-17T19:00:28Z

is there an automated way to check these whitespace linting isues

I don’t think the linter catches all the whitespace linting issues. It does catch some (there might be a reason why it is configured this way). Maybe you can look into improving it, propose an idea in the OH tomorrow, or raise an issue?

anandkaranubc

Still some changes to be made. Rest, the PR looks good. Thanks for making those changes!

anandkaranubc · 2025-02-17T19:01:04Z

lib/node_modules/@stdlib/stats/base/dists/normal/cdf/benchmark/benchmark.js

+	}
 	b.tic();


Suggested change

}

b.tic();

}

b.tic();

anandkaranubc · 2025-02-17T19:04:31Z

lib/node_modules/@stdlib/stats/base/dists/normal/ctor/benchmark/benchmark.js

+	len = 100;
+	x = new Float64Array( len );
+	for ( i = 0; i < len; i++ ) {
+		x[ i ] = uniform( EPS + 1.0, 100.0 );


Suggested change

x[ i ] = uniform( EPS + 1.0, 100.0 );

x[ i ] = uniform( 1.0 + EPS, 100.0 );

Not something that makes a difference, but good for consistency.

anandkaranubc · 2025-02-17T19:05:10Z

lib/node_modules/@stdlib/stats/base/dists/normal/ctor/benchmark/benchmark.js

+	}
 	b.tic();


Suggested change

}

b.tic();

}

b.tic();

This applies throughout the PR

anandkaranubc · 2025-02-17T19:06:15Z

lib/node_modules/@stdlib/stats/base/dists/normal/ctor/benchmark/benchmark.js

+	}
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {


This change is still pending

anandkaranubc · 2025-02-17T19:07:31Z

lib/node_modules/@stdlib/stats/base/dists/normal/logcdf/benchmark/benchmark.js

@@ -21,7 +21,8 @@
 // MODULES //

 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var Float64Array = require( '@stdlib/array/float64' );
+var uniform	= require( '@stdlib/random/base/uniform' );


Suggested change

var uniform = require( '@stdlib/random/base/uniform' );

var uniform = require( '@stdlib/random/base/uniform' );

fixed, how did you even find that. I dont even know how the space was replaced by tab

anandkaranubc · 2025-02-17T19:08:16Z

lib/node_modules/@stdlib/stats/base/dists/normal/logpdf/benchmark/benchmark.js

@@ -21,7 +21,8 @@
 // MODULES //

 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var Float64Array = require( '@stdlib/array/float64' );
+var uniform	= require( '@stdlib/random/base/uniform' );


Same comment

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

pranav-1720 · 2025-02-18T16:59:58Z

@anandkaranubc made the changes, hopefully everything should be in order now. Cheers!

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 8, 2025

pranav-1720 changed the title ~~bench: Refactor stats/base/dists/normal~~ bench: refactor stats/base/dists/normal Feb 8, 2025

anandkaranubc requested changes Feb 10, 2025

View reviewed changes

anandkaranubc added the Needs Changes Pull request which needs changes before being merged. label Feb 10, 2025

pranav-1720 added 2 commits February 10, 2025 14:05

pranav-1720 changed the title ~~bench: refactor stats/base/dists/normal~~ bench: refactor random number generation in stats/base/dists/normal Feb 10, 2025

anandkaranubc requested changes Feb 10, 2025

View reviewed changes

anandkaranubc requested changes Feb 17, 2025

View reviewed changes

anandkaranubc removed the Needs Review A pull request which needs code review. label Feb 17, 2025

pranav-1720 added 2 commits February 18, 2025 22:22

pranav-1720 requested a review from anandkaranubc February 24, 2025 16:36

stdlib-bot added the Needs Review A pull request which needs code review. label Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bench: refactor random number generation in stats/base/dists/normal #5112

bench: refactor random number generation in stats/base/dists/normal #5112

pranav-1720 commented Feb 8, 2025 •

edited

Loading

stdlib-bot commented Feb 8, 2025 •

edited

Loading

anandkaranubc Feb 10, 2025

anandkaranubc Feb 10, 2025

anandkaranubc Feb 10, 2025

anandkaranubc Feb 10, 2025

anandkaranubc Feb 10, 2025

anandkaranubc Feb 10, 2025

anandkaranubc Feb 10, 2025

anandkaranubc Feb 10, 2025

anandkaranubc commented Feb 10, 2025 •

edited

Loading

pranav-1720 commented Feb 10, 2025

anandkaranubc Feb 10, 2025

anandkaranubc Feb 17, 2025

anandkaranubc Feb 10, 2025

anandkaranubc Feb 10, 2025

pranav-1720 commented Feb 10, 2025

anandkaranubc commented Feb 17, 2025

anandkaranubc left a comment

anandkaranubc Feb 17, 2025

anandkaranubc Feb 17, 2025

anandkaranubc Feb 17, 2025

anandkaranubc Feb 17, 2025

anandkaranubc Feb 17, 2025

pranav-1720 Feb 18, 2025

anandkaranubc Feb 17, 2025

pranav-1720 commented Feb 18, 2025

	y = mode( mu[ i % 100 ], sigma[ i % 100 ] );
	y = mode( mu[ i % len ], sigma[ i % len ] );

	x[ i ] = uniform( EPS + 1.0, 100.0 );
	x[ i ] = uniform( 1.0 + EPS, 100.0 );

	var uniform = require( '@stdlib/random/base/uniform' );
	var uniform = require( '@stdlib/random/base/uniform' );

bench: refactor random number generation in stats/base/dists/normal #5112

Are you sure you want to change the base?

bench: refactor random number generation in stats/base/dists/normal #5112

Conversation

pranav-1720 commented Feb 8, 2025 • edited Loading

Description

Related Issues

Questions

Other

Checklist

stdlib-bot commented Feb 8, 2025 • edited Loading

Coverage Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anandkaranubc commented Feb 10, 2025 • edited Loading

pranav-1720 commented Feb 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pranav-1720 commented Feb 10, 2025

anandkaranubc commented Feb 17, 2025

anandkaranubc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pranav-1720 commented Feb 18, 2025

pranav-1720 commented Feb 8, 2025 •

edited

Loading

stdlib-bot commented Feb 8, 2025 •

edited

Loading

anandkaranubc commented Feb 10, 2025 •

edited

Loading