number to string

Author: baseballyama

packages/eslint-plugin-svelte/src/utils/svelte-context.ts

@@ -7,10 +7,10 @@ import { getFilename, getSourceCode } from './compat.js';
 const isRunInBrowser = !fs.readFileSync;
 
 export type SvelteContext = {
-	svelteVersion: '3/4' | 5;
+	svelteVersion: '3/4' | '5';
 	fileType: '.svelte' | '.svelte.[js|ts]';
 	runes: boolean;
-	svelteKitVersion: '1-next' | 1 | 2 | null;
+	svelteKitVersion: '1-next' | '1' | '2' | null;
 	svelteKitFileType:
 		| '+page.svelte'
 		| '+page.js'
@@ -122,14 +122,14 @@ function getSvelteKitContext(
  */
 function getSvelteKitVersion(filePath: string): SvelteContext['svelteKitVersion'] {
 	// Hack: if it runs in browser, it regards as SvelteKit project.
-	if (isRunInBrowser) return 2;
+	if (isRunInBrowser) return '2';
 	try {
 		const packageJson = getPackageJson(filePath);
 		if (!packageJson) return null;
 		if (packageJson.name === 'eslint-plugin-svelte')
 			// Hack: CI removes `@sveltejs/kit` and it returns false and test failed.
 			// So always it returns true if it runs on the package.
-			return 2;
+			return '2';
 
 		const version =
 			packageJson.dependencies?.['@sveltejs/kit'] ?? packageJson.devDependencies?.['@sveltejs/kit'];
@@ -139,12 +139,12 @@ function getSvelteKitVersion(filePath: string): SvelteContext['svelteKitVersion'
 		if (version.startsWith('1.0.0-next.')) {
 			return '1-next';
 		} else if (version.startsWith('1.')) {
-			return 1;
+			return '1';
 		} else if (version.startsWith('2.')) {
-			return 2;
+			return '2';
 		}
 		// If unknown version, it recognize as v2.
-		return 2;
+		return '2';
 	} catch {
 		return null;
 	}
@@ -155,7 +155,7 @@ function getSvelteVersion(compilerVersion: string): SvelteContext['svelteVersion
 	if (version === 3 || version === 4) {
 		return '3/4';
 	}
-	return 5;
+	return '5';
 }
 
 /**

packages/eslint-plugin-svelte/tests/src/index.spec.ts

@@ -10,34 +10,34 @@ const actualSvelte3: Parameters<typeof shouldRun>[0] = {
 };
 
 const actualSvelte5: Parameters<typeof shouldRun>[0] = {
-	svelteVersion: 5,
+	svelteVersion: '5',
 	fileType: '.svelte',
 	runes: true,
 	svelteKitVersion: null,
 	svelteKitFileType: null
 };
 
 const actualSvelte5Script: Parameters<typeof shouldRun>[0] = {
-	svelteVersion: 5,
+	svelteVersion: '5',
 	fileType: '.svelte.[js|ts]',
 	runes: true,
 	svelteKitVersion: null,
 	svelteKitFileType: null
 };
 
 const actualSvelteKit: Parameters<typeof shouldRun>[0] = {
-	svelteVersion: 5,
+	svelteVersion: '5',
 	fileType: '.svelte',
 	runes: true,
-	svelteKitVersion: 2,
+	svelteKitVersion: '2',
 	svelteKitFileType: '+page.svelte'
 };
 
 const actualSvelteKitNotRoute: Parameters<typeof shouldRun>[0] = {
-	svelteVersion: 5,
+	svelteVersion: '5',
 	fileType: '.svelte',
 	runes: true,
-	svelteKitVersion: 2,
+	svelteKitVersion: '2',
 	svelteKitFileType: null
 };
 
@@ -84,7 +84,7 @@ describe('shouldRun', () => {
 		assert.strictEqual(
 			shouldRun(actualSvelte3, [
 				{
-					svelteVersions: [5]
+					svelteVersions: ['5']
 				}
 			]),
 			false
@@ -98,7 +98,7 @@ describe('shouldRun', () => {
 					svelteVersions: ['3/4']
 				},
 				{
-					svelteVersions: [5]
+					svelteVersions: ['5']
 				}
 			]),
 			true
@@ -123,7 +123,7 @@ describe('shouldRun', () => {
 		assert.strictEqual(
 			shouldRun(actualSvelte5, [
 				{
-					svelteVersions: [5],
+					svelteVersions: ['5'],
 					runes: [true]
 				}
 			]),
@@ -135,7 +135,7 @@ describe('shouldRun', () => {
 		assert.strictEqual(
 			shouldRun(actualSvelte5, [
 				{
-					svelteVersions: [5],
+					svelteVersions: ['5'],
 					runes: [false]
 				}
 			]),
@@ -158,7 +158,7 @@ describe('shouldRun', () => {
 		assert.strictEqual(
 			shouldRun(actualSvelte5, [
 				{
-					svelteVersions: [5],
+					svelteVersions: ['5'],
 					fileTypes: ['.svelte'],
 					runes: [true]
 				}
@@ -171,7 +171,7 @@ describe('shouldRun', () => {
 		assert.strictEqual(
 			shouldRun(actualSvelte5, [
 				{
-					svelteVersions: [5],
+					svelteVersions: ['5'],
 					fileTypes: ['.svelte'],
 					runes: [false]
 				}
@@ -184,7 +184,7 @@ describe('shouldRun', () => {
 		assert.strictEqual(
 			shouldRun(actualSvelte5Script, [
 				{
-					svelteVersions: [5],
+					svelteVersions: ['5'],
 					fileTypes: ['.svelte.[js|ts]'],
 					runes: [true]
 				}
@@ -197,7 +197,7 @@ describe('shouldRun', () => {
 		assert.strictEqual(
 			shouldRun(actualSvelteKit, [
 				{
-					svelteKitVersions: [2],
+					svelteKitVersions: ['2'],
 					svelteKitFileTypes: ['+page.svelte']
 				}
 			]),
@@ -220,7 +220,7 @@ describe('shouldRun', () => {
 		assert.strictEqual(
 			shouldRun(actualSvelteKit, [
 				{
-					svelteKitVersions: [2],
+					svelteKitVersions: ['2'],
 					svelteKitFileTypes: [null]
 				}
 			]),
@@ -232,7 +232,7 @@ describe('shouldRun', () => {
 		assert.strictEqual(
 			shouldRun(actualSvelteKitNotRoute, [
 				{
-					svelteKitVersions: [2],
+					svelteKitVersions: ['2'],
 					svelteKitFileTypes: [null]
 				}
 			]),
@@ -244,7 +244,7 @@ describe('shouldRun', () => {
 		assert.strictEqual(
 			shouldRun(actualSvelteKitNotRoute, [
 				{
-					svelteKitVersions: [2],
+					svelteKitVersions: ['2'],
 					svelteKitFileTypes: ['+page.svelte']
 				}
 			]),