Skip to content

Commit 39590b6

Browse files
committed
[AArch64][GlobalISel] Fix legalizer crash trying to legalize <16 x i32> = G_BITCAST i512
Trying to do fewerElements on this results in an assert. rdar://126373053 (cherry picked from commit eb3030a)
1 parent 2ed642f commit 39590b6

File tree

2 files changed

+53
-0
lines changed

2 files changed

+53
-0
lines changed

llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -760,6 +760,9 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST)
760760
.legalForCartesianProduct({s32, v2s16, v4s8})
761761
.legalForCartesianProduct({s64, v8s8, v4s16, v2s32})
762762
.legalForCartesianProduct({s128, v16s8, v8s16, v4s32, v2s64, v2p0})
763+
.lowerIf([=](const LegalityQuery &Query) {
764+
return Query.Types[0].isVector() != Query.Types[1].isVector();
765+
})
763766
.moreElementsToNextPow2(0)
764767
.clampNumElements(0, v8s8, v16s8)
765768
.clampNumElements(0, v4s16, v8s16)
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 4
2+
# RUN: llc -mtriple=aarch64 -run-pass=legalizer -global-isel-abort=1 %s -o - | FileCheck %s
3+
---
4+
name: scalar_to_oversize_vector
5+
tracksRegLiveness: true
6+
body: |
7+
; CHECK-LABEL: name: scalar_to_oversize_vector
8+
; CHECK: bb.0:
9+
; CHECK-NEXT: successors: %bb.1(0x80000000)
10+
; CHECK-NEXT: {{ $}}
11+
; CHECK-NEXT: G_BR %bb.1
12+
; CHECK-NEXT: {{ $}}
13+
; CHECK-NEXT: bb.1:
14+
; CHECK-NEXT: successors: %bb.1(0x80000000)
15+
; CHECK-NEXT: {{ $}}
16+
; CHECK-NEXT: [[C:%[0-9]+]]:_(s64) = G_CONSTANT i64 0
17+
; CHECK-NEXT: [[UV:%[0-9]+]]:_(s32), [[UV1:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[C]](s64)
18+
; CHECK-NEXT: [[UV2:%[0-9]+]]:_(s32), [[UV3:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[C]](s64)
19+
; CHECK-NEXT: [[UV4:%[0-9]+]]:_(s32), [[UV5:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[C]](s64)
20+
; CHECK-NEXT: [[UV6:%[0-9]+]]:_(s32), [[UV7:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[C]](s64)
21+
; CHECK-NEXT: [[UV8:%[0-9]+]]:_(s32), [[UV9:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[C]](s64)
22+
; CHECK-NEXT: [[UV10:%[0-9]+]]:_(s32), [[UV11:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[C]](s64)
23+
; CHECK-NEXT: [[UV12:%[0-9]+]]:_(s32), [[UV13:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[C]](s64)
24+
; CHECK-NEXT: [[UV14:%[0-9]+]]:_(s32), [[UV15:%[0-9]+]]:_(s32) = G_UNMERGE_VALUES [[C]](s64)
25+
; CHECK-NEXT: [[BUILD_VECTOR:%[0-9]+]]:_(<4 x s32>) = G_BUILD_VECTOR [[UV]](s32), [[UV1]](s32), [[UV2]](s32), [[UV3]](s32)
26+
; CHECK-NEXT: [[BUILD_VECTOR1:%[0-9]+]]:_(<4 x s32>) = G_BUILD_VECTOR [[UV4]](s32), [[UV5]](s32), [[UV6]](s32), [[UV7]](s32)
27+
; CHECK-NEXT: [[BUILD_VECTOR2:%[0-9]+]]:_(<4 x s32>) = G_BUILD_VECTOR [[UV8]](s32), [[UV9]](s32), [[UV10]](s32), [[UV11]](s32)
28+
; CHECK-NEXT: [[BUILD_VECTOR3:%[0-9]+]]:_(<4 x s32>) = G_BUILD_VECTOR [[UV12]](s32), [[UV13]](s32), [[UV14]](s32), [[UV15]](s32)
29+
; CHECK-NEXT: [[C1:%[0-9]+]]:_(p0) = G_CONSTANT i64 0
30+
; CHECK-NEXT: G_STORE [[BUILD_VECTOR]](<4 x s32>), [[C1]](p0) :: (store (<4 x s32>), align 64)
31+
; CHECK-NEXT: [[C2:%[0-9]+]]:_(p0) = G_CONSTANT i64 16
32+
; CHECK-NEXT: G_STORE [[BUILD_VECTOR1]](<4 x s32>), [[C2]](p0) :: (store (<4 x s32>) into unknown-address + 16)
33+
; CHECK-NEXT: [[C3:%[0-9]+]]:_(p0) = G_CONSTANT i64 32
34+
; CHECK-NEXT: G_STORE [[BUILD_VECTOR2]](<4 x s32>), [[C3]](p0) :: (store (<4 x s32>) into unknown-address + 32, align 32)
35+
; CHECK-NEXT: [[C4:%[0-9]+]]:_(p0) = G_CONSTANT i64 48
36+
; CHECK-NEXT: G_STORE [[BUILD_VECTOR3]](<4 x s32>), [[C4]](p0) :: (store (<4 x s32>) into unknown-address + 48)
37+
; CHECK-NEXT: G_BR %bb.1
38+
bb.1:
39+
%0:_(s512) = G_CONSTANT i512 0
40+
%2:_(p0) = G_CONSTANT i64 0
41+
G_BR %bb.2
42+
43+
bb.2:
44+
%4:_(s512) = G_CONSTANT i512 0
45+
%1:_(<16 x s32>) = G_BITCAST %4(s512)
46+
%3:_(p0) = G_CONSTANT i64 0
47+
G_STORE %1(<16 x s32>), %3(p0) :: (store (<16 x s32>))
48+
G_BR %bb.2
49+
50+
...

0 commit comments

Comments
 (0)