Skip to content

Commit 3ec0b90

Browse files
usama54321usama54321
committed
Revert "[asan] Default to -fsanitize-address-use-odr-indicator for non-Windows"
This reverts commit 1ada819. The commit broke a few projects where tapi throws undefined symbol errors for the ODR symbols added by asan. This is a temporary revert until a fix is made. rdar://109471988
1 parent f2d74ad commit 3ec0b90

File tree

14 files changed

+46
-51
lines changed

14 files changed

+46
-51
lines changed

‎clang/include/clang/Driver/Options.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1895,7 +1895,7 @@ defm sanitize_address_globals_dead_stripping : BoolOption<"f", "sanitize-address
18951895
NegFlag<SetFalse, [], "Disable linker dead stripping of globals in AddressSanitizer">>,
18961896
Group<f_clang_Group>;
18971897
defm sanitize_address_use_odr_indicator : BoolOption<"f", "sanitize-address-use-odr-indicator",
1898-
CodeGenOpts<"SanitizeAddressUseOdrIndicator">, DefaultTrue,
1898+
CodeGenOpts<"SanitizeAddressUseOdrIndicator">, DefaultFalse,
18991899
PosFlag<SetTrue, [], "Enable ODR indicator globals to avoid false ODR violation"
19001900
" reports in partially sanitized programs at the cost of an increase in binary size">,
19011901
NegFlag<SetFalse, [], "Disable ODR indicator globals">>,

‎clang/lib/Driver/SanitizerArgs.cpp

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -937,14 +937,10 @@ SanitizerArgs::SanitizerArgs(const ToolChain &TC,
937937
!TC.getTriple().isOSBinFormatELF() || TC.getTriple().isOSFuchsia() ||
938938
TC.getTriple().isPS());
939939

940-
// Enable ODR indicators which allow better handling of mixed instrumented
941-
// and uninstrumented globals. Disable them for Windows where weak odr
942-
// indicators (.weak.__odr_asan_gen*) may cause multiple definition linker
943-
// errors in the absence of -lldmingw.
944940
AsanUseOdrIndicator =
945941
Args.hasFlag(options::OPT_fsanitize_address_use_odr_indicator,
946942
options::OPT_fno_sanitize_address_use_odr_indicator,
947-
!TC.getTriple().isOSWindows());
943+
AsanUseOdrIndicator);
948944

949945
if (AllAddedKinds & SanitizerKind::PointerCompare & ~AllRemove) {
950946
AsanInvalidPointerCmp = true;
@@ -1266,8 +1262,8 @@ void SanitizerArgs::addArgs(const ToolChain &TC, const llvm::opt::ArgList &Args,
12661262
if (AsanGlobalsDeadStripping)
12671263
CmdArgs.push_back("-fsanitize-address-globals-dead-stripping");
12681264

1269-
if (!AsanUseOdrIndicator)
1270-
CmdArgs.push_back("-fno-sanitize-address-use-odr-indicator");
1265+
if (AsanUseOdrIndicator)
1266+
CmdArgs.push_back("-fsanitize-address-use-odr-indicator");
12711267

12721268
if (AsanInvalidPointerCmp) {
12731269
CmdArgs.push_back("-mllvm");

‎clang/test/CodeGen/asan-globals-odr.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
// RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - -triple x86_64-linux %s | FileCheck %s --check-prefixes=CHECK,INDICATOR1,GLOB_ALIAS_INDICATOR,ALIAS1
1+
// RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - -triple x86_64-linux %s | FileCheck %s --check-prefixes=CHECK,INDICATOR0,GLOB_VAR,ALIAS0
2+
// RUN: %clang_cc1 -fsanitize=address -fsanitize-address-use-odr-indicator -emit-llvm -o - -triple x86_64-linux %s | FileCheck %s --check-prefixes=CHECK,INDICATOR1,GLOB_ALIAS_INDICATOR,ALIAS1
23
// RUN: %clang_cc1 -fsanitize=address -fno-sanitize-address-use-odr-indicator -emit-llvm -o - -triple x86_64-linux %s | FileCheck %s --check-prefixes=CHECK,INDICATOR0,GLOB_VAR,ALIAS0
34
// RUN: %clang_cc1 -fsanitize=address -fno-sanitize-address-use-odr-indicator -fsanitize-address-use-odr-indicator -emit-llvm -o - -triple x86_64-linux %s | FileCheck %s --check-prefixes=CHECK,INDICATOR1,GLOB_ALIAS_INDICATOR,ALIAS1
45
// RUN: %clang_cc1 -fsanitize=address -fsanitize-address-use-odr-indicator -fno-sanitize-address-use-odr-indicator -emit-llvm -o - -triple x86_64-linux %s | FileCheck %s --check-prefixes=CHECK,INDICATOR0,GLOB_VAR,ALIAS0
56

67
// No alias on Windows but indicators should work.
7-
// RUN: %clang_cc1 -fsanitize=address -fno-sanitize-address-use-odr-indicator -emit-llvm -o - -triple x86_64-windows-msvc %s | FileCheck %s --check-prefixes=CHECK,GLOB_VAR,ALIAS0
8-
// RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - -triple x86_64-windows-msvc %s | FileCheck %s --check-prefixes=CHECK,INDICATOR1,GLOB_VAR_INDICATOR,ALIAS0
8+
// RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - -triple x86_64-windows-msvc %s | FileCheck %s --check-prefixes=CHECK,GLOB_VAR,ALIAS0
9+
// RUN: %clang_cc1 -fsanitize=address -fsanitize-address-use-odr-indicator -emit-llvm -o - -triple x86_64-windows-msvc %s | FileCheck %s --check-prefixes=CHECK,INDICATOR1,GLOB_VAR_INDICATOR,ALIAS0
910

1011
int global;
1112

‎clang/test/CodeGen/asan-static-odr.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
// RUN: %clang_cc1 -fsanitize=address -fno-sanitize-address-use-odr-indicator -emit-llvm -o - -triple x86_64-linux %s | FileCheck %s
1+
// RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - -triple x86_64-linux %s | FileCheck %s
22

33
// No alias on Windows but indicators should work.
4-
// RUN: %clang_cc1 -fsanitize=address -fno-sanitize-address-use-odr-indicator -emit-llvm -o - -triple x86_64-windows-msvc %s | FileCheck %s
4+
// RUN: %clang_cc1 -fsanitize=address -emit-llvm -o - -triple x86_64-windows-msvc %s | FileCheck %s
55

66
static int global;
77

‎clang/test/Driver/fsanitize.c

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -263,18 +263,23 @@
263263
// RUN: FileCheck %s --check-prefix=CHECK-NO-CHECK-ASAN-CALLBACK
264264
// CHECK-NO-CHECK-ASAN-CALLBACK-NOT: "-mllvm" "-asan-instrumentation-with-call-threshold=0"
265265

266-
// RUN: %clang --target=x86_64-linux-gnu -fsanitize=address %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR
267-
// RUN: %clang_cl --target=x86_64-windows -fsanitize=address -### -- %s 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR-OFF
268-
// CHECK-ASAN-ODR-INDICATOR-NOT: "-fsanitize-address-use-odr-indicator"
266+
// RUN: %clang --target=x86_64-linux-gnu -fsanitize=address -fsanitize-address-use-odr-indicator %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR
267+
// RUN: %clang_cl --target=x86_64-windows -fsanitize=address -fsanitize-address-use-odr-indicator -### -- %s 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR
268+
// CHECK-ASAN-ODR-INDICATOR: -cc1{{.*}}-fsanitize-address-use-odr-indicator
269269

270270
// RUN: %clang --target=x86_64-linux-gnu -fsanitize=address -fno-sanitize-address-use-odr-indicator %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR-OFF
271271
// RUN: %clang_cl --target=x86_64-windows -fsanitize=address -fno-sanitize-address-use-odr-indicator -### -- %s 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR-OFF
272-
// CHECK-ASAN-ODR-INDICATOR-OFF: "-cc1" {{.*}} "-fno-sanitize-address-use-odr-indicator"
272+
// CHECK-ASAN-ODR-INDICATOR-OFF-NOT: -cc1{{.*}}address-generate-odr-globals
273273

274-
// RUN: %clang --target=x86_64-linux-gnu -fsanitize=address -fno-sanitize-address-use-odr-indicator -fsanitize-address-use-odr-indicator %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR
275-
// RUN: %clang_cl --target=x86_64-windows -fsanitize=address -fno-sanitize-address-use-odr-indicator -fsanitize-address-use-odr-indicator -### -- %s 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR
274+
// RUN: %clang --target=x86_64-linux-gnu -fsanitize=address -fno-sanitize-address-use-odr-indicator -fsanitize-address-use-odr-indicator %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR-BOTH
275+
// RUN: %clang_cl --target=x86_64-windows -fsanitize=address -fno-sanitize-address-use-odr-indicator -fsanitize-address-use-odr-indicator -### -- %s 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR-BOTH
276+
// CHECK-ASAN-ODR-INDICATOR-BOTH: -cc1{{.*}}-fsanitize-address-use-odr-indicator
276277

277-
// RUN: %clang --target=x86_64-linux-gnu -fsanitize=address -fsanitize-address-use-odr-indicator -fno-sanitize-address-use-odr-indicator %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR-OFF
278+
// RUN: %clang --target=x86_64-linux-gnu -fsanitize=address -fsanitize-address-use-odr-indicator -fno-sanitize-address-use-odr-indicator %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-ODR-INDICATOR-BOTH-OFF
279+
// CHECK-ASAN-ODR-INDICATOR-BOTH-OFF-NOT: -cc1{{.*}}address-generate-odr-globals
280+
281+
// RUN: %clang --target=x86_64-linux-gnu -fsanitize=address %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ASAN-WITHOUT-ODR-INDICATOR
282+
// CHECK-ASAN-WITHOUT-ODR-INDICATOR-NOT: -cc1{{.*}}address-generate-odr-globals
278283

279284
// RUN: %clang --target=x86_64-linux-gnu -fsanitize-memory-track-origins -pie %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ONLY-TRACK-ORIGINS
280285
// CHECK-ONLY-TRACK-ORIGINS: warning: argument unused during compilation: '-fsanitize-memory-track-origins'

‎compiler-rt/test/asan/TestCases/Linux/odr-violation.cpp

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,16 @@
66
// We use fast_unwind_on_malloc=0 to have full unwinding even w/o frame
77
// pointers. This setting is not on by default because it's too expensive.
88
//
9-
// Note, -asan-use-private-alias=1 -asan-use-odr-indicator=1 is the default.
10-
// -fno-sanitize-address-use-odr-indicator turns off both.
11-
//
129
// Different size: detect a bug if detect_odr_violation>=1
13-
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared -fno-sanitize-address-use-odr-indicator %s -o %dynamiclib
14-
// RUN: %clangxx_asan -g -fno-sanitize-address-use-odr-indicator %s %ld_flags_rpath_exe -o %t-ODR-EXE
10+
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared %s -o %dynamiclib
11+
// RUN: %clangxx_asan -g %s %ld_flags_rpath_exe -o %t-ODR-EXE
1512
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=1 not %run %t-ODR-EXE 2>&1 | FileCheck %s
1613
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=2 not %run %t-ODR-EXE 2>&1 | FileCheck %s
1714
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=0 %run %t-ODR-EXE 2>&1 | FileCheck %s --check-prefix=DISABLED
1815
// RUN: %env_asan_opts=fast_unwind_on_malloc=0 not %run %t-ODR-EXE 2>&1 | FileCheck %s
1916
//
2017
// Same size: report a bug only if detect_odr_violation>=2.
21-
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared -fno-sanitize-address-use-odr-indicator %s -o %dynamiclib -DSZ=100
18+
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared %s -o %dynamiclib -DSZ=100
2219
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=1 %run %t-ODR-EXE 2>&1 | FileCheck %s --check-prefix=DISABLED
2320
// RUN: %env_asan_opts=fast_unwind_on_malloc=0:detect_odr_violation=2 not %run %t-ODR-EXE 2>&1 | FileCheck %s
2421
// RUN: %env_asan_opts=fast_unwind_on_malloc=0 not %run %t-ODR-EXE 2>&1 | FileCheck %s
@@ -29,13 +26,13 @@
2926
// RUN: rm -f %t.supp
3027
//
3128
// Use private aliases for global variables without indicator symbol.
32-
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared -mllvm -asan-use-odr-indicator=0 %s -o %dynamiclib -DSZ=100
33-
// RUN: %clangxx_asan -g -mllvm -asan-use-odr-indicator=0 %s %ld_flags_rpath_exe -o %t-ODR-EXE
29+
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared -mllvm -asan-use-private-alias %s -o %dynamiclib -DSZ=100
30+
// RUN: %clangxx_asan -g -mllvm -asan-use-private-alias %s %ld_flags_rpath_exe -o %t-ODR-EXE
3431
// RUN: %env_asan_opts=fast_unwind_on_malloc=0 %run %t-ODR-EXE 2>&1 | FileCheck %s --check-prefix=DISABLED
3532

3633
// Use private aliases for global variables: use indicator symbol to detect ODR violation.
37-
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared %s -o %dynamiclib -DSZ=100
38-
// RUN: %clangxx_asan -g %s %ld_flags_rpath_exe -o %t-ODR-EXE
34+
// RUN: %clangxx_asan -g -DBUILD_SO=1 -fPIC -shared -mllvm -asan-use-private-alias -mllvm -asan-use-odr-indicator %s -o %dynamiclib -DSZ=100
35+
// RUN: %clangxx_asan -g -mllvm -asan-use-private-alias -mllvm -asan-use-odr-indicator %s %ld_flags_rpath_exe -o %t-ODR-EXE
3936
// RUN: %env_asan_opts=fast_unwind_on_malloc=0 not %run %t-ODR-EXE 2>&1 | FileCheck %s
4037

4138
// Same as above but with clang switches.

‎compiler-rt/test/asan/TestCases/Linux/odr_indicators.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %clangxx_asan -fno-sanitize-address-use-odr-indicator -fPIC %s -o %t
1+
// RUN: %clangxx_asan -fPIC %s -o %t
22
// RUN: %env_asan_opts=report_globals=2 %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK,INDICATOR0
33

44
// RUN: %clangxx_asan -fsanitize-address-use-odr-indicator -fPIC %s -o %t

‎llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ struct AddressSanitizerOptions {
3636
class AddressSanitizerPass : public PassInfoMixin<AddressSanitizerPass> {
3737
public:
3838
AddressSanitizerPass(const AddressSanitizerOptions &Options,
39-
bool UseGlobalGC = true, bool UseOdrIndicator = true,
39+
bool UseGlobalGC = true, bool UseOdrIndicator = false,
4040
AsanDtorKind DestructorKind = AsanDtorKind::Global,
4141
AsanCtorKind ConstructorKind = AsanCtorKind::Global);
4242
PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);

‎llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -404,12 +404,12 @@ static cl::opt<uint32_t> ClForceExperiment(
404404
static cl::opt<bool>
405405
ClUsePrivateAlias("asan-use-private-alias",
406406
cl::desc("Use private aliases for global variables"),
407-
cl::Hidden, cl::init(true));
407+
cl::Hidden, cl::init(false));
408408

409409
static cl::opt<bool>
410410
ClUseOdrIndicator("asan-use-odr-indicator",
411411
cl::desc("Use odr indicators to improve ODR reporting"),
412-
cl::Hidden, cl::init(true));
412+
cl::Hidden, cl::init(false));
413413

414414
static cl::opt<bool>
415415
ClUseGlobalsGC("asan-globals-live-support",
@@ -778,20 +778,16 @@ class ModuleAddressSanitizer {
778778
public:
779779
ModuleAddressSanitizer(Module &M, bool CompileKernel = false,
780780
bool Recover = false, bool UseGlobalsGC = true,
781-
bool UseOdrIndicator = true,
781+
bool UseOdrIndicator = false,
782782
AsanDtorKind DestructorKind = AsanDtorKind::Global,
783783
AsanCtorKind ConstructorKind = AsanCtorKind::Global)
784784
: CompileKernel(ClEnableKasan.getNumOccurrences() > 0 ? ClEnableKasan
785785
: CompileKernel),
786786
Recover(ClRecover.getNumOccurrences() > 0 ? ClRecover : Recover),
787787
UseGlobalsGC(UseGlobalsGC && ClUseGlobalsGC && !this->CompileKernel),
788788
// Enable aliases as they should have no downside with ODR indicators.
789-
UsePrivateAlias(ClUsePrivateAlias.getNumOccurrences() > 0
790-
? ClUsePrivateAlias
791-
: UseOdrIndicator),
792-
UseOdrIndicator(ClUseOdrIndicator.getNumOccurrences() > 0
793-
? ClUseOdrIndicator
794-
: UseOdrIndicator),
789+
UsePrivateAlias(UseOdrIndicator || ClUsePrivateAlias),
790+
UseOdrIndicator(UseOdrIndicator || ClUseOdrIndicator),
795791
// Not a typo: ClWithComdat is almost completely pointless without
796792
// ClUseGlobalsGC (because then it only works on modules without
797793
// globals, which are rare); it is a prerequisite for ClUseGlobalsGC;

‎llvm/test/Instrumentation/AddressSanitizer/global_metadata.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ target triple = "x86_64-unknown-linux-gnu"
1616

1717
; Check that globals were instrumented:
1818

19-
; CHECK: @global = global { i32, [28 x i8] } zeroinitializer, comdat, align 32
20-
; CHECK: @.str = internal constant { [14 x i8], [18 x i8] } { [14 x i8] c"Hello, world!\00", [18 x i8] zeroinitializer }, comdat({{.*}}), align 32
19+
; CHECK: @global = global { i32, [28 x i8] } zeroinitializer, align 32
20+
; CHECK: @.str = internal constant { [14 x i8], [18 x i8] } { [14 x i8] c"Hello, world!\00", [18 x i8] zeroinitializer }, align 32
2121

2222
; Check emitted location descriptions:
2323
; CHECK: [[VARNAME:@___asan_gen_.[0-9]+]] = private unnamed_addr constant [7 x i8] c"global\00", align 1

‎llvm/test/Instrumentation/AddressSanitizer/global_with_comdat.ll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
; enabled as indicator symbols will cause link time odr violations.
66
; This is to fix PR 47925.
77
;
8-
; RUN: opt < %s -passes=asan -asan-globals-live-support=1 -asan-use-odr-indicator=0 -S | FileCheck %s --check-prefixes=CHECK,NOCOMDAT
8+
; RUN: opt < %s -passes=asan -asan-globals-live-support=1 -S | FileCheck %s --check-prefixes=CHECK,NOCOMDAT
99
; Check that enabling odr indicators enables comdat for globals.
10-
; RUN: opt < %s -passes=asan -asan-globals-live-support=1 -S | FileCheck %s --check-prefixes=CHECK,COMDAT
10+
; RUN: opt < %s -passes=asan -asan-globals-live-support=1 -asan-use-odr-indicator=1 -S | FileCheck %s --check-prefixes=CHECK,COMDAT
1111
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
1212
target triple = "x86_64-unknown-linux-gnu"
1313

@@ -43,8 +43,8 @@ target triple = "x86_64-unknown-linux-gnu"
4343

4444
; Check emitted location descriptions:
4545
; CHECK: [[VARNAME:@___asan_gen_.[0-9]+]] = private unnamed_addr constant [7 x i8] c"global\00", align 1
46-
; COMDAT: @__asan_global_global = {{.*}}i64 ptrtoint (ptr @__odr_asan_gen_global to i64){{.*}} section "asan_globals"{{.*}}, comdat($global), !associated
47-
; COMDAT: @__asan_global_.str = {{.*}}i64 ptrtoint (ptr @___asan_gen_ to i64){{.*}} section "asan_globals"{{.*}}, comdat($.str.{{.*}}), !associated
46+
; COMDAT: @__asan_global_global = {{.*}}i64 ptrtoint (ptr @global to i64){{.*}} section "asan_globals"{{.*}}, !associated
47+
; COMDAT: @__asan_global_.str = {{.*}}i64 ptrtoint (ptr @{{.str|1}} to i64){{.*}} section "asan_globals"{{.*}}, !associated
4848

4949
; The metadata has to be inserted to llvm.compiler.used to avoid being stripped
5050
; during LTO.

‎llvm/test/Instrumentation/AddressSanitizer/local_alias.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
; Defaults
2-
; RUN: opt < %s -passes=asan -S | FileCheck %s --check-prefixes=CHECK-ALIAS,CHECK-INDICATOR
2+
; RUN: opt < %s -passes=asan -S | FileCheck %s --check-prefixes=CHECK-NOALIAS,CHECK-NOINDICATOR
33

44
; {newPM,legacyPM} x {alias0,alias1} x {odr0,odr1}
55
; RUN: opt < %s -passes=asan -asan-use-private-alias=0 -asan-use-odr-indicator=0 -S | FileCheck %s --check-prefixes=CHECK-NOALIAS,CHECK-NOINDICATOR

‎llvm/test/Instrumentation/AddressSanitizer/odr-check-ignore.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
; RUN: opt < %s -passes=asan -asan-use-odr-indicator=0 -asan-use-private-alias=0 -S | FileCheck %s --check-prefix=NOALIAS
2-
; RUN: opt < %s -passes=asan -asan-use-odr-indicator=0 -asan-use-private-alias=1 -S | FileCheck %s --check-prefix=ALIAS
1+
; RUN: opt < %s -passes=asan -asan-use-private-alias=0 -S | FileCheck %s --check-prefix=NOALIAS
2+
; RUN: opt < %s -passes=asan -asan-use-private-alias=1 -S | FileCheck %s --check-prefix=ALIAS
33

44
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
55
target triple = "x86_64-unknown-linux-gnu"

‎llvm/test/Instrumentation/AddressSanitizer/win-string-literal.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
; RUN: opt < %s -passes=asan -asan-use-odr-indicator=0 -asan-use-private-alias=0 -S | FileCheck %s
1+
; RUN: opt < %s -passes=asan -S | FileCheck %s
22

33
; Generated like so:
44
; $ clang -S -emit-llvm -Xclang -disable-llvm-passes -fsanitize=address -O1 t.cpp -o t.ll

0 commit comments

Comments
 (0)