[-Wunsafe-buffer-usage] Restore be48c0d change lost in merge.

ahmedbougacha · ahmedbougacha · commit 4198e6195aa0 · 2025-05-02T16:14:20.000-07:00
The only actual change was somehow dropped in merges 4de73d1 and 47144fc. rdar://150485090
diff --git a/clang/lib/Analysis/UnsafeBufferUsage.cpp b/clang/lib/Analysis/UnsafeBufferUsage.cpp
@@ -1423,7 +1423,7 @@ static bool isNullTermPointer(const Expr *Ptr, ASTContext &Ctx) {
     const CXXMethodDecl *MD = MCE->getMethodDecl();
     const CXXRecordDecl *RD = MCE->getRecordDecl()->getCanonicalDecl();
 
-    if (MD && RD && RD->isInStdNamespace())
+    if (MD && RD && RD->isInStdNamespace() && MD->getIdentifier())
       if (MD->getName() == "c_str" && RD->getName() == "basic_string")
         return true;
   }

Original file line number	Diff line number	Diff line change
`@@ -1423,7 +1423,7 @@ static bool isNullTermPointer(const Expr *Ptr, ASTContext &Ctx) {`
`1423`	`1423`	`const CXXMethodDecl *MD = MCE->getMethodDecl();`
`1424`	`1424`	`const CXXRecordDecl *RD = MCE->getRecordDecl()->getCanonicalDecl();`
`1425`	`1425`
`1426`		`- if (MD && RD && RD->isInStdNamespace())`
	`1426`	`+ if (MD && RD && RD->isInStdNamespace() && MD->getIdentifier())`
`1427`	`1427`	`if (MD->getName() == "c_str" && RD->getName() == "basic_string")`
`1428`	`1428`	`return true;`
`1429`	`1429`	`}`