Skip to content

Commit 574685b

Browse files
committed
[lldb/Symbol] Use StringRef ctor to prevent incorrect overload
Use the StringRef constructor instead of toStringRef so we don't end up with the wrong overload (llvm::toStringRef(bool)). Fixes PR44736
1 parent 8fbc7fd commit 574685b

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

lldb/source/Symbol/TypeSystem.cpp

+8-8
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType language,
239239
}
240240
error = llvm::make_error<llvm::StringError>(
241241
"TypeSystem for language " +
242-
llvm::toStringRef(Language::GetNameForLanguageType(language)) +
242+
llvm::StringRef(Language::GetNameForLanguageType(language)) +
243243
" doesn't exist",
244244
llvm::inconvertibleErrorCode());
245245
return std::move(error);
@@ -256,7 +256,7 @@ TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType language,
256256
}
257257
error = llvm::make_error<llvm::StringError>(
258258
"TypeSystem for language " +
259-
llvm::toStringRef(Language::GetNameForLanguageType(language)) +
259+
llvm::StringRef(Language::GetNameForLanguageType(language)) +
260260
" doesn't exist",
261261
llvm::inconvertibleErrorCode());
262262
return std::move(error);
@@ -266,7 +266,7 @@ TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType language,
266266
if (!can_create) {
267267
error = llvm::make_error<llvm::StringError>(
268268
"Unable to find type system for language " +
269-
llvm::toStringRef(Language::GetNameForLanguageType(language)),
269+
llvm::StringRef(Language::GetNameForLanguageType(language)),
270270
llvm::inconvertibleErrorCode());
271271
} else {
272272
// Cache even if we get a shared pointer that contains a null type system
@@ -279,7 +279,7 @@ TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType language,
279279
}
280280
error = llvm::make_error<llvm::StringError>(
281281
"TypeSystem for language " +
282-
llvm::toStringRef(Language::GetNameForLanguageType(language)) +
282+
llvm::StringRef(Language::GetNameForLanguageType(language)) +
283283
" doesn't exist",
284284
llvm::inconvertibleErrorCode());
285285
}
@@ -308,7 +308,7 @@ TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType language,
308308
}
309309
error = llvm::make_error<llvm::StringError>(
310310
"TypeSystem for language " +
311-
llvm::toStringRef(Language::GetNameForLanguageType(language)) +
311+
llvm::StringRef(Language::GetNameForLanguageType(language)) +
312312
" doesn't exist",
313313
llvm::inconvertibleErrorCode());
314314
return std::move(error);
@@ -325,7 +325,7 @@ TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType language,
325325
}
326326
error = llvm::make_error<llvm::StringError>(
327327
"TypeSystem for language " +
328-
llvm::toStringRef(Language::GetNameForLanguageType(language)) +
328+
llvm::StringRef(Language::GetNameForLanguageType(language)) +
329329
" doesn't exist",
330330
llvm::inconvertibleErrorCode());
331331
return std::move(error);
@@ -335,7 +335,7 @@ TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType language,
335335
if (!can_create) {
336336
error = llvm::make_error<llvm::StringError>(
337337
"Unable to find type system for language " +
338-
llvm::toStringRef(Language::GetNameForLanguageType(language)),
338+
llvm::StringRef(Language::GetNameForLanguageType(language)),
339339
llvm::inconvertibleErrorCode());
340340
} else {
341341
// Cache even if we get a shared pointer that contains a null type system
@@ -348,7 +348,7 @@ TypeSystemMap::GetTypeSystemForLanguage(lldb::LanguageType language,
348348
}
349349
error = llvm::make_error<llvm::StringError>(
350350
"TypeSystem for language " +
351-
llvm::toStringRef(Language::GetNameForLanguageType(language)) +
351+
llvm::StringRef(Language::GetNameForLanguageType(language)) +
352352
" doesn't exist",
353353
llvm::inconvertibleErrorCode());
354354
}

0 commit comments

Comments
 (0)