Skip to content

Commit 9e61aae

Browse files
Temporarily remove the global min(a,b) and max(a,b) SIMD functions. (llvm#23960)
These are triggering a bad compile-time regression for some expressions; that's a bug that should be fixed, but we don't know how to fix it yet, so we'll need to remove these in the short-term, and possibly spell them differently in the medium term.
1 parent 93d383f commit 9e61aae

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

stdlib/public/core/SIMDVector.swift

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,15 +467,17 @@ extension SIMD where Scalar: Comparable {
467467
return lhs .> Self(repeating: rhs)
468468
}
469469

470+
/* Temporarily removed pending plan for Swift.min / Swift.max
470471
@_alwaysEmitIntoClient
471472
public mutating func clamp(lowerBound: Self, upperBound: Self) {
472473
self = self.clamped(lowerBound: lowerBound, upperBound: upperBound)
473474
}
474-
475+
475476
@_alwaysEmitIntoClient
476477
public func clamped(lowerBound: Self, upperBound: Self) -> Self {
477478
return Swift.min(upperBound, Swift.max(lowerBound, self))
478479
}
480+
*/
479481
}
480482

481483
extension SIMD where Scalar: FixedWidthInteger {
@@ -1341,6 +1343,10 @@ public func all<Storage>(_ mask: SIMDMask<Storage>) -> Bool {
13411343
return mask._storage.max() < 0
13421344
}
13431345

1346+
/*
1347+
Temporarily removed while we investigate compile-time regressions caused by
1348+
introducing these global functions.
1349+
13441350
/// The lanewise minimum of two vectors.
13451351
///
13461352
/// Each element of the result is the minimum of the corresponding elements
@@ -1397,3 +1403,4 @@ where V: SIMD, V.Scalar: FloatingPoint {
13971403
}
13981404
return result
13991405
}
1406+
*/

0 commit comments

Comments
 (0)