[AMDGPU] Fix warnings

kazutakahirata · kazutakahirata · commit ceaaa2b9ae34 · 2025-01-21T20:24:30.000-08:00
This patch fixes:

  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:2792:14: error: comparison of
  integers of different signs: 'unsigned int' and 'int'
  [-Werror,-Wsign-compare]

  llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:2797:14: error: comparison of
  integers of different signs: 'unsigned int' and 'int'
  [-Werror,-Wsign-compare]
diff --git a/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp b/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
@@ -2789,12 +2789,12 @@ bool SIInstrInfo::isLegalToSwap(const MachineInstr &MI, unsigned OpIdx0,
       return false;
   }
 
-  if (OpIdx1 != Src0Idx && MO0->isReg()) {
+  if ((int)OpIdx1 != Src0Idx && MO0->isReg()) {
     if (!DefinedRC1)
       return OpInfo1.OperandType == MCOI::OPERAND_UNKNOWN;
     return isLegalRegOperand(MI, OpIdx1, *MO0);
   }
-  if (OpIdx0 != Src0Idx && MO1->isReg()) {
+  if ((int)OpIdx0 != Src0Idx && MO1->isReg()) {
     if (!DefinedRC0)
       return OpInfo0.OperandType == MCOI::OPERAND_UNKNOWN;
     return isLegalRegOperand(MI, OpIdx0, *MO1);

Original file line number	Diff line number	Diff line change
`@@ -2789,12 +2789,12 @@ bool SIInstrInfo::isLegalToSwap(const MachineInstr &MI, unsigned OpIdx0,`
`2789`	`2789`	`return false;`
`2790`	`2790`	`}`
`2791`	`2791`
`2792`		`- if (OpIdx1 != Src0Idx && MO0->isReg()) {`
	`2792`	`+ if ((int)OpIdx1 != Src0Idx && MO0->isReg()) {`
`2793`	`2793`	`if (!DefinedRC1)`
`2794`	`2794`	`return OpInfo1.OperandType == MCOI::OPERAND_UNKNOWN;`
`2795`	`2795`	`return isLegalRegOperand(MI, OpIdx1, *MO0);`
`2796`	`2796`	`}`
`2797`		`- if (OpIdx0 != Src0Idx && MO1->isReg()) {`
	`2797`	`+ if ((int)OpIdx0 != Src0Idx && MO1->isReg()) {`
`2798`	`2798`	`if (!DefinedRC0)`
`2799`	`2799`	`return OpInfo0.OperandType == MCOI::OPERAND_UNKNOWN;`
`2800`	`2800`	`return isLegalRegOperand(MI, OpIdx0, *MO1);`