Skip to content

Commit e0c7170

Browse files
author
git apple-llvm automerger
committed
Merge commit 'd52b36e354e9' from llvm.org/master into apple/master
2 parents 962bca8 + d52b36e commit e0c7170

File tree

4 files changed

+9
-15
lines changed

4 files changed

+9
-15
lines changed

lldb/CMakeLists.txt

+5-9
Original file line numberDiff line numberDiff line change
@@ -91,22 +91,18 @@ if(LLDB_INCLUDE_TESTS)
9191
set(LLDB_DEFAULT_TEST_FILECHECK "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/FileCheck${CMAKE_EXECUTABLE_SUFFIX}")
9292

9393
if (TARGET clang)
94-
set(LLDB_DEFAULT_TEST_C_COMPILER "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/clang${CMAKE_EXECUTABLE_SUFFIX}")
95-
set(LLDB_DEFAULT_TEST_CXX_COMPILER "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/clang++${CMAKE_EXECUTABLE_SUFFIX}")
94+
set(LLDB_DEFAULT_TEST_COMPILER "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/clang${CMAKE_EXECUTABLE_SUFFIX}")
9695
else()
97-
set(LLDB_DEFAULT_TEST_C_COMPILER "")
98-
set(LLDB_DEFAULT_TEST_CXX_COMPILER "")
96+
set(LLDB_DEFAULT_TEST_COMPILER "")
9997
endif()
10098

10199
set(LLDB_TEST_EXECUTABLE "${LLDB_DEFAULT_TEST_EXECUTABLE}" CACHE PATH "lldb executable used for testing")
102-
set(LLDB_TEST_C_COMPILER "${LLDB_DEFAULT_TEST_C_COMPILER}" CACHE PATH "C Compiler to use for building LLDB test inferiors")
103-
set(LLDB_TEST_CXX_COMPILER "${LLDB_DEFAULT_TEST_CXX_COMPILER}" CACHE PATH "C++ Compiler to use for building LLDB test inferiors")
100+
set(LLDB_TEST_COMPILER "${LLDB_DEFAULT_TEST_COMPILER}" CACHE PATH "C Compiler to use for building LLDB test inferiors")
104101
set(LLDB_TEST_DSYMUTIL "${LLDB_DEFAULT_TEST_DSYMUTIL}" CACHE PATH "dsymutil used for generating dSYM bundles")
105102
set(LLDB_TEST_FILECHECK "${LLDB_DEFAULT_TEST_FILECHECK}" CACHE PATH "FileCheck used for testing purposes")
106103

107-
if (("${LLDB_TEST_C_COMPILER}" STREQUAL "") OR
108-
("${LLDB_TEST_CXX_COMPILER}" STREQUAL ""))
109-
message(FATAL_ERROR "LLDB test compilers not specified. Tests will not run.")
104+
if ("${LLDB_TEST_COMPILER}" STREQUAL "")
105+
message(FATAL_ERROR "LLDB test compiler not specified. Tests will not run.")
110106
endif()
111107

112108
add_custom_target(lldb-test-deps)

lldb/docs/resources/build.rst

+2-3
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,7 @@ suite.
186186
::
187187

188188
> cmake -G Ninja \
189-
-DLLDB_TEST_C_COMPILER=<path to C compiler> \
190-
-DLLDB_TEST_CXX_COMPILER=<path to C++ compiler> \
189+
-DLLDB_TEST_COMPILER=<path to C compiler> \
191190
<path to root of llvm source tree>
192191

193192
It is strongly recommend to use a release build for the compiler to speed up
@@ -227,7 +226,7 @@ Sample command line:
227226
> cmake -G Ninja^
228227
-DLLDB_TEST_DEBUG_TEST_CRASHES=1^
229228
-DPYTHON_HOME=C:\Python35^
230-
-DLLDB_TEST_C_COMPILER=d:\src\llvmbuild\ninja_release\bin\clang.exe^
229+
-DLLDB_TEST_COMPILER=d:\src\llvmbuild\ninja_release\bin\clang.exe^
231230
<path to root of llvm source tree>
232231

233232

lldb/docs/resources/test.rst

+1-2
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ target.
4242

4343
By default, the ``check-lldb`` target builds the test programs with the same
4444
compiler that was used to build LLDB. To build the tests with a different
45-
compiler, you can set the ``LLDB_TEST_C_COMPILER`` or the
46-
``LLDB_TEST_CXX_COMPILER`` CMake variables.
45+
compiler, you can set the ``LLDB_TEST_COMPILER`` CMake variable.
4746

4847
It is possible to customize the architecture of the test binaries and compiler
4948
used by appending ``-A`` and ``-C`` options respectively to the CMake variable

lldb/test/API/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ list(APPEND LLDB_TEST_COMMON_ARGS
4848
--executable ${LLDB_TEST_EXECUTABLE}
4949
--dsymutil ${LLDB_TEST_DSYMUTIL}
5050
--filecheck ${LLDB_TEST_FILECHECK}
51-
-C ${LLDB_TEST_C_COMPILER}
51+
--compiler ${LLDB_TEST_COMPILER}
5252
)
5353

5454
if ( CMAKE_SYSTEM_NAME MATCHES "Windows" )

0 commit comments

Comments
 (0)