Skip to content

Commit e14cfe2

Browse files
[AArch64] Consistent types and naming for AArch64 target features (NFC)
Differential Revision: https://reviews.llvm.org/D64415 Committed as obvious. llvm-svn: 366315
1 parent 8b7041a commit e14cfe2

File tree

2 files changed

+25
-24
lines changed

2 files changed

+25
-24
lines changed

clang/lib/Basic/Targets/AArch64.cpp

+17-17
Original file line numberDiff line numberDiff line change
@@ -199,13 +199,13 @@ void AArch64TargetInfo::getTargetDefines(const LangOptions &Opts,
199199
if (FPU & SveMode)
200200
Builder.defineMacro("__ARM_FEATURE_SVE", "1");
201201

202-
if (CRC)
202+
if (HasCRC)
203203
Builder.defineMacro("__ARM_FEATURE_CRC32", "1");
204204

205-
if (Crypto)
205+
if (HasCrypto)
206206
Builder.defineMacro("__ARM_FEATURE_CRYPTO", "1");
207207

208-
if (Unaligned)
208+
if (HasUnaligned)
209209
Builder.defineMacro("__ARM_FEATURE_UNALIGNED", "1");
210210

211211
if ((FPU & NeonMode) && HasFullFP16)
@@ -263,13 +263,13 @@ bool AArch64TargetInfo::hasFeature(StringRef Feature) const {
263263
bool AArch64TargetInfo::handleTargetFeatures(std::vector<std::string> &Features,
264264
DiagnosticsEngine &Diags) {
265265
FPU = FPUMode;
266-
CRC = 0;
267-
Crypto = 0;
268-
Unaligned = 1;
269-
HasFullFP16 = 0;
270-
HasDotProd = 0;
271-
HasFP16FML = 0;
272-
HasMTE = 0;
266+
HasCRC = false;
267+
HasCrypto = false;
268+
HasUnaligned = true;
269+
HasFullFP16 = false;
270+
HasDotProd = false;
271+
HasFP16FML = false;
272+
HasMTE = false;
273273
ArchKind = llvm::AArch64::ArchKind::ARMV8A;
274274

275275
for (const auto &Feature : Features) {
@@ -278,11 +278,11 @@ bool AArch64TargetInfo::handleTargetFeatures(std::vector<std::string> &Features,
278278
if (Feature == "+sve")
279279
FPU |= SveMode;
280280
if (Feature == "+crc")
281-
CRC = 1;
281+
HasCRC = true;
282282
if (Feature == "+crypto")
283-
Crypto = 1;
283+
HasCrypto = true;
284284
if (Feature == "+strict-align")
285-
Unaligned = 0;
285+
HasUnaligned = false;
286286
if (Feature == "+v8.1a")
287287
ArchKind = llvm::AArch64::ArchKind::ARMV8_1A;
288288
if (Feature == "+v8.2a")
@@ -294,13 +294,13 @@ bool AArch64TargetInfo::handleTargetFeatures(std::vector<std::string> &Features,
294294
if (Feature == "+v8.5a")
295295
ArchKind = llvm::AArch64::ArchKind::ARMV8_5A;
296296
if (Feature == "+fullfp16")
297-
HasFullFP16 = 1;
297+
HasFullFP16 = true;
298298
if (Feature == "+dotprod")
299-
HasDotProd = 1;
299+
HasDotProd = true;
300300
if (Feature == "+fp16fml")
301-
HasFP16FML = 1;
301+
HasFP16FML = true;
302302
if (Feature == "+mte")
303-
HasMTE = 1;
303+
HasMTE = true;
304304
}
305305

306306
setDataLayout();

clang/lib/Basic/Targets/AArch64.h

+8-7
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,14 @@ class LLVM_LIBRARY_VISIBILITY AArch64TargetInfo : public TargetInfo {
2828
enum FPUModeEnum { FPUMode, NeonMode = (1 << 0), SveMode = (1 << 1) };
2929

3030
unsigned FPU;
31-
unsigned CRC;
32-
unsigned Crypto;
33-
unsigned Unaligned;
34-
unsigned HasFullFP16;
35-
unsigned HasDotProd;
36-
unsigned HasFP16FML;
37-
unsigned HasMTE;
31+
bool HasCRC;
32+
bool HasCrypto;
33+
bool HasUnaligned;
34+
bool HasFullFP16;
35+
bool HasDotProd;
36+
bool HasFP16FML;
37+
bool HasMTE;
38+
3839
llvm::AArch64::ArchKind ArchKind;
3940

4041
static const Builtin::Info BuiltinInfo[];

0 commit comments

Comments
 (0)