Skip to content

Commit fa4e899

Browse files
committed
[AArch64] Make wfxt a full Extension (llvm#90987)
Before llvm#90987 WFxT did not have an AEK_WFXT, so it was assumed to be an FMV-only extension. However it also had a SubtargetFeature. This commit combines the two. This fixes an issue where -mattr=+wfxt was ignored, but has the side effect of allowing +wfxt as an option to -march.
1 parent 28767af commit fa4e899

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

llvm/lib/Target/AArch64/AArch64Features.td

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ def : FMVOnlyExtension<"FEAT_SVE_BF16", "sve-bf16", "+sve,+bf16,+fullfp16,+fp-ar
9090
def : FMVOnlyExtension<"FEAT_SVE_EBF16", "sve-ebf16", "+sve,+bf16,+fullfp16,+fp-armv8,+neon", 330>;
9191
def : FMVOnlyExtension<"FEAT_SVE_I8MM", "sve-i8mm", "+sve,+i8mm,+fullfp16,+fp-armv8,+neon", 340>;
9292
def : FMVOnlyExtension<"FEAT_SVE_PMULL128", "sve2-pmull128", "+sve2,+sve,+sve2-aes,+fullfp16,+fp-armv8,+neon", 390>;
93-
def : FMVOnlyExtension<"FEAT_WFXT", "wfxt", "+wfxt", 550>;
9493

9594

9695
// Each SubtargetFeature which corresponds to an Arm Architecture feature should
@@ -596,9 +595,9 @@ def FeatureMatMulFP64 : Extension<"f64mm", "MatMulFP64",
596595
def FeatureXS : SubtargetFeature<"xs", "HasXS",
597596
"true", "Enable Armv8.7-A limited-TLB-maintenance instruction (FEAT_XS)">;
598597

599-
// FIXME link with FMVExtension?
600-
def FeatureWFxT : SubtargetFeature<"wfxt", "HasWFxT",
601-
"true", "Enable Armv8.7-A WFET and WFIT instruction (FEAT_WFxT)">;
598+
def FeatureWFxT : Extension<"wfxt", "WFxT",
599+
"Enable Armv8.7-A WFET and WFIT instruction (FEAT_WFxT)", [],
600+
"FEAT_WFXT", "", 550>;
602601

603602
def FeatureHCX : SubtargetFeature<
604603
"hcx", "HasHCX", "true", "Enable Armv8.7-A HCRX_EL2 system register (FEAT_HCX)">;

0 commit comments

Comments
 (0)