Merge pull request #442 from swiftlang/rdar-145751834

[SE-0466] Add SWIFT_DEFAULT_ACTOR_ISOLATION build setting

Author: xedin

Sources/SWBUniversalPlatform/Specs/Swift.xcspec

@@ -569,7 +569,22 @@
                 Category = "Upcoming Features";
                 Description = "Enables strict concurrency checking to produce warnings for possible data races. This is always 'complete' when in the Swift 6 language mode and produces errors instead of warnings.";
             },
-
+            {
+                Name = "SWIFT_DEFAULT_ACTOR_ISOLATION";
+                Type = Enumeration;
+                Values = (
+                    nonisolated,
+                    MainActor
+                );
+                DefaultValue = "nonisolated";
+                CommandLineArgs = {
+                    nonisolated = ();
+                    MainActor = ( "-default-isolation=MainActor" );
+                };
+                DisplayName = "Default Actor Isolation";
+                Category = "Language";
+                Description = "Controls default actor isolation for unannotated code. When set to 'MainActor', `@MainActor` isolation will be inferred by default to mitigate false-positive data-race safety errors in sequential code.";
+            },
             {
                 Name = "SWIFT_STRICT_MEMORY_SAFETY";
                 Type = Boolean;

Tests/SWBTaskConstructionTests/SwiftTaskConstructionTests.swift

@@ -3528,6 +3528,94 @@ fileprivate struct SwiftTaskConstructionTests: CoreBasedTests {
         }
     }
 
+    @Test(.requireSDKs(.macOS))
+    func defaultIsolationFlag() async throws {
+        try await withTemporaryDirectory { tmpDir in
+            let srcRoot = tmpDir.join("srcroot")
+            let testProject = try await TestProject(
+                "ProjectName",
+                sourceRoot: srcRoot,
+                groupTree: TestGroup(
+                    "SomeFiles", path: "Sources",
+                    children: [
+                        TestFile("File1.swift"),
+                        TestFile("File2.swift"),
+                        TestFile("File3.swift"),
+                    ]),
+                targets: [
+                    TestStandardTarget(
+                        "Default",
+                        type: .framework,
+                        buildConfigurations: [
+                            TestBuildConfiguration("Debug", buildSettings: [
+                                "GENERATE_INFOPLIST_FILE": "YES",
+                                "PRODUCT_NAME": "$(TARGET_NAME)",
+                                "SWIFT_EXEC": swiftCompilerPath.str,
+                                "SWIFT_VERSION": "5.0",
+                            ]),
+                        ],
+                        buildPhases: [
+                            TestSourcesBuildPhase([
+                                TestBuildFile("File1.swift"),
+                            ]),
+                        ], dependencies: ["Nonisolated", "MainActor"]),
+                    TestStandardTarget(
+                        "Nonisolated",
+                        type: .framework,
+                        buildConfigurations: [
+                            TestBuildConfiguration("Debug", buildSettings: [
+                                "GENERATE_INFOPLIST_FILE": "YES",
+                                "PRODUCT_NAME": "$(TARGET_NAME)",
+                                "SWIFT_EXEC": swiftCompilerPath.str,
+                                "SWIFT_VERSION": "5.0",
+                                "SWIFT_DEFAULT_ACTOR_ISOLATION": "nonisolated",
+                            ]),
+                        ],
+                        buildPhases: [
+                            TestSourcesBuildPhase([
+                                TestBuildFile("File2.swift"),
+                            ]),
+                        ]),
+                    TestStandardTarget(
+                        "MainActor",
+                        type: .framework,
+                        buildConfigurations: [
+                            TestBuildConfiguration("Debug", buildSettings: [
+                                "GENERATE_INFOPLIST_FILE": "YES",
+                                "PRODUCT_NAME": "$(TARGET_NAME)",
+                                "SWIFT_EXEC": swiftCompilerPath.str,
+                                "SWIFT_VERSION": "5.0",
+                                "SWIFT_DEFAULT_ACTOR_ISOLATION": "MainActor",
+                            ]),
+                        ],
+                        buildPhases: [
+                            TestSourcesBuildPhase([
+                                TestBuildFile("File3.swift"),
+                            ]),
+                        ]),
+                ])
+
+            let tester = try await TaskConstructionTester(getCore(), testProject)
+            await tester.checkBuild(BuildParameters(action: .install, configuration: "Debug"), runDestination: .macOS) { results in
+                results.checkTarget("Default") { target in
+                    results.checkTask(.matchTarget(target), .matchRuleType("SwiftDriver Compilation")) { task in
+                        task.checkCommandLineNoMatch([.prefix("-default-isolation")])
+                    }
+                }
+                results.checkTarget("Nonisolated") { target in
+                    results.checkTask(.matchTarget(target), .matchRuleType("SwiftDriver Compilation")) { task in
+                        task.checkCommandLineNoMatch([.prefix("-default-isolation")])
+                    }
+                }
+                results.checkTarget("MainActor") { target in
+                    results.checkTask(.matchTarget(target), .matchRuleType("SwiftDriver Compilation")) { task in
+                        task.checkCommandLineContains(["-default-isolation=MainActor"])
+                    }
+                }
+            }
+        }
+    }
+
     // Test frontend flag -library-level inference from the INSTALL_PATH.
     @Test(.requireSDKs(.macOS))
     func libraryLevel() async throws {