Eliminate extra indirection

We only need to synchronize the lazy initialization; accesses either
succeed or don't already.

Author: natecook1000

Sources/_StringProcessing/Regex/Core.swift

@@ -85,19 +85,16 @@ extension Regex {
       init(_ value: MEProgram<String>) { self.value = value }
     }
 
-    private var _loweredProgramStorage: UnsafeMutablePointer<AnyObject?> = {
-      let pointer = UnsafeMutablePointer<AnyObject?>.allocate(capacity: 1)
-      pointer.initialize(to: nil)
-      return pointer
-    }()
+    /// Do not use directly - all accesses must go through `loweredProgram`.
+    private var _unsafeLoweredProgramStorage: AnyObject? = nil
 
     /// The program for execution with the matching engine.
     var loweredProgram: MEProgram<String> {
-      if let loweredObject = _stdlib_atomicLoadARCRef(object: _loweredProgramStorage) {
-        return (loweredObject as! ProgramBox).value
+      if let loweredObject = _unsafeLoweredProgramStorage as? ProgramBox {
+        return loweredObject.value
       }
       let lowered = try! Compiler(tree: tree).emit()
-      _stdlib_atomicInitializeARCRef(object: _loweredProgramStorage, desired: ProgramBox(lowered))
+      _stdlib_atomicInitializeARCRef(object: &_unsafeLoweredProgramStorage, desired: ProgramBox(lowered))
       return lowered
     }
 
@@ -108,13 +105,6 @@ extension Regex {
     init(tree: DSLTree) {
       self.tree = tree
     }
-    
-    deinit {
-      if _loweredProgramStorage.pointee != nil {
-        _loweredProgramStorage.deinitialize(count: 1)
-      }
-      _loweredProgramStorage.deallocate()
-    }
   }
 
   /// The set of matching options that applies to the start of this regex.