Allow (?)

This is accepted by PCRE, and forms an empty
option change sequence. We probably ought to warn
on it though as it's a no-op.

Author: hamishknight

Sources/_RegexParser/Regex/Parse/LexicalAnalysis.swift

@@ -846,6 +846,11 @@ extension Parser {
   ///                        | MatchingOption* '-' MatchingOption*
   ///
   mutating func lexMatchingOptionSequence() -> AST.MatchingOptionSequence? {
+    // PCRE accepts '(?)'
+    // TODO: This is a no-op, should we warn?
+    if peek() == ")" {
+      return .init(caretLoc: nil, adding: [], minusLoc: nil, removing: [])
+    }
     let caret = tryEatWithLoc("^")
 
     // TODO: Warn on duplicate options, and options appearing in both adding

Tests/RegexTests/ParseTests.swift

@@ -970,6 +970,9 @@ extension RegexTests {
               concat("a", atomicScriptRun("b"), "c"), unsupported: true)
 
     // Matching option changing groups.
+    parseTest("(?)", changeMatchingOptions(
+      matchingOptions()
+    ))
     parseTest("(?-)", changeMatchingOptions(
       matchingOptions()
     ))