You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: Evolution.md
+4-50Lines changed: 4 additions & 50 deletions
Original file line number
Diff line number
Diff line change
@@ -9,9 +9,9 @@ A group of core contributors and stakeholders form the _Foundation Workgroup_, w
9
9
*This section outlines the general process for features with a larger scope. For minor API proposals, please refer to the [Abbreviated review for minor proposals](#abbreviated-review-for-minor-proposals) section.*
10
10
11
11
***Consider the goal**: Before proposing a change, please consider how your idea fits into the goals and themes for the upcoming release.
12
-
***Socialize the idea**: Propose a rough sketch of the idea in the "pitches" section of the Swift forums, the problems it solves, what the solution looks like, etc., to gauge interest from the community.
12
+
***Socialize the idea**: Propose a rough sketch of the idea on the [Swift forums - Foundation project](https://forums.swift.org/c/related-projects/foundation/99), the problems it solves, what the solution looks like, etc., to gauge interest from the community. Please feel free to include "[Pitch]" in the title.
13
13
***Develop the proposal**: Expand the rough sketch into a complete proposal, using the [proposal template](Proposals/0000-template.md), and continue to refine the proposal on the forums. Prototyping an implementation and its uses along with the proposal is required because it helps ensure both technical feasibility of the proposal as well as validating that the proposal solves the problems it is meant to solve.
14
-
***Request a review**: Initiate a pull request to the swift-foundation repository to indicate to the workgroup that you would like the proposal to be reviewed. When the proposal is sufficiently detailed and clear, and addresses feedback from earlier discussions of the idea, the pull request will be accepted. The proposal will be assigned a proposal number as well as a Foundation Workgroup member to manage the review.
14
+
***Request a review**: Initiate a pull request to the swift-foundation repository to indicate to the workgroup that you would like the proposal to be reviewed. When the proposal is sufficiently detailed and clear, and addresses feedback from earlier discussions of the idea, the pull request will be accepted. The proposal will be assigned a proposal number as well as a Foundation Workgroup member to manage the review. This marks as the start of the review.
15
15
***Address feedback**: In general, and especially during the review period, be responsive to questions and feedback about the proposal.
16
16
17
17
### The review process
@@ -22,7 +22,7 @@ The review process for a particular proposal begins when a member of the Foundat
22
22
23
23
The review manager will work with the proposal authors to schedule the review. Reviews usually last a single week, but can run longer for particularly large or complex proposals.
24
24
25
-
When the scheduled review period arrives, the review manager will post the proposal to the Swift forums with the proposal title. To avoid delays, it is important that the proposal authors be available to answer questions, address feedback, and clarify their intent during the review period.
25
+
When the scheduled review period arrives, the review manager will post the proposal to the [Swift forums - Foundation Project](https://forums.swift.org/c/related-projects/foundation/99) with the proposal title. To avoid delays, it is important that the proposal authors be available to answer questions, address feedback, and clarify their intent during the review period.
26
26
27
27
After the review has completed, the Foundation Workgroup will make a decision on the proposal. The review manager is responsible for determining consensus among the Foundation Workgroup members, then reporting their decision to the proposal authors and forums. The review manager will update the proposal's state in the repository to reflect that decision.
28
28
@@ -31,53 +31,7 @@ After the review has completed, the Foundation Workgroup will make a decision on
31
31
Minor API enhancement ideas that have gained community interest through GitHub issues or forum threads may take a shorter review process. Examples include extending existing types with new functions or variables, or adding new `case` to `enum`. Instead of requiring both a pitch thread and a review, these changes can be proposed directly with a proposal document on a pitch thread. The workgroup has appointed an API champion (currently @itingliu) to oversee this process. Here's what you would do:
32
32
33
33
***Develop the proposal**: Prepare the proposal using the [proposal template](Proposals/0000-template.md) with a prototype.
34
-
***Request an abbreviated review**: Initiate a pull request to the swift-foundation repository to indicate to the workgroup that you would like the proposal to be reviewed. Meanwhile, post the pull request on the "pitches" section of the Swift forums. Upon seeing the pitch on the forum, a workgroup member will be assigned to manage the review.
34
+
***Request an abbreviated review**: Initiate a pull request to the swift-foundation repository to indicate to the workgroup that you would like the proposal to be reviewed. Meanwhile, post the content on the [Swift forums - Foundation project](https://forums.swift.org/c/related-projects/foundation/99). Upon seeing the pitch on the forum, a workgroup member will be assigned to manage the review. The review manager will comment in the pitch post if the proposal is deemed suitable for abbreviated review, and communicate the next steps on the pitch post.
35
35
***Address feedback**: Be responsive to questions and feedback and continue to refine the proposal as needed.
36
36
37
37
At the end of the review period, the review manager will accept the proposal if there is a broad agreement among workgroup members and the community.
38
-
39
-
40
-
### Appendix: Review Announcement Template
41
-
42
-
(Credit: This section is adapted from [Swift-Evolution's announcement template](https://github.com/apple/swift-evolution/blob/main/process.md#review-announcement))
43
-
44
-
When a proposal enters review, a new topic will be posted to the [Foundation project of the Swift forums](https://forums.swift.org/c/related-projects/foundation/) using the following template.
45
-
46
-
<details>
47
-
<summary> Template </summary>
48
-
49
-
---
50
-
Hello Swift community,
51
-
52
-
The review of [\<\<PROPOSAL NAME>>]\(\<\<LINK TO PROPOSAL>>) begins now and runs through \<\<REVIEW END DATE>>
53
-
54
-
Reviews are an important part of the Swift-Foundation evolution process. All review feedback should be either on this forum thread or, if you would like to keep your feedback private, directly to me as the review manager by \<\<CONTACT METHOD>>. When contacting the review manager directly, please include proposal name in the subject line.
55
-
56
-
57
-
##### Trying it out
58
-
59
-
If you'd like to try this proposal out, you can check out \<\<LINK TO IMPLEMENTATION>>.
60
-
61
-
##### What goes into a review?
62
-
63
-
The goal of the review process is to improve the proposal under review
64
-
through constructive criticism and, eventually, determine the direction of
65
-
Swift-Foundation. When writing your review, here are some questions you might want to
66
-
answer in your review:
67
-
68
-
* What is your evaluation of the proposal?
69
-
* Does this proposal fit well with the feel and direction of Swift-Foundation?
70
-
* If you have used other languages or libraries with a similar
71
-
feature, how do you feel that this proposal compares to those?
72
-
* How much effort did you put into your review? A glance, a quick
73
-
reading, or an in-depth study?
74
-
75
-
More information about Swift-Foundation review process is available at
0 commit comments