[Sema]Coerce to rvalue when withoutActuallyEscaping receives an lvalue argument

Author: stzn

lib/Sema/CSApply.cpp

@@ -8217,7 +8217,7 @@ Expr *ExprRewriter::finishApply(ApplyExpr *apply, Type openedType,
         // Resolve into a MakeTemporarilyEscapableExpr.
         auto *args = apply->getArgs();
         assert(args->size() == 2 && "should have two arguments");
-        auto *nonescaping = args->getExpr(0);
+        auto *nonescaping = cs.coerceToRValue(args->getExpr(0));
         auto *body = args->getExpr(1);
         auto bodyTy = cs.getType(body)->getWithoutSpecifierType();
         auto bodyFnTy = bodyTy->castTo<FunctionType>();

test/Sema/without_actually_escaping.swift

@@ -0,0 +1,41 @@
+// RUN: %target-typecheck-verify-swift
+
+func noEscapeWAE(f: () -> Void) {
+  withoutActuallyEscaping(f) { $0() }  
+}
+
+func escapingWAE(f: @escaping () -> Void) {
+  withoutActuallyEscaping(f) { $0() }  
+}
+
+func inoutWAE(f: inout () -> Void) {
+  withoutActuallyEscaping(f) { $0() }  
+}
+
+func rethrowThroughInoutWAE(f: inout () throws -> Void) throws {
+  try withoutActuallyEscaping(f) { try $0() }  
+}
+
+func consumingWAE(f: consuming @escaping () -> Void) {
+  withoutActuallyEscaping(f) { $0() }  
+}
+
+func rethrowThroughConsumingWAE(f: consuming @escaping () throws -> Void) throws {
+  try withoutActuallyEscaping(f) { try $0() }  
+}
+
+func sendingEscapingAsyncWAE(f: sending @escaping () async -> Void) {
+  await withoutActuallyEscaping(f) { await $0() }  
+}
+
+func rethrowThroughSendingEscapingAsyncWAE(f: sending @escaping () async throws -> Void) throws {
+  try await withoutActuallyEscaping(f) { try await $0() }  
+}
+
+func sendingNoEscapeAsyncWAE(f: sending () async -> Void) {
+  await withoutActuallyEscaping(f) { await $0() }  
+}
+
+func rethrowThroughSendingNoEscapeAsyncWAE(f: sending () async throws -> Void) throws {
+  try await withoutActuallyEscaping(f) { try await $0() }  
+}