Unconditionally add global vars

Author: elsh

lib/SIL/IR/SILSymbolVisitor.cpp

@@ -599,18 +599,18 @@ class SILSymbolVisitorImpl : public ASTVisitor<SILSymbolVisitorImpl> {
     }
 
     // Statically/globally stored variables have some special handling.
-    // Global accessor gets no linkage limit in the same resilience domain,
-    // e.g. in package with non-resilient access optimizations enabled,
-    // so it should be added in such case.
-    if (!VD->isResilient() ||
-        VD->getModuleContext()->allowNonResilientAccess()) {
-      if (VD->hasStorage() && isGlobalOrStaticVar(VD)) {
-        if (!shouldSkipVisit(getDeclLinkage(VD))) {
-          Visitor.addGlobalVar(VD);
-        }
-        if (VD->isLazilyInitializedGlobal())
-          addFunction(SILDeclRef(VD, SILDeclRef::Kind::GlobalAccessor));
+    // Global accessor should get no linkage limit and get non-hidden
+    // linkage in the same resilience domain, e.g. in the same package,
+    // so add them regardless of whether modules are built resiliently
+    // or not. If module is built resiliently without non-resilience
+    // package optimization, it gets a hidden linkage and gets ignored
+    // anyway, so there's no harm in doing so.
+    if (VD->hasStorage() && isGlobalOrStaticVar(VD)) {
+      if (!shouldSkipVisit(getDeclLinkage(VD))) {
+        Visitor.addGlobalVar(VD);
       }
+      if (VD->isLazilyInitializedGlobal())
+        addFunction(SILDeclRef(VD, SILDeclRef::Kind::GlobalAccessor));
     }
 
     visitAbstractStorageDecl(VD);