Skip to content

Commit 8956de4

Browse files
committed
[ConstraintSystem] Audit remaining arguments for packElementOpener to type
resolution.
1 parent 5895356 commit 8956de4

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

lib/Sema/CSSolver.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1191,7 +1191,6 @@ void ConstraintSystem::shrink(Expr *expr) {
11911191
// let foo: [Array<Float>] = [[0], [1], [2]] as [Array]
11921192
// let foo: [Array<Float>] = [[0], [1], [2]] as [Array<_>]
11931193
/*unboundTyOpener*/ nullptr, /*placeholderHandler*/ nullptr,
1194-
// FIXME: Open pack elements with a PackElementOf constraint.
11951194
/*packElementOpener*/ nullptr);
11961195

11971196
// Looks like coercion type is invalid, let's skip this sub-tree.

lib/Sema/PreCheckExpr.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1466,7 +1466,7 @@ TypeExpr *PreCheckExpression::simplifyNestedTypeExpr(UnresolvedDotExpr *UDE) {
14661466
// FIXME: Don't let placeholder types escape type resolution.
14671467
// For now, just return the placeholder type.
14681468
PlaceholderType::get,
1469-
// FIXME: Open pack elements with a PackElementOf constraint.
1469+
// TypeExpr pack elements are opened in CSGen.
14701470
/*packElementOpener*/ nullptr);
14711471

14721472
if (BaseTy->mayHaveMembers()) {
@@ -2221,7 +2221,7 @@ Expr *PreCheckExpression::simplifyTypeConstructionWithLiteralArg(Expr *E) {
22212221
// FIXME: Don't let placeholder types escape type resolution.
22222222
// For now, just return the placeholder type.
22232223
PlaceholderType::get,
2224-
// FIXME: Open pack elements with a PackElementOf constraint.
2224+
// Pack elements for CoerceExprs are opened in CSGen.
22252225
/*packElementOpener*/ nullptr);
22262226

22272227
if (result->hasError())

0 commit comments

Comments
 (0)