Merge pull request #64931 from xedin/rdar-100369066

[Diagnostics] Forgo all restrictions if one side of conversion has in…

Author: xedin

lib/Sema/CSSimplify.cpp

@@ -5157,6 +5157,14 @@ bool ConstraintSystem::repairFailures(
       if (auto *inoutExpr = dyn_cast<InOutExpr>(AE->getSrc())) {
         auto *loc = getConstraintLocator(inoutExpr);
 
+        // Remove all of the restrictions because none of them
+        // are going to succeed.
+        conversionsOrFixes.erase(
+            llvm::remove_if(
+                conversionsOrFixes,
+                [](const auto &entry) { return bool(entry.getRestriction()); }),
+            conversionsOrFixes.end());
+
         if (hasFixFor(loc, FixKind::RemoveAddressOf))
           return true;
 

test/Constraints/lvalues.swift

@@ -302,3 +302,11 @@ func test_incorrect_inout_at_assignment_source() {
     s.prop = &val // expected-error {{'&' may only be used to pass an argument to inout parameter}}
   }
 }
+
+// rdar://100369066 - type of expression is ambiguous when `&` is used incorrectly
+func test_invalid_inout_with_restrictions(lhs: inout any BinaryInteger, rhs: any BinaryInteger) {
+  lhs = &rhs // expected-error {{'&' may only be used to pass an argument to inout parameter}}
+
+  var other: (any BinaryInteger)? = nil
+  other = &rhs // expected-error {{'&' may only be used to pass an argument to inout parameter}}
+}