Skip to content

Commit c52d24f

Browse files
xedinktoso
authored andcommitted
[Concurrent] Restored old symbol for obsoleted Task.startSynchronously
#80821 added `@isolated(any)` which is an ABI breaking change but since we are not planning to keep this API around, let's use `@_silgen_name` to bring the old name back for now. Resolves: rdar://152178221
1 parent f9f8321 commit c52d24f

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

stdlib/public/Concurrency/Task+immediate.swift.gyb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,16 @@ import Swift
3232
@available(SwiftStdlib 6.2, *)
3333
extension Task where Failure == ${FAILURE_TYPE} {
3434

35+
// FIXME: This method is left in place to give adopters time to switch to `immediate` but it's going
36+
// to be removed soon, since this spelling was rejected as part of SE-0472 proposal.
3537
@available(SwiftStdlib 6.2, *)
3638
@available(*, deprecated, renamed: "immediate")
39+
// Used to preserve the symbols as originally declared without `@isolated(any)` attribute on `operation:`.
40+
% if FAILURE_TYPE == "Error":
41+
@_silgen_name("$sScTss5Error_pRs_rlE18startSynchronously4name8priority_ScTyxsAA_pGSSSg_ScPSgxyYaKcntFZ")
42+
% elif FAILURE_TYPE == "Never":
43+
@_silgen_name("$sScTss5NeverORs_rlE18startSynchronously4name8priority_ScTyxABGSSSg_ScPSgxyYaKcntFZ")
44+
% end
3745
@discardableResult
3846
public static func startSynchronously(
3947
name: String? = nil,

test/abi/macOS/arm64/concurrency.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,8 +391,8 @@ Added: _swift_task_getCurrentTaskName
391391

392392
// startSynchronously, immediate, addImmediateTask{UnlessCancelled}
393393
Added: _swift_task_immediate
394-
Added: _$sScTss5Error_pRs_rlE18startSynchronously4name8priority_ScTyxsAA_pGSSSg_ScPSgxyYaKYAcntFZ
395-
Added: _$sScTss5NeverORs_rlE18startSynchronously4name8priority_ScTyxABGSSSg_ScPSgxyYaKYAcntFZ
394+
Added: _$sScTss5Error_pRs_rlE18startSynchronously4name8priority_ScTyxsAA_pGSSSg_ScPSgxyYaKcntFZ
395+
Added: _$sScTss5NeverORs_rlE18startSynchronously4name8priority_ScTyxABGSSSg_ScPSgxyYaKcntFZ
396396

397397
// isIsolatingCurrentContext
398398
Added: _swift_task_invokeSwiftIsIsolatingCurrentContext

test/abi/macOS/x86_64/concurrency.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,8 +391,8 @@ Added: _swift_task_getCurrentTaskName
391391

392392
// startSynchronously, immediate, addImmediateTask{UnlessCancelled}
393393
Added: _swift_task_immediate
394-
Added: _$sScTss5Error_pRs_rlE18startSynchronously4name8priority_ScTyxsAA_pGSSSg_ScPSgxyYaKYAcntFZ
395-
Added: _$sScTss5NeverORs_rlE18startSynchronously4name8priority_ScTyxABGSSSg_ScPSgxyYaKYAcntFZ
394+
Added: _$sScTss5Error_pRs_rlE18startSynchronously4name8priority_ScTyxsAA_pGSSSg_ScPSgxyYaKcntFZ
395+
Added: _$sScTss5NeverORs_rlE18startSynchronously4name8priority_ScTyxABGSSSg_ScPSgxyYaKcntFZ
396396

397397
// isIsolatingCurrentContext
398398
Added: _swift_task_invokeSwiftIsIsolatingCurrentContext

0 commit comments

Comments
 (0)