Skip to content

Commit d553d04

Browse files
AnthonyLatsisAnthonyLatsis
authored
Merge pull request #62355 from AnthonyLatsis/sr-no-sr
[NFC] Migrate remnant Jira issue references to GitHub issues
2 parents ce61927 + cdda4ae commit d553d04

25 files changed

+45
-43
lines changed

‎CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1171,7 +1171,7 @@ endif()
11711171
# declares the swift-stdlib-* set of targets. These targets will then
11721172
# implicitly depend on any targets declared with IS_STDLIB.
11731173
#
1174-
# https://bugs.swift.org/browse/SR-5975
1174+
# https://github.com/apple/swift/issues/48534
11751175
if(SWIFT_BUILD_STDLIB)
11761176
add_subdirectory(stdlib)
11771177
else()
@@ -1211,7 +1211,7 @@ if(SWIFT_INCLUDE_TOOLS)
12111211

12121212
# Always include this after including stdlib/!
12131213
# Refer to the large comment above the add_subdirectory(stdlib) call.
1214-
# https://bugs.swift.org/browse/SR-5975
1214+
# https://github.com/apple/swift/issues/48534
12151215
add_subdirectory(tools)
12161216

12171217
# Localization targets are configured in a way that assume the swift

‎benchmark/single-source/BufferFill.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public func bufferFillFromSliceTeardown() {
5555
public func bufferFillFromSliceExecute(n: Int) {
5656
// Measure performance when filling an UnsafeBuffer from a Slice
5757
// of a Collection that supports `withContiguousStorageIfAvailable`
58-
// See: https://bugs.swift.org/browse/SR-14491
58+
// See: https://github.com/apple/swift/issues/56846
5959

6060
for _ in 0..<n {
6161
let slice = Slice(base: a, bounds: a.indices)
@@ -87,7 +87,7 @@ public func rawBufferCopyBytesTeardown() {
8787
public func rawBufferCopyBytesExecute(n: Int) {
8888
// Measure performance when copying bytes into an UnsafeRawBuffer
8989
// from a Collection that supports `withContiguousStorageIfAvailable`
90-
// See: https://bugs.swift.org/browse/SR-14886
90+
// See: https://github.com/apple/swift/issues/57233
9191

9292
for _ in 0..<n {
9393
rb.copyBytes(from: ra)
@@ -112,7 +112,7 @@ public func rawBufferInitializeMemoryTeardown() {
112112
public func rawBufferInitializeMemoryExecute(n: Int) {
113113
// Measure performance when initializing an UnsafeRawBuffer
114114
// from a Collection that supports `withContiguousStorageIfAvailable`
115-
// See: https://bugs.swift.org/browse/SR-14982
115+
// See: https://github.com/apple/swift/issues/57324
116116

117117
for _ in 0..<n {
118118
var (iterator, initialized) = rb.initializeMemory(as: Int.self, from: a)
@@ -154,7 +154,7 @@ public func rawBufferCopyContentsTeardown() {
154154
public func rawBufferCopyContentsExecute(n: Int) {
155155
// Measure performance of copying bytes from an
156156
// `UnsafeRawBufferPointer` to an `UnsafeMutableBufferPointer<UInt8>`.
157-
// See: https://bugs.swift.org/browse/SR-9604
157+
// See: https://github.com/apple/swift/issues/52050
158158

159159
for _ in 0..<n {
160160
var (iterator, initialized) = b8.initialize(from: r8)

‎benchmark/single-source/DictionaryCopy.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
// This benchmark checks for quadratic behavior while copying elements in hash
1414
// order between Dictionaries of decreasing capacity
1515
//
16-
// https://bugs.swift.org/browse/SR-3268
16+
// https://github.com/apple/swift/issues/45856
1717

1818
import TestsUtils
1919

‎cmake/modules/Libdispatch.cmake

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ endif()
5050
# Build any target libdispatch if needed.
5151
foreach(sdk ${SWIFT_SDKS})
5252
# Darwin targets have libdispatch available, do not build it.
53-
# Wasm/WASI doesn't support libdispatch yet. See https://bugs.swift.org/browse/SR-12097 for more details.
53+
# Wasm/WASI doesn't support libdispatch yet.
54+
# See https://github.com/apple/swift/issues/54533 for more details.
5455
if(NOT "${sdk}" IN_LIST SWIFT_DARWIN_PLATFORMS AND NOT "${sdk}" STREQUAL WASI)
5556
list(APPEND DISPATCH_SDKS "${sdk}")
5657
endif()

‎include/swift/ABI/Metadata.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ using TypeContextDescriptor = TargetTypeContextDescriptor<InProcess>;
173173
template<template <typename Runtime> class ObjCInteropKind, unsigned PointerSize>
174174
using ExternalTypeContextDescriptor = TargetTypeContextDescriptor<External<ObjCInteropKind<RuntimeTarget<PointerSize>>>>;
175175

176-
// FIXME: https://bugs.swift.org/browse/SR-1155
176+
// FIXME: https://github.com/apple/swift/issues/43763
177177
#pragma clang diagnostic push
178178
#pragma clang diagnostic ignored "-Winvalid-offsetof"
179179

‎include/swift/AST/AutoDiff.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ struct AutoDiffConfig {
218218
return AutoDiffConfig(parameterIndices, resultIndices, signature);
219219
}
220220

221-
// TODO(SR-13506): Use principled mangling for AD-generated symbols.
221+
// TODO(https://github.com/apple/swift/issues/52204): Use principled mangling for AD-generated symbols.
222222
std::string mangle() const {
223223
std::string result = "src_";
224224
interleave(

‎include/swift/AST/DiagnosticsFrontend.def

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ WARNING(warning_module_shadowing_may_break_module_interface,none,
399399
"public %0 %1 shadows module %2, which may cause failures when "
400400
"importing %3 or its clients in some configurations; please rename "
401401
"either the %0 %1 or the module %2, or see "
402-
"https://bugs.swift.org/browse/SR-14195 for workarounds",
402+
"https://github.com/apple/swift/issues/56573 for workarounds",
403403
(DescriptiveDeclKind, FullyQualified<Type>,
404404
/*shadowedModule=*/ModuleDecl *, /*interfaceModule*/ModuleDecl *))
405405
REMARK(rebuilding_module_from_interface,none,

‎include/swift/AST/DiagnosticsSema.def

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3538,7 +3538,7 @@ ERROR(derivative_attr_nonfinal_class_init_unsupported,none,
35383538
"making %0 final", (Type))
35393539
ERROR(derivative_attr_unsupported_accessor_kind,none,
35403540
"cannot register derivative for %0", (/*accessorKind*/ DescriptiveDeclKind))
3541-
// TODO(SR-13096): Remove this temporary diagnostic.
3541+
// TODO(https://github.com/apple/swift/issues/55542): Remove this temporary diagnostic.
35423542
ERROR(derivative_attr_class_setter_unsupported,none,
35433543
"cannot yet register derivative for class property or subscript setters",
35443544
())

‎include/swift/SILOptimizer/Differentiation/Common.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ raw_ostream &getADDebugStream();
5656
/// %index_1 = integer_literal $Builtin.Word, 1
5757
/// %elt1 = index_addr %elt0, %index_1 // element address
5858
/// ...
59-
// TODO(SR-12894): Find a better name and move this general utility to
60-
// ArraySemantic.h.
59+
// TODO(https://github.com/apple/swift/issues/55340): Find a better name and move this general utility to ArraySemantic.h.
6160
ApplyInst *getAllocateUninitializedArrayIntrinsicElementAddress(SILValue v);
6261

6362
/// Given a value, finds its single `destructure_tuple` user if the value is

‎test/AutoDiff/compiler_crashers_fixed/issue-54935-differentiable-function-extract-subst-function-type.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
// SIL verification error regarding substituted function types and
55
// `differentiable_function_extract` instruction. Occurs only with `-O`.
66

7-
// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
8-
// REQUIRES: SR13021
7+
// FIXME(https://github.com/apple/swift/issues/55466): Disabled due to flakiness on Linux , likely related to TF-1197.
8+
// XFAIL: *
99

1010
import _Differentiation
1111

‎test/AutoDiff/compiler_crashers_fixed/issue-55094-noderivative-parameter-type-mangling.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
// IRGenDebugInfo type reconstruction crash because `@noDerivative` parameters
55
// are not mangled
66

7-
// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
8-
// REQUIRES: SR13021
7+
// FIXME(https://github.com/apple/swift/issues/55466): Disabled due to flakiness on Linux, likely related to TF-1197.
8+
// REQUIRES: issue_55466
99

1010
import _Differentiation
1111
func id(_ x: Float, _ y: Float) -> Float { x }

‎test/AutoDiff/compiler_crashers_fixed/issue-55177-optimize-partial-apply-convention-thin-only.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
// Do not rewrite `partial_apply` to `thin_to_thick_function` if the specialized
77
// callee is not `@convention(thin)`.
88

9-
// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
10-
// REQUIRES: SR13021
9+
// FIXME(https://github.com/apple/swift/issues/55466): Disabled due to flakiness on Linux, likely related to TF-1197.
10+
// REQUIRES: issue_55466
1111

1212
import DifferentiationUnittest
1313

‎test/AutoDiff/compiler_crashers_fixed/issue-55333-55334-vjp-emitter-definite-initialization.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
// Debug scope error for pullback struct `struct` instruction generated
1212
// by `VJPEmitter`
1313

14-
// FIXME: Disabled due to flakiness on Linux (https://github.com/apple/swift/issues/55466), likely related to TF-1197.
15-
// REQUIRES: SR13021
14+
// FIXME(https://github.com/apple/swift/issues/55466): Disabled due to flakiness on Linux, likely related to TF-1197.
15+
// XFAIL: *
1616

1717
import _Differentiation
1818

‎test/AutoDiff/compiler_crashers_fixed/tf1232-autodiff-generated-declaration-mangling.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// RUN: %target-build-swift -g %s
2-
// FIXME: This test occasionally fails to link (https://github.com/apple/swift/issues/57125).
3-
// REQUIRES: SR14775
2+
3+
// FIXME(https://github.com/apple/swift/issues/57125): This test occasionally fails to link.
4+
// REQUIRES: issue_57125
45

56
// TF-1232: IRGenDebugInfo crash due to lack of proper mangling for
67
// AutoDiff-generated declarations: linear map structs and branching trace

‎test/ClangImporter/MixedSource/import-mixed-with-header.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
// RUN: rm -rf %t/mixed-target/
1313
// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk-nosource -I %t) -I %S/../Inputs/custom-modules -enable-objc-interop -typecheck %s -verify
1414

15-
// REQUIRES: SR7768
15+
// FIXME: Disabled due to https://github.com/apple/swift/issues/50307.
16+
// REQUIRES: issue_50307
1617

1718
import MixedWithHeader
1819

‎test/Driver/loaded_module_trace_swiftinterface.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// UNSUPPORTED: OS=windows-msvc
2-
// REQUIRES: SR13034
2+
3+
// FIXME: Disabled due to https://github.com/apple/swift/issues/55480.
4+
// REQUIRES: issue_55480
35

46
// 1) If there is no swiftmodule, use the swiftinterface
57
//

‎test/IDE/complete_in_closures.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ struct NestedStructWithClosureMember1 {
104104
struct StructWithClosureMemberAndLocal {
105105
var c = {
106106
var x = 0
107-
#^DELAYED_10?check=WITH_GLOBAL_DECLS_AND_LOCAL1;xfail=sr16012^#
107+
#^DELAYED_10?check=WITH_GLOBAL_DECLS_AND_LOCAL1;xfail=https://github.com/apple/swift/issues/58273^#
108108
}
109109
}
110110

‎test/IRGen/empty_array.sil

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@
88
// REQUIRES: CODEGENERATOR=X86
99
// REQUIRES: CODEGENERATOR=ARM
1010

11-
// FIXME: https://github.com/apple/swift/issues/46187 test is failing after
12-
// being unintentionally disabled for a while.
13-
// REQUIRES: SR3602
11+
// FIXME(https://github.com/apple/swift/issues/46187): test is failing after being unintentionally disabled for a while.
12+
// XFAIL: *
1413

1514
sil_stage canonical
1615

‎test/Interop/Cxx/templates/swift-class-instantiation-in-namespace-module-interface.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
// RUN: %target-swiftxx-frontend -emit-module -o %t/SwiftClassTemplateInNamespaceModule.swiftmodule %S/Inputs/SwiftClassTemplateInNamespaceModule.swift -I %S/Inputs -enable-library-evolution -swift-version 5
33
// RUN: %target-swift-ide-test -print-module -module-to-print=SwiftClassTemplateInNamespaceModule -I %t/ -source-filename=x -enable-experimental-cxx-interop | %FileCheck %s
44

5-
// The following bug needs to be resolved so decls in __ObjC don't disappear.
6-
// REQUIRES: SR-14211
5+
// FIXME(https://github.com/apple/swift/issues/56589): The following bug needs to be resolved so decls in __ObjC don't disappear.
6+
// XFAIL: *
77

88
// CHECK: import ClassTemplateInNamespaceForSwiftModule
99
// CHECK: func receiveShip(_ i: inout Space.__CxxTemplateInstN5Space4ShipIbEE)

‎test/Interop/Cxx/templates/swift-class-instantiation-nested-type-module-interface.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
// RUN: %target-swiftxx-frontend -emit-module -o %t/SwiftClassTemplateNestedTypeModule.swiftmodule %S/Inputs/SwiftClassTemplateNestedTypeModule.swift -I %S/Inputs -enable-library-evolution -swift-version 5
33
// RUN: %target-swift-ide-test -print-module -module-to-print=SwiftClassTemplateNestedTypeModule -I %t/ -source-filename=x -enable-experimental-cxx-interop | %FileCheck %s
44

5-
// REQUIRES: SR-13261
5+
// FIXME: Disabled due to https://github.com/apple/swift/issues/55701.
6+
// XFAIL: *
67

78
// CHECK: import ClassTemplateNestedTypeForSwiftModule
89
// CHECK: func receiveShipEngine(_ i: inout Space.__CxxTemplateInstN5Space4ShipIbEE)

‎test/ModuleInterface/module_shadowing.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@
2727

2828
#if !SELF_SHADOW
2929
import ShadowyHorror
30-
// OTHER-DAG: ShadowyHorror.module_shadowing:{{[0-9]+:[0-9]+}}: warning: public class 'ShadowyHorror.module_shadowing' shadows module 'module_shadowing', which may cause failures when importing 'module_shadowing' or its clients in some configurations; please rename either the class 'ShadowyHorror.module_shadowing' or the module 'module_shadowing', or see https://bugs.swift.org/browse/SR-14195 for workarounds{{$}}
30+
// OTHER-DAG: ShadowyHorror.module_shadowing:{{[0-9]+:[0-9]+}}: warning: public class 'ShadowyHorror.module_shadowing' shadows module 'module_shadowing', which may cause failures when importing 'module_shadowing' or its clients in some configurations; please rename either the class 'ShadowyHorror.module_shadowing' or the module 'module_shadowing', or see https://github.com/apple/swift/issues/56573 for workarounds{{$}}
3131

3232
@_implementationOnly import TestModule
3333
#endif
3434

3535
public struct ShadowyHorror {
36-
// OTHER-DAG: module_shadowing.swift:[[@LINE-1]]:15: warning: public struct 'module_shadowing.ShadowyHorror' shadows module 'ShadowyHorror', which may cause failures when importing 'module_shadowing' or its clients in some configurations; please rename either the struct 'module_shadowing.ShadowyHorror' or the module 'ShadowyHorror', or see https://bugs.swift.org/browse/SR-14195 for workarounds{{$}}
37-
// SELF: module_shadowing.swift:[[@LINE-2]]:15: warning: public struct 'ShadowyHorror.ShadowyHorror' shadows module 'ShadowyHorror', which may cause failures when importing 'ShadowyHorror' or its clients in some configurations; please rename either the struct 'ShadowyHorror.ShadowyHorror' or the module 'ShadowyHorror', or see https://bugs.swift.org/browse/SR-14195 for workarounds{{$}}
36+
// OTHER-DAG: module_shadowing.swift:[[@LINE-1]]:15: warning: public struct 'module_shadowing.ShadowyHorror' shadows module 'ShadowyHorror', which may cause failures when importing 'module_shadowing' or its clients in some configurations; please rename either the struct 'module_shadowing.ShadowyHorror' or the module 'ShadowyHorror', or see https://github.com/apple/swift/issues/56573 for workarounds{{$}}
37+
// SELF: module_shadowing.swift:[[@LINE-2]]:15: warning: public struct 'ShadowyHorror.ShadowyHorror' shadows module 'ShadowyHorror', which may cause failures when importing 'ShadowyHorror' or its clients in some configurations; please rename either the struct 'ShadowyHorror.ShadowyHorror' or the module 'ShadowyHorror', or see https://github.com/apple/swift/issues/56573 for workarounds{{$}}
3838

3939
init() {}
4040
public var property: ShadowyHorror { ShadowyHorror() }

‎test/SILOptimizer/devirt_alloc_ref_dynamic_ownership.sil

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
// RUN: %target-sil-opt -enable-sil-verify-all %s -sil-combine -devirtualizer -dce | %FileCheck %s
22

3-
// REQUIRES: SR9831
4-
53
sil_stage canonical
64

75
import Builtin

‎test/SymbolGraph/Module/DocAttrExportedImport.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
// INTERNAL-DAG: "precise":"s:1B9StructOneV"
2525

2626
// FIXME: Symbols from `@_exported import` do not get emitted when using swift-symbolgraph-extract
27-
// This is tracked by https://bugs.swift.org/browse/SR-15921.
27+
// This is tracked by https://github.com/apple/swift-docc/issues/179.
2828

2929
// FILES-NOT: [email protected]
3030

‎userdocs/diagnostics/multiple-inheritance.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ struct Ladle: ServingUtensil, Spoon { /* ... */ }
3232

3333
Swift protocols can declare interfaces that must be implemented by each conforming type (like abstract class members in other programming languages such as C# or Java), and they can also provide overridable default implementations for those requirements in protocol extensions.
3434

35-
When class inheritance and protocol conformances are used together, subclasses inherit protocol conformances from base classes, introducing additional complexity. For example, the default implementation of a protocol requirement not overridden in the conforming base class also cannot be overridden in any subclass ([SR-103](https://bugs.swift.org/browse/SR-103)).
35+
When class inheritance and protocol conformances are used together, subclasses inherit protocol conformances from base classes, introducing additional complexity. For example, the default implementation of a protocol requirement not overridden in the conforming base class also cannot be overridden in any subclass ([#42725](https://github.com/apple/swift/issues/42725)).
3636

3737
To learn more about defining and adopting protocols, see the [Protocols](https://docs.swift.org/swift-book/LanguageGuide/Protocols.html) section in _The Swift Programming Language_. To learn more about class inheritance, see the [Inheritance](https://docs.swift.org/swift-book/LanguageGuide/Inheritance.html) section in _The Swift Programming Language_.

‎utils/build-script-impl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ function is_swift_lto_enabled() {
407407
#
408408
# This is part of refactoring more work to be done or controllable via
409409
# `build-script` itself. For additional information, see:
410-
# https://bugs.swift.org/browse/SR-237
410+
# https://github.com/apple/swift/issues/42859
411411
#
412412
# To use this functionality, the script is invoked with:
413413
# ONLY_EXECUTE=<action name>
@@ -1039,7 +1039,7 @@ fi
10391039
# FIXME: HOST_CC and CMAKE are set, and their presence is validated by,
10401040
# utils/build-script. These checks are redundant, but must remain until
10411041
# build-script-impl is merged completely with utils/build-script.
1042-
# For additional information, see: https://bugs.swift.org/browse/SR-237
1042+
# For additional information, see: https://github.com/apple/swift/issues/42859
10431043
if [ -z "${HOST_CC}" ] ; then
10441044
echo "Can't find clang. Please install clang-3.5 or a later version."
10451045
exit 1
@@ -1252,7 +1252,7 @@ PRODUCTS=(llvm)
12521252
# Get the value of a host-specific variable expected to have been passed by the
12531253
# `build-script`.
12541254
#
1255-
# This is a total hack, and is part of the SR-237 migration.
1255+
# This is a total hack, and is part of the https://github.com/apple/swift/issues/42859 migration.
12561256
function get_host_specific_variable() {
12571257
local host="$1"
12581258
local name="$2"

0 commit comments

Comments
 (0)